Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 4 Mar 2019 18:45:30 -0500
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Tom Zanussi <tom.zanussi@linux.intel.com>
Cc:     Tom Zanussi <zanussi@kernel.org>, linux-kernel@vger.kernel.org,
        linux-rt-users@vger.kernel.org, Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH 2/2] tracing: Use strncpy instead of memcpy for string
 keys in hist triggers
Message-ID: <20190304184530.7e819698@gandalf.local.home>
In-Reply-To: <5c978b4b0d629e5a914c512c14f99f6a24241407.camel@linux.intel.com>
References: <cover.1549309756.git.tom.zanussi@linux.intel.com>
        <50c35ae1267d64eee975b8125e151e600071d4dc.1549309756.git.tom.zanussi@linux.intel.com>
        <20190304165000.0ce0fbdd@gandalf.local.home>
        <20190304165653.17699f9f@gandalf.local.home>
        <5643a1971831ce2d01a947f0f07cefa002bbdc25.camel@linux.intel.com>
        <5c978b4b0d629e5a914c512c14f99f6a24241407.camel@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 04 Mar 2019 16:31:40 -0600
Tom Zanussi <tom.zanussi@linux.intel.com> wrote:

> > Hmm, I don't think it's really necessary - it's not used in a key so
> > don't care about anything after the null, and TASK_COMM_LEN is used
> > in
> > the memcpy.  
> 
> Never mind, yeah, it would make sense to do this, will create another
> patch...

And probably should change the memcpy() of comm in kernel/trace/trace.c
too. It could be that memcpy() is a little bit faster than strncpy(),
and this is done on scheduling switches when tracing is active, but
still, I'm starting to think that isn't a good choice.

-- Steve