Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190109124044.GA11935@altlinux.org> <20190109124316.GH11981@altlinux.org>
 <20190227153034.GD23744@altlinux.org>
In-Reply-To: <20190227153034.GD23744@altlinux.org>
From:   Vincent Chen <deanbo422@gmail.com>
Date:   Tue, 5 Mar 2019 08:26:36 +0800
Message-ID: <CAJsyPhzmJyJiwRSn0eB6g0BLYM0zpoSWJ=XfcBje6EJNGGQ1eA@mail.gmail.com>
Subject: Re: [PATCH 08/14] Move EM_NDS32 to uapi/linux/elf-em.h
To:     "Dmitry V. Levin" <ldv@altlinux.org>
Cc:     Greentime Hu <green.hu@gmail.com>,
        Elvira Khabirova <lineprinter@altlinux.org>,
        Eugene Syromyatnikov <esyr@redhat.com>,
        Oleg Nesterov <oleg@redhat.com>,
        Andy Lutomirski <luto@kernel.org>,
        Paul Moore <paul@paul-moore.com>, linux-audit@redhat.com,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Dmitry V. Levin <ldv@altlinux.org> =E6=96=BC 2019=E5=B9=B42=E6=9C=8827=E6=
=97=A5 =E9=80=B1=E4=B8=89 =E4=B8=8B=E5=8D=8811:30=E5=AF=AB=E9=81=93=EF=BC=
=9A


>
> This should never have been defined in the arch tree to begin with,
> and now uapi/linux/audit.h header is going to use EM_NDS32
> in order to define AUDIT_ARCH_NDS32 which is needed to implement
> syscall_get_arch() which in turn is required to extend
> the generic ptrace API with PTRACE_GET_SYSCALL_INFO request.
>
> Acked-by: Paul Moore <paul@paul-moore.com>
> Cc: Greentime Hu <green.hu@gmail.com>
> Cc: Vincent Chen <deanbo422@gmail.com>
> Cc: Elvira Khabirova <lineprinter@altlinux.org>
> Cc: Eugene Syromyatnikov <esyr@redhat.com>
> Cc: Oleg Nesterov <oleg@redhat.com>
> Cc: Andy Lutomirski <luto@kernel.org>
> Cc: linux-audit@redhat.com
> Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
> ---
>  This is just a gentle ping, the patch is unchanged.
>
>  arch/nds32/include/asm/elf.h | 3 +--
>  include/uapi/linux/elf-em.h  | 2 ++
>  2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/nds32/include/asm/elf.h b/arch/nds32/include/asm/elf.h
> index 95f3ea253e4c..02250626b9f0 100644
> --- a/arch/nds32/include/asm/elf.h
> +++ b/arch/nds32/include/asm/elf.h
> @@ -10,14 +10,13 @@
>
>  #include <asm/ptrace.h>
>  #include <asm/fpu.h>
> +#include <linux/elf-em.h>
>
>  typedef unsigned long elf_greg_t;
>  typedef unsigned long elf_freg_t[3];
>
>  extern unsigned int elf_hwcap;
>
> -#define EM_NDS32                       167
> -
>  #define R_NDS32_NONE                   0
>  #define R_NDS32_16_RELA                        19
>  #define R_NDS32_32_RELA                        20
> diff --git a/include/uapi/linux/elf-em.h b/include/uapi/linux/elf-em.h
> index bd02325028d8..4b8df722330e 100644
> --- a/include/uapi/linux/elf-em.h
> +++ b/include/uapi/linux/elf-em.h
> @@ -40,6 +40,8 @@
>  #define EM_ALTERA_NIOS2        113     /* Altera Nios II soft-core proce=
ssor */
>  #define EM_TI_C6000    140     /* TI C6X DSPs */
>  #define EM_HEXAGON     164     /* QUALCOMM Hexagon */
> +#define EM_NDS32       167     /* Andes Technology compact code size
> +                                  embedded RISC processor family */
>  #define EM_AARCH64     183     /* ARM 64 bit */
>  #define EM_TILEPRO     188     /* Tilera TILEPro */
>  #define EM_MICROBLAZE  189     /* Xilinx MicroBlaze */
> --
> ldv

Thanks for fixing this.

Acked-by Vincent Chen