Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Aisheng Dong <aisheng.dong@nxp.com>
To:     Stefan Agner <stefan@agner.ch>, BOUGH CHEN <haibo.chen@nxp.com>
CC:     Christina Quast <cquast@hanoverdisplays.com>,
        "festevam@gmail.com" <festevam@gmail.com>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "linus.walleij@linaro.org" <linus.walleij@linaro.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        BOUGH CHEN <haibo.chen@nxp.com>
Subject: RE: [PATCH] Document: dt: binding: imx: Fix PAD_CTL_DSE_X*
Thread-Topic: [PATCH] Document: dt: binding: imx: Fix PAD_CTL_DSE_X*
Thread-Index: AQHUytCIfTFXSadJckWCjEy0gWR0oKXyA8SQgAATHICAClra8A==
Date:   Tue, 5 Mar 2019 03:34:57 +0000
Message-ID: <AM0PR04MB4211737BF7A85E15090636BD80720@AM0PR04MB4211.eurprd04.prod.outlook.com>
References: <20190222170038.9669-1-cquast@hanoverdisplays.com>
 <VI1PR04MB42227AA158BA1FCBF314AA27807B0@VI1PR04MB4222.eurprd04.prod.outlook.com>
 <db6c2755e80e41f7c169406c213a40e8@agner.ch>
In-Reply-To: <db6c2755e80e41f7c169406c213a40e8@agner.ch>
Accept-Language: zh-CN, en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 607fde5f-90ce-4c13-5e33-08d6a11b8a89
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Mar 2019 03:34:57.9390
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4338
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

+ Haibo

> From: Stefan Agner [mailto:stefan@agner.ch]
> Sent: Tuesday, February 26, 2019 9:22 PM
>=20
> On 26.02.2019 13:21, Aisheng Dong wrote:
> >> From: Christina Quast [mailto:cquast@hanoverdisplays.com]
> >> Sent: Saturday, February 23, 2019 1:01 AM
> >>
> >> In the iMX7d datasheet, the PAD_CTL_DSE_X* values are different from
> >> the documentation.
> >>
> >
> > It's a doc problem.
> > Latest RM seems got updated.
> >
> > As here it's a reference definition in binding doc and device tree
> > actually does not use it (IMX Pinctrl use raw data to set pad
> > configuration). So it won't cause any compatibility issue to me.
> >
> > Please update the patch title to:
> > dt-bindings: pinctrl: imx7d: xxxxx
> >
> > Otherwise:
> > Ack-by: Dong Aisheng <aisheng.dong@nxp.com>
>=20
> Btw, I saw that imx7d-sdb.dts (and probably other i.MX 7 boards too) use =
three
> different settings for usdhc pinctrl: 0x59, 0x5a and 0x5b (for default, 1=
00MHz
> and 200MHz respectively). One would expect that higher frequency use high=
er
> driver strength (and this is the case for i.MX 6).
> But with this new/corrected pad values this means we use x4, x2 and x6 fo=
r
> default, 100MHz and 200MHz respectively. This hardly seems right..?
> Probably needs fixing too?
>=20

Yes, that's true.
Especially 100Mhz setting should be updated.

Haibo,
Can you please help double check if X2 for 50Mhz and X4 for 100Mhz can work=
 stably
on MX7D SDB?
If yes, we'd like to update the pad setting according to new RM version.

Regards
Dong Aisheng

> --
> Stefan
>=20
>=20
> >
> > Regards
> > Dong Aisheng
> >
> >> Signed-off-by: Christina Quast <cquast@hanoverdisplays.com>
> >> ---
> >>  .../devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.txt       | 6 +++--=
-
> >>  1 file changed, 3 insertions(+), 3 deletions(-)
> >>
> >> diff --git
> >> a/Documentation/devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.txt
> >> b/Documentation/devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.txt
> >> index 6666277c3acb..8ac1d0851a0f 100644
> >> --- a/Documentation/devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.txt
> >> +++ b/Documentation/devicetree/bindings/pinctrl/fsl,imx7d-pinctrl.txt
> >> @@ -48,9 +48,9 @@ PAD_CTL_HYS                     (1 << 3)
> >>  PAD_CTL_SRE_SLOW                (1 << 2)
> >>  PAD_CTL_SRE_FAST                (0 << 2)
> >>  PAD_CTL_DSE_X1                  (0 << 0)
> >> -PAD_CTL_DSE_X2                  (1 << 0)
> >> -PAD_CTL_DSE_X3                  (2 << 0)
> >> -PAD_CTL_DSE_X4                  (3 << 0)
> >> +PAD_CTL_DSE_X4                  (1 << 0)
> >> +PAD_CTL_DSE_X2                  (2 << 0)
> >> +PAD_CTL_DSE_X6                  (3 << 0)
> >>
> >
> >
> >>  Examples:
> >>  While iomuxc-lpsr is intended to be used by dedicated peripherals to
> >> take
> >> --
> >> 2.20.1
> >>
> >>
> >>
> >>
> >>
> >> Please consider the environment before printing this email
> >>
> >>
> >>
> >>
> >>
> >> The information transmitted is intended only for the person or entity
> >> to which it is addressed and may contain confidential and/or
> >> privileged material. Any review, retransmission, dissemination or
> >> other use of, or taking of any action in reliance upon, this
> >> information by persons or entities other than the intended recipient i=
s
> prohibited.
> >> If you received this in error, please contact the sender or
> >> postmaster
> >> (postmaster@hanoverdisplays.com) and delete the material from any
> >> computer.
> >> Although we routinely screen for viruses, addressees should check
> >> this e-mail and any attachment for viruses. We make no warranty as to
> >> absence of viruses in this e-mail or any attachments.
> >> Our Company's email policy is to permit incidental personal use. If
> >> this email is of a personal nature, it must not be relied upon as
> >> expressing the views or opinions of the company.