Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 4 Mar 2019 20:26:25 -0800
From:   Matthew Wilcox <willy@infradead.org>
To:     Hongbo Yao <yaohongbo@huawei.com>
Cc:     viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, linuxarm@huawei.com
Subject: Re: [PATCH] fs: Avoid signed overflow UBSAN warning
Message-ID: <20190305042625.GC13380@bombadil.infradead.org>
References: <20190223090210.116847-1-yaohongbo@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190223090210.116847-1-yaohongbo@huawei.com>
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Feb 23, 2019 at 05:02:10PM +0800, Hongbo Yao wrote:
> I ran into this:
> 	UBSAN: Undefined behaviour in fs/read_write.c:251:11
> 	signed integer overflow:
> 	9223372036854775805 + 9223372036854775805 cannot be represented in
> 	type 'long long int'
> 
> Use unsigned types to do math, it doesn't throw a UBSAN warning
> when it does overflow.This patch doesn't change generated code.

You don't need to be this verbose to fix it.

> -			offset += file->f_pos;
> +			offset = (u64)file->f_pos + (u64)offset;

			offset += (u64)file->f_pos;