Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp3270226imb; Tue, 5 Mar 2019 05:24:46 -0800 (PST) X-Google-Smtp-Source: APXvYqysAPY9Sb3OPv8gizse7+qKK9qOsU126bjMvdXhUEiIiPIofCjijuowq+2Rh+9BYrn/WDW6 X-Received: by 2002:a65:5c4b:: with SMTP id v11mr1343865pgr.411.1551792285990; Tue, 05 Mar 2019 05:24:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551792285; cv=none; d=google.com; s=arc-20160816; b=0FfqVCKH5q2bG6D4MDs7Bb4+Q2kEDXCnlIfEnvOXlQw+m8Qe0IVRq0aXm4Q2VyAslJ d87cyqkphRi0xofvM+4/d/Z9uVC/UCPHJzH+GNpnyrGMhHcN/eOLNvI69ZnRPx0YwkBp 5xQLucaNUhkhemy1JZZ8bm1FVWL541hUNXO+BC+OG8YSF40ntStM2ceIuw4ebG/k55JE F+YjRigBCGuMyrnTzfueaVfMh/XIIFsYLWhrcHihlLVKCMaxrzrlTM9oaCF/Y1Mv6Nqe WnyBgO50Fub9Dre3kweS4gPaqU1HkHqgHOwQc8zHr4SfjsR9e7i0gZdKHIdlIfoiR3UA otqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=n//axggka+mboVWnhWZi4C655sNfmdKEoLGiepsXiG0=; b=V+jO8UVyy8xJ+XpWygrYWp9L8TIC4zjyuCAJVVS2iCGPg5qdDo3jRxzWABdensYrEs YvE9Njq+9yQ88ABiG7IASrUNVSo+pPRdmSZjK838VwGoPvC7PDNfJg2DvMMlMNNAfE9M rSUzTUiOUB7c/Ig6DR9FnGMcxZF5RhiIB9tZhW/+Hq5QPH+2/t3u+Wo7/9uSyyzoLlvK ZgSQLpE1tTqtq4YYdY5wNbI5ZX7zexZXiOVbUM9G88kOK8Wpm79j9+/G5ofJFQKCKpwv F+KIfjxjsik5OQ45wqo9c/e/wOudQTvWjnGRSUFrCooYyY+4dWrV/YrmjOk0Dd0G3kb5 ga4A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n5si7800100pff.191.2019.03.05.05.24.11; Tue, 05 Mar 2019 05:24:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727807AbfCELcD (ORCPT + 99 others); Tue, 5 Mar 2019 06:32:03 -0500 Received: from out1.zte.com.cn ([202.103.147.172]:40602 "EHLO mxct.zte.com.cn" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727213AbfCELcD (ORCPT ); Tue, 5 Mar 2019 06:32:03 -0500 Received: from mse01.zte.com.cn (unknown [10.30.3.20]) by Forcepoint Email with ESMTPS id 3CB01487A4905C78CFFB; Tue, 5 Mar 2019 19:32:00 +0800 (CST) Received: from notes_smtp.zte.com.cn ([10.30.1.239]) by mse01.zte.com.cn with ESMTP id x25BVqfZ071180; Tue, 5 Mar 2019 19:31:52 +0800 (GMT-8) (envelope-from wen.yang99@zte.com.cn) Received: from fox-host8.localdomain ([10.74.120.8]) by szsmtp06.zte.com.cn (Lotus Domino Release 8.5.3FP6) with ESMTP id 2019030519320874-3290796 ; Tue, 5 Mar 2019 19:32:08 +0800 From: Wen Yang To: linux-kernel@vger.kernel.org Cc: wang.yi59@zte.com.cn, Wen Yang , Russell King , Heiko Stuebner , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: [PATCH 3/4] ARM: rockchip: fix a leaked reference by adding missing of_node_put Date: Tue, 5 Mar 2019 19:32:56 +0800 Message-Id: <1551785577-45896-3-git-send-email-wen.yang99@zte.com.cn> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1551785577-45896-1-git-send-email-wen.yang99@zte.com.cn> References: <1551785577-45896-1-git-send-email-wen.yang99@zte.com.cn> X-MIMETrack: Itemize by SMTP Server on SZSMTP06/server/zte_ltd(Release 8.5.3FP6|November 21, 2013) at 2019-03-05 19:32:08, Serialize by Router on notes_smtp/zte_ltd(Release 9.0.1FP7|August 17, 2016) at 2019-03-05 19:31:48, Serialize complete at 2019-03-05 19:31:48 X-MAIL: mse01.zte.com.cn x25BVqfZ071180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The call to of_get_next_child returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: ./arch/arm/mach-rockchip/platsmp.c:250:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 241, but without a corresponding object release within this function. ./arch/arm/mach-rockchip/platsmp.c:260:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 241, but without a corresponding object release within this function. ./arch/arm/mach-rockchip/platsmp.c:263:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 241, but without a corresponding object release within this function. Signed-off-by: Wen Yang Cc: Russell King Cc: Heiko Stuebner Cc: linux-arm-kernel@lists.infradead.org Cc: linux-rockchip@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- arch/arm/mach-rockchip/platsmp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-rockchip/platsmp.c b/arch/arm/mach-rockchip/platsmp.c index f93d64e..6cb4b21 100644 --- a/arch/arm/mach-rockchip/platsmp.c +++ b/arch/arm/mach-rockchip/platsmp.c @@ -245,6 +245,7 @@ static int __init rockchip_smp_prepare_pmu(void) } pmu_base = of_iomap(node, 0); + of_node_put(node); if (!pmu_base) { pr_err("%s: could not map pmu registers\n", __func__); return -ENOMEM; -- 2.9.5