Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp3270908imb; Tue, 5 Mar 2019 05:25:56 -0800 (PST) X-Google-Smtp-Source: APXvYqxGZgizhGM/o2OUtcdGR5ay2/3T2bX4tc6kFa3n9sFqSz4/PFznWfVO+yaSrANp3V0TJGg6 X-Received: by 2002:a17:902:2bc9:: with SMTP id l67mr1193316plb.241.1551792356356; Tue, 05 Mar 2019 05:25:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551792356; cv=none; d=google.com; s=arc-20160816; b=t6R9s4SLy+tfFysE59HtlShs04wGGbdJS+0XlGZiwLI3wle5woXXQRdN8d184xPK94 W9DJyMpxXkJykK8vVaJV9Zt6H7eq2ci0sZl7lScN2tdl5CDumgyOM47DmbNPETomqr3n FGscY5BHzQ8EfOrJAs6xuedC3V0ylnMyMegZrcR6TK9KUH8/ARs9ePfP/RgMlOupCuir KkF8Ibny6Ut5jd0BsD8dOrskVAtti0G+I2/VNm9Ubef5bf8NltVoGubWsWM8HDPLEc18 hZ/lqUhLSxE8eX45fYpjLFE+ysE2QTQ2zEMzbyNIbHQgxbWMphdEIApDfx2GXsxItjKN 2e8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=wM9mgb1za5KWeBI7/Fy82ZKgRiOgDo50F1DObzpqYTA=; b=XFgZDrapdprmuic0YE1QHZ12+Y4Vy36hIOjUFDemGTvmJ0PQtOP8FaAFOdWZocD1qO N8dXciJOtK4bvw4EoGwwISCg/PVcWjG09RD4CjYoC+7ClxbqMHv8fnAlukSR+7GU28tc CHgNKX+hb2Z82OYYIje4TH7GlvmhjG68fAMT8yf8TwyprNtdNss2//stUXcPjFjfltfL bIGv8CDk0r6VvESDmoyPZStxBSLy3UaQAG9pmwH5x10LW1DIlHfwAfNE2wle4DoITs5e ShgpF7wOzWxTPe9TyAFi6RmhB2xI//GagBPIdoys4RuUafOGmVlzlLkYMO6Dg9nBVyG2 xnEg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ba5si824260plb.186.2019.03.05.05.25.40; Tue, 05 Mar 2019 05:25:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727972AbfCELdU (ORCPT + 99 others); Tue, 5 Mar 2019 06:33:20 -0500 Received: from mxhk.zte.com.cn ([63.217.80.70]:43838 "EHLO mxhk.zte.com.cn" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727942AbfCELdT (ORCPT ); Tue, 5 Mar 2019 06:33:19 -0500 Received: from mse01.zte.com.cn (unknown [10.30.3.20]) by Forcepoint Email with ESMTPS id AE70565EA93192A98AFE; Tue, 5 Mar 2019 19:33:16 +0800 (CST) Received: from notes_smtp.zte.com.cn ([10.30.1.239]) by mse01.zte.com.cn with ESMTP id x25BX9cF072592; Tue, 5 Mar 2019 19:33:09 +0800 (GMT-8) (envelope-from wen.yang99@zte.com.cn) Received: from fox-host8.localdomain ([10.74.120.8]) by szsmtp06.zte.com.cn (Lotus Domino Release 8.5.3FP6) with ESMTP id 2019030519332558-3291746 ; Tue, 5 Mar 2019 19:33:25 +0800 From: Wen Yang To: linux-kernel@vger.kernel.org Cc: wang.yi59@zte.com.cn, Wen Yang , Russell King , linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 15/15] ARM: axxia: fix a leaked reference by adding missing of_node_put Date: Tue, 5 Mar 2019 19:34:06 +0800 Message-Id: <1551785646-46173-15-git-send-email-wen.yang99@zte.com.cn> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1551785646-46173-1-git-send-email-wen.yang99@zte.com.cn> References: <1551785646-46173-1-git-send-email-wen.yang99@zte.com.cn> X-MIMETrack: Itemize by SMTP Server on SZSMTP06/server/zte_ltd(Release 8.5.3FP6|November 21, 2013) at 2019-03-05 19:33:25, Serialize by Router on notes_smtp/zte_ltd(Release 9.0.1FP7|August 17, 2016) at 2019-03-05 19:33:05, Serialize complete at 2019-03-05 19:33:05 X-MAIL: mse01.zte.com.cn x25BX9cF072592 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The call to of_get_next_child returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. Detected by coccinelle with the following warnings: ./arch/arm/mach-axxia/platsmp.c:46:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 40, but without a corresponding object release within this function. ./arch/arm/mach-axxia/platsmp.c:53:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 40, but without a corresponding object release within this function. Signed-off-by: Wen Yang Reviewed-by: Florian Fainelli Cc: Russell King Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- v2->v1: add a missing space between "adding" and "missing" arch/arm/mach-axxia/platsmp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-axxia/platsmp.c b/arch/arm/mach-axxia/platsmp.c index 502e3df..c706a11 100644 --- a/arch/arm/mach-axxia/platsmp.c +++ b/arch/arm/mach-axxia/platsmp.c @@ -42,6 +42,7 @@ static int axxia_boot_secondary(unsigned int cpu, struct task_struct *idle) return -ENOENT; syscon = of_iomap(syscon_np, 0); + of_node_put(syscon_np); if (!syscon) return -ENOMEM; -- 2.9.5