Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 5 Mar 2019 12:59:12 +0100
From:   Maxime Ripard <maxime.ripard@bootlin.com>
To:     Wen Yang <wen.yang99@zte.com.cn>
Cc:     linux-kernel@vger.kernel.org, wang.yi59@zte.com.cn,
        Chen-Yu Tsai <wens@csie.org>,
        Russell King <linux@armlinux.org.uk>,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/4] ARM: sunxi: fix a leaked reference by adding missing
 of_node_put
Message-ID: <20190305115912.bprjr3hitdmfnmrw@flea>
References: <1551785577-45896-1-git-send-email-wen.yang99@zte.com.cn>
 <1551785577-45896-4-git-send-email-wen.yang99@zte.com.cn>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="6n24zqffo6umuxrf"
Content-Disposition: inline
In-Reply-To: <1551785577-45896-4-git-send-email-wen.yang99@zte.com.cn>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--6n24zqffo6umuxrf
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 05, 2019 at 07:32:57PM +0800, Wen Yang wrote:
> The call to of_get_next_child returns a node pointer with refcount
> incremented thus it must be explicitly decremented after the last
> usage.
>=20
> Detected by coccinelle with the following warnings:
> ./arch/arm/mach-sunxi/mc_smp.c:110:1-7: ERROR: missing of_node_put; acqui=
red a node pointer with refcount incremented on line 97, but without a corr=
esponding object release within this functio
> ./arch/arm/mach-sunxi/platsmp.c:138:2-8: ERROR: missing of_node_put; acqu=
ired a node pointer with refcount incremented on line 129, but without a co=
rresponding object release within this function
>=20
> Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
> Cc: Maxime Ripard <maxime.ripard@bootlin.com>
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org (open list)

Applied, thanks!
Maxime

--=20
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

--6n24zqffo6umuxrf
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXH5kjwAKCRDj7w1vZxhR
xXVHAQCkRxUJXNH1lFYqq9xtlK3xypnBlI7nbhk00kVaqHqYdAEA25YEiTvLkRx+
64RYnAyJIE6c5C6VfueDRE/n0WiIlgw=
=Gs6K
-----END PGP SIGNATURE-----

--6n24zqffo6umuxrf--