Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp3301524imb; Tue, 5 Mar 2019 06:09:44 -0800 (PST) X-Google-Smtp-Source: APXvYqyMXVYmyyAFk9rYh55pnBOGe2kRtoRFBLwvYQDUNUpS347pVwWyVOuligYYz6ZYHp30ltxo X-Received: by 2002:a63:1a25:: with SMTP id a37mr1603212pga.428.1551794984357; Tue, 05 Mar 2019 06:09:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551794984; cv=none; d=google.com; s=arc-20160816; b=uuln8DsIiaqo0XKb1nIWuSbbgUFoerLZyu77wjQaHdsAr5Yg4/jSvIjUF+5nnPQ3IG NeROfCLxfESlqKBi5jGprhQhN1WDDkYk7tavfNl5nk6JxjJvLfx1+xPDAmYiNwNOtw7j YqzbWTJosRWkPgOP7G168RJjHAl0bmOm/p7cg2zZSvMhInsoHHQBDADnUEpdVSWhKdnm D31qcpkNTj91dQJ5h0tmjwSyFDIGD8P3MXY/YbqzFx2Ay5fFsXhbp5r4V7d3i931fEd4 jA8nOKhwtRTqbduD0m2+aRLNTcKAO93WbI//RZ2oTe153vj/xG97BjdSyJdx8/J9JMM0 ycoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :content-language:in-reply-to:mime-version:date:from:references:cc :to:subject; bh=htbslfTpB+t1jOS3QTou/5kOvk2bUTwD+eX6LZ6S9DI=; b=shb6UujPnpAdZDR14vaenu0Eq8rDBayaaQ45jDtz38ipkLITaYxKV2ye//g3gRCb3d /EeZpOr43nSio8HjuRKVsROViIqpDQxxTPu7/dSsIKPep0hru00c/o80b6S09LK4pbS5 MMx3DrKhhOIFen0+WaGQD3Z+d6a0I79cDo8ei+6atpjSw9ws1sE9d3eMWFXbc8uHbXT0 h/y6prPsjhE4+g2cR+p9u/GOAeUkLRGgp4+NkXTpA/c2kMA4hFsqeFFDYyOnhTxOjywh knjh5RG6ZHx2DvErU1sPsZEE8YMoo5wfWOZFoaadb6UldX1QBTgz4DkEeFSN/tTXKaAI 6xeA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i69si2508278plb.17.2019.03.05.06.09.28; Tue, 05 Mar 2019 06:09:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728422AbfCENkR (ORCPT + 99 others); Tue, 5 Mar 2019 08:40:17 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:53182 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727644AbfCENkQ (ORCPT ); Tue, 5 Mar 2019 08:40:16 -0500 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x25DTfZQ073750 for ; Tue, 5 Mar 2019 08:40:15 -0500 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0a-001b2d01.pphosted.com with ESMTP id 2r1rntcqjn-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 05 Mar 2019 08:40:15 -0500 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 5 Mar 2019 13:40:13 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198) by e06smtp01.uk.ibm.com (192.168.101.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 5 Mar 2019 13:40:10 -0000 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x25De9QC28049592 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 5 Mar 2019 13:40:09 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 16975A4051; Tue, 5 Mar 2019 13:40:09 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BB71EA4055; Tue, 5 Mar 2019 13:40:08 +0000 (GMT) Received: from [9.152.212.90] (unknown [9.152.212.90]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 5 Mar 2019 13:40:08 +0000 (GMT) Subject: Re: [PATCH v3 1/3] gcov: Clang: move common GCC code into gcc_base.c To: Tri Vo Cc: ghackmann@android.com, ndesaulniers@google.com, linux-kernel@vger.kernel.org, kernel-team@android.com, yamada.masahiro@socionext.com, Trilok Soni , Prasad Sodagudi References: <20190122233749.42220-1-trong@android.com> <20190122233749.42220-2-trong@android.com> From: Peter Oberparleiter Date: Tue, 5 Mar 2019 14:40:09 +0100 MIME-Version: 1.0 In-Reply-To: <20190122233749.42220-2-trong@android.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 19030513-4275-0000-0000-0000031723F8 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19030513-4276-0000-0000-000038257729 Message-Id: <531f999d-d283-3b46-dfb1-cb4b94436632@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-03-05_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=785 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1903050092 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23.01.2019 00:37, Tri Vo wrote: > From: Greg Hackmann > > base.c contains a few callbacks specific to GCC's gcov implementation. > Move these into their own module in preparation for Clang support. > > Signed-off-by: Greg Hackmann > Signed-off-by: Nick Desaulniers > Signed-off-by: Tri Vo > Tested-by: Trilok Soni > Tested-by: Prasad Sodagudi > Tested-by: Tri Vo > --- Looks good! Reviewed-by: Peter Oberparleiter -- Peter Oberparleiter Linux on Z Development - IBM Germany