Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp3500365imb; Tue, 5 Mar 2019 10:56:27 -0800 (PST) X-Google-Smtp-Source: APXvYqygpjHXJFC/8wGiToL+i5RpxOIQ9cI7djg1QzqPnx9vKCPbTjqBS9AHOcKNakpUCy2WUnZK X-Received: by 2002:a17:902:1008:: with SMTP id b8mr2675407pla.120.1551812187268; Tue, 05 Mar 2019 10:56:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551812187; cv=none; d=google.com; s=arc-20160816; b=vGZr9uwPeqaBq+NiGcLzD5z05JTO2JZ3G4IrEyFAQpKHSglDuBDdLZP/v33DIEgJfC Yf6+6TsiBn1ZBwrQAXGkiJrnShm/LZOhmyNDAzfGBJKwP3QdKdX23Cs/mmZRC0gG4qwR b93yaYvLtYagvYSQ1uO8TJ5TP7/kaZSm5FgSTaME/niQ372njIsXS9LJXoJD206mznsJ LOBTOaVd6LU8to6lCZ9NXWppxQ4gderKk2Ov0a1o1WkKPRqiMiUK8+bLHbLii7j2KHVt KVv6mksDPZZ7f/BauYWUr1lFl4drUisenpP8EguODKT7gBH7SHwkQMDY8yAoh6VFHgCG 7HJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:cc:to:subject:date:from :message-id; bh=u6s6Apgso+dKsVx2StV15sb1QDs5cbmWaslN/wpFVqE=; b=GAalguS3sgHzAyNW+8wqVgDXpxaaINAUo3AmBzbUOfZwh1a2UCYBvKSlIwZsxFSVyt PKLf2xxssi0dkv5ALUSMG1k1BsGnf/Jr3Fu3uEGHGfWi+22IaRP14nw2SdQcOPp+VHwR TK0YXPkzv3pFWXlTfwTlzP1y19qjqM1rXWSjT7H7jyIBa1iPTzGEzxZynfZVyQ6JHQ3E KFBhfEF+LOF11r1UP6Y9j6Sw2Rr13nhDlz4Z6sg/Gkd2WAK65T3UIc1y+bAlroLtE1jP Dm+txQTjrH+x1ojAOJILrGlDGqwHnajah5K0wmCJfkyDUbuwi6u4a2B20h2Lc4rJAQh1 AhTw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=diasemi.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l1si9007937pld.386.2019.03.05.10.56.11; Tue, 05 Mar 2019 10:56:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=diasemi.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730917AbfCESIi (ORCPT + 99 others); Tue, 5 Mar 2019 13:08:38 -0500 Received: from mail1.bemta25.messagelabs.com ([195.245.230.1]:20553 "EHLO mail1.bemta25.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730883AbfCESId (ORCPT ); Tue, 5 Mar 2019 13:08:33 -0500 Received: from [46.226.52.98] (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256 bits)) by server-1.bemta.az-a.eu-west-1.aws.symcld.net id E7/C0-19701-C1BBE7C5; Tue, 05 Mar 2019 18:08:28 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrKIsWRWlGSWpSXmKPExsVy8IPnUV2p3XU xBnNualpMffiEzeLblQ4mi8u75rBZfH6/n9WBxWPnrLvsHptWdbJ5TJ/zn9Hj8ya5AJYo1sy8 pPyKBNaM/tcrWQp28lesffWcuYHxOk8XIxeHkMA6Ronv794xdzFyAjkVEu/+/mYEsXkFHCTu3 7jMCmKzCRhKzHvzHijOwcEioCLx/2omSFhYwFvi9N5zYOUiAh4Srds3MIPMZBboY5TYfP4CG8 QcQYmTM5+wgNjMAhISB1+8YAaZIySgJbH8WCRIWELAXmL6+6tgYQkBfYnGY7EQYUOJ77O+sUD Y5hK3Vz9gncDIPwvJ0FlIhi5gZFrFaJFUlJmeUZKbmJmja2hgoGtoaKRraGmia2RkqpdYpZuo l1qqW55aXKJrqJdYXqxXXJmbnJOil5dasokRGMQpBYce7mA8tzz9EKMkB5OSKG/nrroYIb6k/ JTKjMTijPii0pzU4kOMMhwcShK8DiA5waLU9NSKtMwcYDzBpCU4eJREeMtB0rzFBYm5xZnpEK lTjLocB78/nMssxJKXn5cqJc57aidQkQBIUUZpHtwIWGxfYpSVEuZlZGBgEOIpSC3KzSxBlX/ FKM7BqCTMWw2yiiczrwRu0yugI5iAjvh8uRrkiJJEhJRUA+NkwTPrXgQ57wrUzKmMmzJBQOBl v56BEGNxwV5m8dQ5ySe+KDPcutLp/I99z9SyFKP5icbfutdt6+navnLNVf1lh3V+ysd2ec63i TN508woYHyg54rOsWkHuibape5nSZru7rJqd2Pu9m9nLpzYrXHlyJZN4n6J7JevdLCWLzg8bZ W2HMffrVxKLMUZiYZazEXFiQBfdrc16AIAAA== X-Env-Sender: stwiss.opensource@diasemi.com X-Msg-Ref: server-20.tower-262.messagelabs.com!1551809306!2441267!1 X-Originating-IP: [193.240.73.197] X-SYMC-ESS-Client-Auth: outbound-route-from=pass X-StarScan-Received: X-StarScan-Version: 9.31.5; banners=-,-,- X-VirusChecked: Checked Received: (qmail 30107 invoked from network); 5 Mar 2019 18:08:26 -0000 Received: from unknown (HELO sw-ex-cashub01.diasemi.com) (193.240.73.197) by server-20.tower-262.messagelabs.com with AES128-SHA256 encrypted SMTP; 5 Mar 2019 18:08:26 -0000 Received: from swsrvapps-01.diasemi.com (10.20.28.141) by SW-EX-CASHUB01.diasemi.com (10.20.16.140) with Microsoft SMTP Server id 14.3.408.0; Tue, 5 Mar 2019 18:08:25 +0000 Received: by swsrvapps-01.diasemi.com (Postfix, from userid 22547) id 27A933FB37; Tue, 5 Mar 2019 18:08:25 +0000 (GMT) Message-ID: From: Steve Twiss Date: Tue, 5 Mar 2019 17:59:57 +0000 Subject: [PATCH 00/13] Fix backtrace warnings from bad notifier chain calls To: Liam Girdwood , Mark Brown CC: Support Opensource , LKML , Cirrus Patches MIME-Version: 1.0 Content-Type: text/plain X-KSE-AttachmentFiltering-Interceptor-Info: protection disabled X-KSE-ServerInfo: sw-ex-cashub01.diasemi.com, 9 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 05/03/2019 17:23:00 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, This patch-set fixes a WARN_ON_ONCE() backtrace call caused by not locking the mutex from the function call regulator_notifier_call_chain(). It does this for thirteen regulator drivers by adding a mutex lock surrounding the notifier calls. This missing mutex lock has been around for a while, but the API I have used used here to fix it (i.e. regulator_lock()/regulator_unlock()) has only been in the kernel since v4.18. Therefore as this fix stands, the patches do not port back very far in kernel history. Regards, Steve Steve Twiss (13): regulator: da9055: Fix notifier mutex lock warning regulator: da9062: Fix notifier mutex lock warning regulator: da9063: Fix notifier mutex lock warning regulator: da9211: Fix notifier mutex lock warning regulator: lp8755: Fix notifier mutex lock warning regulator: ltc3589: Fix notifier mutex lock warning regulator: ltc3676: Fix notifier mutex lock warning regulator: pv88060: Fix notifier mutex lock warning regulator: pv88080: Fix notifier mutex lock warning regulator: pv88090: Fix notifier mutex lock warning regulator: wm831x: Fix notifier mutex lock warning regulator: wm831x isink: Fix notifier mutex lock warning regulator: wm831x ldo: Fix notifier mutex lock warning drivers/regulator/da9055-regulator.c | 2 ++ drivers/regulator/da9062-regulator.c | 2 ++ drivers/regulator/da9063-regulator.c | 5 ++++- drivers/regulator/da9211-regulator.c | 4 ++++ drivers/regulator/lp8755.c | 15 ++++++++++++--- drivers/regulator/ltc3589.c | 10 ++++++++-- drivers/regulator/ltc3676.c | 10 ++++++++-- drivers/regulator/pv88060-regulator.c | 4 ++++ drivers/regulator/pv88080-regulator.c | 4 ++++ drivers/regulator/pv88090-regulator.c | 4 ++++ drivers/regulator/wm831x-dcdc.c | 4 ++++ drivers/regulator/wm831x-isink.c | 2 ++ drivers/regulator/wm831x-ldo.c | 2 ++ 13 files changed, 60 insertions(+), 8 deletions(-) -- 1.9.3