Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <13835555f8ef44b21d1b7ddfe1c4203d0981f77e.1551824161.git.stefan@agner.ch>
 <7b70b64738db468ab3b830c503524058163b5c3f.1551824161.git.stefan@agner.ch>
In-Reply-To: <7b70b64738db468ab3b830c503524058163b5c3f.1551824161.git.stefan@agner.ch>
From:   Nick Desaulniers <ndesaulniers@google.com>
Date:   Tue, 5 Mar 2019 14:21:11 -0800
Message-ID: <CAKwvOd=1sEfg94kg6gbjCrrn3Wcp7BuwWKtGdD9pr_+P03eTMQ@mail.gmail.com>
Subject: Re: [PATCH 2/2] ARM: drop -mauto-it
To:     Stefan Agner <stefan@agner.ch>
Cc:     Russell King <linux@armlinux.org.uk>,
        Will Deacon <will.deacon@arm.com>,
        Nathan Chancellor <natechancellor@gmail.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        Nicolas Pitre <nicolas.pitre@linaro.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        julien.thierry@arm.com, Mark Rutland <mark.rutland@arm.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Mar 5, 2019 at 2:17 PM Stefan Agner <stefan@agner.ch> wrote:
>
> The assembler option -mauto-it is no longer a valid option. It has
> been removed from the documentation in July 2009, which is well
> before the release date of the currently supported binutils version
> 2.20.

Do you by chance have a link to the relevant commit?

>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
>  arch/arm/Makefile | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm/Makefile b/arch/arm/Makefile
> index 9561325c5201..ebf67bebe73d 100644
> --- a/arch/arm/Makefile
> +++ b/arch/arm/Makefile
> @@ -113,8 +113,7 @@ CFLAGS_ABI  +=-funwind-tables
>  endif
>
>  ifeq ($(CONFIG_THUMB2_KERNEL),y)
> -AFLAGS_AUTOIT  :=$(call as-option,-Wa$(comma)-mimplicit-it=always,-Wa$(comma)-mauto-it)
> -CFLAGS_ISA     :=-mthumb $(AFLAGS_AUTOIT)
> +CFLAGS_ISA     :=-mthumb -Wa$(comma)-mimplicit-it=always

Is $(comma) still needed? I thought it was only needed when a flag
that would contain commas would be in another set of parens (thus
making an ambiguity), like cc-ldoption or such?  Can you replace
`$(comma)` here with `,`?  I suspect it should work.

-- 
Thanks,
~Nick Desaulniers