Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   <Don.Brace@microchip.com>
To:     <erwanaliasr1@gmail.com>
CC:     <e.velu@criteo.com>, <don.brace@microsemi.com>,
        <jejb@linux.ibm.com>, <martin.petersen@oracle.com>,
        <esc.storagedev@microsemi.com>, <linux-scsi@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v3] scsi: smartpqi_init: Reporting 'logical unit failure'
Thread-Topic: [PATCH v3] scsi: smartpqi_init: Reporting 'logical unit failure'
Thread-Index: AQHU0EltMaljq66IB0CtKeYDDV02X6X9pUAw
Date:   Tue, 5 Mar 2019 22:30:04 +0000
Message-ID: <SN6PR11MB27675810361CE0D169CAF97CE1720@SN6PR11MB2767.namprd11.prod.outlook.com>
References: <1551455797.3334.6.camel@linux.ibm.com>
 <20190301160806.16099-1-e.velu@criteo.com>
In-Reply-To: <20190301160806.16099-1-e.velu@criteo.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: microchip.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 6c310059-1534-41ea-cb15-08d6a1ba1d14
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Mar 2019 22:30:04.1753
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3311
X-OriginatorOrg: microchip.com
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

-----Original Message-----
From: linux-scsi-owner@vger.kernel.org [mailto:linux-scsi-owner@vger.kernel=
.org] On Behalf Of Erwan Velu
Sent: Friday, March 1, 2019 10:08 AM
Cc: Erwan Velu <e.velu@criteo.com>; Don Brace <don.brace@microsemi.com>; Ja=
mes E.J. Bottomley <jejb@linux.ibm.com>; Martin K. Petersen <martin.peterse=
n@oracle.com>; open list:MICROSEMI SMART ARRAY SMARTPQI DRIVER (smartpqi) <=
esc.storagedev@microsemi.com>; open list:MICROSEMI SMART ARRAY SMARTPQI DRI=
VER (smartpqi) <linux-scsi@vger.kernel.org>; open list <linux-kernel@vger.k=
ernel.org>
Subject: [PATCH v3] scsi: smartpqi_init: Reporting 'logical unit failure'

When the HARDWARE_ERROR/0x3e/0x1 case is triggered, the logical volume is o=
fflined.
When reading the kernel log, the reason why the device got offlined isn't r=
eported to the user.
This situation makes difficult for admins to estimate the root cause of the=
 issue they analize.

Reading this part of the code makes clear this is because driver received a=
 HARDWARE_ERROR/0x3e/0x1 which is a 'logical unit failure'.
This patch is just about reporting the reason behind the offlining to ease =
the analyse.

Signed-off-by: Erwan Velu <e.velu@criteo.com>

Acked-by: Don Brace <don.brace@microsemi.com>

---
 drivers/scsi/smartpqi/smartpqi_init.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/=
smartpqi_init.c
index f564af8949e8..adebafe56b5b 100644
--- a/drivers/scsi/smartpqi/smartpqi_init.c
+++ b/drivers/scsi/smartpqi/smartpqi_init.c
@@ -2764,6 +2764,12 @@ static void pqi_process_raid_io_error(struct pqi_io_=
request *io_request)
 				sshdr.sense_key =3D=3D HARDWARE_ERROR &&
 				sshdr.asc =3D=3D 0x3e &&
 				sshdr.ascq =3D=3D 0x1) {
+			struct pqi_ctrl_info *ctrl_info =3D shost_to_hba(scmd->device->host);
+			struct pqi_scsi_dev *device =3D scmd->device->hostdata;
+
+			if (printk_ratelimit())
+				scmd_printk(KERN_ERR, scmd, "received 'logical unit failure' from cont=
roller for scsi %d:%d:%d:%d\n",
+					ctrl_info->scsi_host->host_no, device->bus, device->target, device->l=
un);
 			pqi_take_device_offline(scmd->device, "RAID");
 			host_byte =3D DID_NO_CONNECT;
 		}
--=20
2.20.1