Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <13835555f8ef44b21d1b7ddfe1c4203d0981f77e.1551824161.git.stefan@agner.ch>
 <cdf451c0-3947-9be1-3bee-2366577c4c5f@arm.com>
In-Reply-To: <cdf451c0-3947-9be1-3bee-2366577c4c5f@arm.com>
From:   Nick Desaulniers <ndesaulniers@google.com>
Date:   Tue, 5 Mar 2019 16:47:55 -0800
Message-ID: <CAKwvOdnb58nGXdweWTobGjqry7=9ZmfnMWnjTn8uHKt=Z5iabQ@mail.gmail.com>
Subject: Re: [PATCH 1/2] ARM: drop unnecessary WASM
To:     Robin Murphy <robin.murphy@arm.com>
Cc:     Stefan Agner <stefan@agner.ch>,
        Russell King <linux@armlinux.org.uk>,
        Nicolas Pitre <nicolas.pitre@linaro.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        Will Deacon <will.deacon@arm.com>, julien.thierry@arm.com,
        LKML <linux-kernel@vger.kernel.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        Nathan Chancellor <natechancellor@gmail.com>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Kristof Beyls <Kristof.Beyls@arm.com>,
        Peter Smith <Peter.Smith@arm.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Mar 5, 2019 at 3:39 PM Robin Murphy <robin.murphy@arm.com> wrote:
>
> Hi Stefan,
>
> On 2019-03-05 10:18 pm, Stefan Agner wrote:
> > The W macro for generating wide instructions when targeting Thumb-2
> > is not required for the preload data instructions (pld, pldw) since
> > they are only available as wide instructions. The GNU assembler seems
> > to work with or without the .w appended when compiling an Thumb-2
> > kernel. However, Clang's integrated assembler does not consider the
> > .w variants as valid instructions:
> >
> >    ./arch/arm/include/asm/processor.h:133:5: error: invalid instruction
> >                            "pldw.w\t%a0 \n"
> >                             ^
> >    <inline asm>:2:1: note: instantiated into assembly here
> >    pldw.w  [r0]
> >    ^
> >    1 error generated.
>
> Have you filed a bug against Clang for that? Something like "pldwal.w"

Yes; please.  For each deficiency you find, please file a bug.  We're
working on identifying what's missing from Clang's integrated
assembler support.  Given the list of issues, it's easier to estimate
how much effort is needed, which helps us allocate resources towards
fixing those issues better.

It would be good to know if pldw.w is valid under UAL or not.

Hopefully, the ARM kernel team can stress the importance of assembler
support for their ISA to their LLVM team.
-- 
Thanks,
~Nick Desaulniers