Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190219092148.4093-1-saumah@gmail.com>
In-Reply-To: <20190219092148.4093-1-saumah@gmail.com>
From:   Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Date:   Wed, 6 Mar 2019 05:19:11 +0000
Message-ID: <CADVatmMHV5oszv4Owz4CNJktoHViSWkzS=QVuyr6XQ8SGmF+zQ@mail.gmail.com>
Subject: Re: [PATCH V3] parport_serial.c change for fix hanging problem.
To:     saumah <saumah@gmail.com>
Cc:     Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>,
        Morris Ku <morris_ku@sunix.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Feb 19, 2019 at 9:23 AM saumah <saumah@gmail.com> wrote:
>
> parport_serial.c change for fix hanging problem while suspend machine. pa=
rport_seria.c support the same vendor id and device id definition as sunix =
multi-I/O card driver, when the sunix multi-io borad driver is installed,th=
ere are two drivers to support the same sunix multi-io card,it will cause o=
peration error.
>

Please use checkpatch to check your patch.

> Signed-off-by: saumah <saumah@gmail.com>

> ---
>  parport_serial.c | 180 +----------------------------------------------
>  1 file changed, 1 insertion(+), 179 deletions(-)
>
> diff --git a/parport_serial.c b/parport_serial.c
> index ae9e01e..f54d1d3 100644
> --- a/parport_serial.c
> +++ b/parport_serial.c

This doesnot apply. git is showing error:
error: parport_serial.c: No such file or directory

> @@ -38,29 +38,10 @@ enum parport_pc_pci_cards {
>         siig_2p1s_20x,
<snip>
>
>  /* each element directly indexed from enum list, above */
> @@ -127,29 +108,10 @@ static struct parport_pc_pci cards[] =3D {
>         /* siig_2p1s_20x */             { 2, { { 1, 2 }, { 3, 4 }, } },
>         /* siig_1s1p_20x */             { 1, { { 1, 2 }, } },
>         /* siig_2s1p_20x */             { 1, { { 2, 3 }, } },
> -       /* timedia_4078a */             { 1, { { 2, -1 }, } },

You are removing support for the parallel port of these boards. Can
you please point me to the driver with which it conflicts.

--=20
Regards
Sudip