Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190301184816.784-1-mans@mansr.com> <20190301184816.784-2-mans@mansr.com>
In-Reply-To: <20190301184816.784-2-mans@mansr.com>
From:   Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Date:   Wed, 6 Mar 2019 11:03:12 +0100
Message-ID: <CANiq72=1TDqUUsdHRM_=hL7pHj2RyWsabraAztYR5MTDcQ1BuQ@mail.gmail.com>
Subject: Re: [PATCH 2/3] auxdisplay: charlcd: simplify init message display
To:     Mans Rullgard <mans@mansr.com>
Cc:     linux-kernel <linux-kernel@vger.kernel.org>,
        Willy Tarreau <w@1wt.eu>,
        Geert Uytterhoeven <geert.uytterhoeven@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Mar 1, 2019 at 7:48 PM Mans Rullgard <mans@mansr.com> wrote:
>
>         /* display a short message */
> -#ifdef CONFIG_PANEL_CHANGE_MESSAGE
> -       charlcd_puts(lcd, "\x1b[Lc\x1b[Lb\x1b[L*" CONFIG_PANEL_BOOT_MESSAGE);
> -#else
> -       charlcd_puts(lcd, "\x1b[Lc\x1b[Lb\x1b[L*Linux-" UTS_RELEASE "\n");
> -#endif
> +       charlcd_puts(lcd, "\x1b[Lc\x1b[Lb\x1b[L*" LCD_INIT_TEXT);
> +

Nice simplification, thanks!

CC'ing Willy & Geert in case they want to take a look for charlcd.c

Cheers,
Miguel