Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261879AbUCRTmB (ORCPT ); Thu, 18 Mar 2004 14:42:01 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262897AbUCRTmB (ORCPT ); Thu, 18 Mar 2004 14:42:01 -0500 Received: from mail44-s.fg.online.no ([148.122.161.44]:32701 "EHLO mail44-s.fg.online.no") by vger.kernel.org with ESMTP id S261879AbUCRTl6 convert rfc822-to-8bit (ORCPT ); Thu, 18 Mar 2004 14:41:58 -0500 To: "David S. Miller" Cc: linux-kernel@vger.kernel.org Subject: Re: [BUG] alignment problem in net/core/flow.c:flow_key_compare References: <20040318103004.2cf4de34.davem@redhat.com> From: mru@kth.se (=?iso-8859-1?q?M=E5ns_Rullg=E5rd?=) Date: Thu, 18 Mar 2004 20:41:48 +0100 In-Reply-To: <20040318103004.2cf4de34.davem@redhat.com> (David S. Miller's message of "Thu, 18 Mar 2004 10:30:04 -0800") Message-ID: User-Agent: Gnus/5.1006 (Gnus v5.10.6) XEmacs/21.4 (Security Through Obscurity, linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 860 Lines: 26 "David S. Miller" writes: > On Thu, 18 Mar 2004 12:25:57 +0100 > mru@kth.se (M?ns Rullg?rd) wrote: > >> mru@kth.se (M?ns Rullg?rd) writes: >> >> > The solutions I see are either to force the alignment of struct flowi >> > to 64 bits, or to use 32-bit access in flow_key_compare. >> >> I forgot to mention that this is kernel 2.6.4. > > Yes, just add an alignment attribute of some kind to the struct > is probably the best idea. What's the proper way of doing that in kernel code? Should I use gcc __attribute__ directly or is there some macro that's preferred? -- M?ns Rullg?rd mru@kth.se - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/