Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From:   David Howells <dhowells@redhat.com>
In-Reply-To: <alpine.DEB.2.21.999.1903051616350.4505@trent.utfs.org>
References: <alpine.DEB.2.21.999.1903051616350.4505@trent.utfs.org>
To:     Christian Kujau <lists@nerdbynature.de>
Cc:     dhowells@redhat.com, linux-kernel@vger.kernel.org,
        Anna Schumaker <anna.schumaker@netapp.com>,
        Steve Dickson <steved@redhat.com>
Subject: Re: FS-Cache: Duplicate cookie detected
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <22095.1551878195.1@warthog.procyon.org.uk>
Date:   Wed, 06 Mar 2019 13:16:35 +0000
Message-ID: <22096.1551878195@warthog.procyon.org.uk>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Christian Kujau <lists@nerdbynature.de> wrote:

>  FS-Cache: Duplicate cookie detected
>  FS-Cache: O-cookie c=000000009da9dbf0 [p=000000001593f904 fl=222 nc=0 na=1]
>  FS-Cache: O-cookie d=00000000287febd9 n=00000000980c9e8a
>  FS-Cache: O-key=[8] '020001bdc0a80064'
>  FS-Cache: N-cookie c=00000000bfe3f869 [p=000000001593f904 fl=2 nc=0 na=1]
>  FS-Cache: N-cookie d=00000000287febd9 n=00000000e153f178
>  FS-Cache: N-key=[8] '020001bdc0a80064'

I've just spotted something that all these things have in common.  The old
cookie has FSCACHE_COOKIE_RELINQUISHING set in the flags (fl=222).  I don't
have a wait for this situation in fscache - which I should.

Interestingly, '020001bdc0a80064' looks like is could be the key from the
server level, assuming this is from NFS:

	0200 01bdc0a8 0064

could be:

	AF_INET (LE), 1.189.192.168, 100 (BE)

David