Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp4294046imb; Wed, 6 Mar 2019 09:48:43 -0800 (PST) X-Google-Smtp-Source: APXvYqz3uZyzwinGDKFAPd18omxPVIv4zYGAmdZKX5fUFYq8iiT0pSKX98lADDd/rU7MzF169l03 X-Received: by 2002:aa7:9099:: with SMTP id i25mr8474489pfa.102.1551894523416; Wed, 06 Mar 2019 09:48:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551894523; cv=none; d=google.com; s=arc-20160816; b=1KXavxCqFe+/1avWBOqG/+1O9b6K2EoRifGX02lXMMzV04qACTSeHC8Oc0SuJsAOO5 d5Hib1WsWPF4+t4dRQMlyP884X/XGfNot1PZzy+MiEcgE1wvRBbhn/4wFBnbPDK6Rb6O 5noJZgyAE5U0p7djztutRrvvkppJHhb0hgdiOuNCkHdcHLZEj5ODdyNtgP1ZQ03b2mP0 kpwl6EXNtpCD5cPw/mVdh3eQyD0ejjdXYs4HZn8T3LpbzDuyihOrXl5fqnsJXalf6AYD yPC2j4koZNCjEOBf41bcLKYlxy9BFNzfKl/AnCWMBdTJV5iTCIM68Ma6eOW9ExQ/qafF NIwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:message-id:in-reply-to:date:references:subject:cc:to :from; bh=q7sW1pvdSAhHIKO9YMfGIKX8+zVZDOemfHe34u2IsD8=; b=uydfgkTtws7bqGxiv5FbJc1sh8qn5zzAhVTXPFQ+VNMP5UTmTFTB3/v4L6JpKhddlP uUrjnRGgL+DjvzKYuHPryi+/5R9NadyuhlQ65OcpyUahABSGRHJk+T1WAK0TN3SboHTE /4HWko97ckjP4T8FjYiZsiCaAoKDZUyTMD3H4bYDaViDQ9TU0OWoLED9kq+/IrNS7Roj crLyn0Ncrki2TYxmkHfrIKykdTjwwRRtoIC19UeZ4A9Bu7+52+pkDdSvP8MBVFNm2TRZ CmZo0t5KHb7PCqyBHHFu4ugc5FvKRtt9l1bp3Esn4fCKNVFi885wqjE5cJLyki8LiVp+ aXxw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 40si1861974pla.307.2019.03.06.09.48.28; Wed, 06 Mar 2019 09:48:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727531AbfCFOtV convert rfc822-to-8bit (ORCPT + 99 others); Wed, 6 Mar 2019 09:49:21 -0500 Received: from unicorn.mansr.com ([81.2.72.234]:59198 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726934AbfCFOtU (ORCPT ); Wed, 6 Mar 2019 09:49:20 -0500 Received: by unicorn.mansr.com (Postfix, from userid 51770) id 4865814CEA; Wed, 6 Mar 2019 14:49:19 +0000 (GMT) From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Miguel Ojeda Cc: linux-kernel , Willy Tarreau , Geert Uytterhoeven Subject: Re: [PATCH 3/3] auxdisplay: charlcd: make backlight initial state configurable References: <20190301184816.784-1-mans@mansr.com> <20190301184816.784-3-mans@mansr.com> Date: Wed, 06 Mar 2019 14:49:19 +0000 In-Reply-To: (Miguel Ojeda's message of "Wed, 6 Mar 2019 10:56:21 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Miguel Ojeda writes: > On Fri, Mar 1, 2019 at 7:48 PM Mans Rullgard wrote: >> >> +#ifdef CONFIG_CHARLCD_BL_ON >> +#define LCD_INIT_BL "\x1b[L+" >> +#elif defined (CONFIG_CHARLCD_BL_FLASH) > > Style nitpick: no space after "elif defined". Do you mind if I change > it before sending it to linux-next? Otherwise, looks fine to me. > Thanks! Of course I don't mind. -- M?ns Rullg?rd