Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 6 Mar 2019 18:03:46 +0100
From:   Jiri Bohac <jbohac@suse.cz>
To:     Kairui Song <kasong@redhat.com>
Cc:     linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        Alexey Dobriyan <adobriyan@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Omar Sandoval <osandov@fb.com>, Baoquan He <bhe@redhat.com>,
        Dave Young <dyoung@redhat.com>
Subject: Re: [PATCH v4] x86/gart/kcore: Exclude GART aperture from kcore
Message-ID: <20190306170346.zs6orsyu327c6m2p@dwarf.suse.cz>
References: <20190306113859.19263-1-kasong@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190306113859.19263-1-kasong@redhat.com>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On Wed, Mar 06, 2019 at 07:38:59PM +0800, Kairui Song wrote:
> +int register_mem_pfn_is_ram(int (*fn)(unsigned long pfn))
> +{
> +	if (mem_pfn_is_ram)
> +		return -EBUSY;
> +	mem_pfn_is_ram = fn;
> +	return 0;
> +}
> +
> +void unregister_mem_pfn_is_ram(void)
> +{
> +	mem_pfn_is_ram = NULL;
> +}
> +
> +static int pfn_is_ram(unsigned long pfn)
> +{
> +	if (mem_pfn_is_ram)
> +		return mem_pfn_is_ram(pfn);
> +	else
> +		return 1;
> +}
> +

If anyone were ever to use unregister_mem_pfn_is_ram(),
pfn_is_ram() would become racy.

In V2 you had this:
	+       fn = mem_pfn_is_ram;
	+       if (fn)
	+               ret = fn(pfn);

I agree it's unnecessary since nothing uses
unregister_mem_pfn_is_ram(). But then I think it would be best to
just drop the unregister function.

Otherwise the patch looks good to me.

-- 
Jiri Bohac <jbohac@suse.cz>
SUSE Labs, Prague, Czechia