Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH V7 3/3] firmware: imx: imx-scu: register build-in child
 devices
To:     Anson Huang <anson.huang@nxp.com>,
        "catalin.marinas@arm.com" <catalin.marinas@arm.com>,
        "will.deacon@arm.com" <will.deacon@arm.com>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        "wim@linux-watchdog.org" <wim@linux-watchdog.org>,
        Andy Gross <andy.gross@linaro.org>,
        "heiko@sntech.de" <heiko@sntech.de>,
        "horms+renesas@verge.net.au" <horms+renesas@verge.net.au>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "maxime.ripard@bootlin.com" <maxime.ripard@bootlin.com>,
        "jagan@amarulasolutions.com" <jagan@amarulasolutions.com>,
        "bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
        "enric.balletbo@collabora.com" <enric.balletbo@collabora.com>,
        "marc.w.gonzalez@free.fr" <marc.w.gonzalez@free.fr>,
        "olof@lixom.net" <olof@lixom.net>,
        Aisheng Dong <aisheng.dong@nxp.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>
Cc:     dl-linux-imx <linux-imx@nxp.com>
References: <1551834095-19950-1-git-send-email-Anson.Huang@nxp.com>
 <1551834095-19950-3-git-send-email-Anson.Huang@nxp.com>
From:   Guenter Roeck <linux@roeck-us.net>
Message-ID: <90ff94d9-6f15-5353-c5a1-f2ec5ee744ad@roeck-us.net>
Date:   Wed, 6 Mar 2019 08:05:33 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.1
MIME-Version: 1.0
In-Reply-To: <1551834095-19950-3-git-send-email-Anson.Huang@nxp.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On 3/5/19 5:06 PM, Anson Huang wrote:
> For some devices which are controlled by system controller,
> they are NOT present in device tree since no hardware info
> needed, just register these devices as children of SCU device.
> This patch registers i.MX system controller watchdog platform
> device as child device of SCU.
> 
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> No changes.
> ---
>   drivers/firmware/imx/imx-scu.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/firmware/imx/imx-scu.c b/drivers/firmware/imx/imx-scu.c
> index 2bb1a19..df75ead 100644
> --- a/drivers/firmware/imx/imx-scu.c
> +++ b/drivers/firmware/imx/imx-scu.c
> @@ -196,6 +196,7 @@ EXPORT_SYMBOL(imx_scu_call_rpc);
>   
>   static int imx_scu_probe(struct platform_device *pdev)
>   {
> +	struct platform_device *child_pdev;
>   	struct device *dev = &pdev->dev;
>   	struct imx_sc_ipc *sc_ipc;
>   	struct imx_sc_chan *sc_chan;
> @@ -248,6 +249,13 @@ static int imx_scu_probe(struct platform_device *pdev)
>   
>   	dev_info(dev, "NXP i.MX SCU Initialized\n");
>   
> +	/* register SCU child devices which are NOT in device tree */
> +	child_pdev = platform_device_register_data(dev, "imx-sc-wdt",
> +				PLATFORM_DEVID_NONE, NULL, 0);
> +	if (IS_ERR(child_pdev))
> +		dev_warn(dev, "failed to register scu watchdog device %ld!\n",
> +			 PTR_ERR(child_pdev));
> +

I just realized ... since this is not a devm_ function, we now also need
error handling (if devm_of_platform_populate() fails) and a remove function.
Sorry for that - I should have noticed earlier.

Guenter

>   	return devm_of_platform_populate(dev);
>   }
>   
>