Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <CADYN=9KkjPSP4KJ+AzG=Njq49zJ5fbWNZ4V_jOvHkq_kt0biyA@mail.gmail.com>
 <20190304153714.GD13452@kadam>
In-Reply-To: <20190304153714.GD13452@kadam>
From:   Anders Roxell <anders.roxell@linaro.org>
Date:   Wed, 6 Mar 2019 18:28:33 +0100
Message-ID: <CADYN=9+9UrN9R=M5ode43ZkebaDrm8a9m5t1eyAmR+wNhWypMA@mail.gmail.com>
Subject: Re: BUG: KASAN: i2c dev use after free
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     erico.nunes@datacom.ind.br, wsa@the-dreams.de,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 4 Mar 2019 at 16:37, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> I wasn't trying to fix anything so complicated as this, it was a
> more obvious use after free.  It does feel intuitively that we should
> call device_destroy() before the cdev_del() so that it's in the reverse
> order from how it was allocated but I don't see any reason to think
> that will make a difference.

No that didn't make any difference... =/

>
> ---
>  drivers/i2c/i2c-dev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c
> index 3f7b9af11137..7e85e2cf26c1 100644
> --- a/drivers/i2c/i2c-dev.c
> +++ b/drivers/i2c/i2c-dev.c
> @@ -687,9 +687,9 @@ static int i2cdev_detach_adapter(struct device *dev, void *dummy)
>         if (!i2c_dev) /* attach_adapter must have failed */
>                 return 0;
>
> +       device_destroy(i2c_dev_class, MKDEV(I2C_MAJOR, adap->nr));
>         cdev_del(&i2c_dev->cdev);
>         put_i2c_dev(i2c_dev);
> -       device_destroy(i2c_dev_class, MKDEV(I2C_MAJOR, adap->nr));
>
>         pr_debug("i2c-dev: adapter [%s] unregistered\n", adap->name);
>         return 0;
> --
> 2.17.1
>