Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 6 Mar 2019 21:02:47 +0100 (CET)
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Louis Taylor <louis@kragniz.eu>
cc:     mingo@redhat.com, bp@alien8.de, hpa@zytor.com, x86@kernel.org,
        fanc.fnst@cn.fujitsu.com, bhe@redhat.com,
        kirill.shutemov@linux.intel.com, linux-kernel@vger.kernel.org,
        clang-built-linux@googlegroups.com, ndesaulniers@google.com,
        jflat@chromium.org
Subject: Re: [PATCH] x86/KASLR: always return a value from
 process_mem_region
In-Reply-To: <20190302184929.28971-1-louis@kragniz.eu>
Message-ID: <alpine.DEB.2.21.1903062059570.1646@nanos.tec.linutronix.de>
References: <20190302184929.28971-1-louis@kragniz.eu>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Louis,

On Sat, 2 Mar 2019, Louis Taylor wrote:

> When compiling with -Wreturn-type, clang warns:
> 
> arch/x86/boot/compressed/kaslr.c:704:1: warning: control may reach end of
>       non-void function [-Wreturn-type]
> 
> This function's return statement should probably have been placed
> outside the #endif, so move it there
> 
> Link: https://github.com/ClangBuiltLinux/linux/issues/360
> Signed-off-by: Louis Taylor <louis@kragniz.eu>

This lacks a

Fixes: commitsha1 (".....")

tag

>  arch/x86/boot/compressed/kaslr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/boot/compressed/kaslr.c b/arch/x86/boot/compressed/kaslr.c
> index fa0332dda9f2..2e53c056ba20 100644
> --- a/arch/x86/boot/compressed/kaslr.c
> +++ b/arch/x86/boot/compressed/kaslr.c
> @@ -697,8 +697,8 @@ static bool process_mem_region(struct mem_vector *region,
>  			return 1;
>  		}
>  	}
> -	return 0;
>  #endif
> +	return 0;
>  }

This does not longer apply to mainline because the function does not longer
have a return value. So if that's important, you need to hash that out with
the stable folks.

Thanks,

	tglx