Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 6 Mar 2019 21:11:06 +0100 (CET)
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Matthew Whitehead <tedheadster@gmail.com>
cc:     linux-kernel@vger.kernel.org, mingo@kernel.org, luto@kernel.org
Subject: Re: [PATCH] x86/CPU: Use correct macros for Cyrix calls on Geode
 processors
In-Reply-To: <1551902228-21319-1-git-send-email-tedheadster@gmail.com>
Message-ID: <alpine.DEB.2.21.1903062109200.1646@nanos.tec.linutronix.de>
References: <1551902228-21319-1-git-send-email-tedheadster@gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Matthew,

On Wed, 6 Mar 2019, Matthew Whitehead wrote:

> There are comments in processor-cyrix.h advising you to _not_ make calls
> using the deprecated macros in this style:
> 
>   setCx86_old(CX86_CCR4, getCx86_old(CX86_CCR4) | 0x80);
> 
> This is because it expands the macro into a non-functioning calling
> sequence. The calling order must be:
> 
>   outb(CX86_CCR2, 0x22);
>   inb(0x23);
> 
> >From the comments:
> 
>  * When using the old macros a line like
>  *   setCx86(CX86_CCR2, getCx86(CX86_CCR2) | 0x88);
>  * gets expanded to:
>  *  do {
>  *    outb((CX86_CCR2), 0x22);
>  *    outb((({
>  *        outb((CX86_CCR2), 0x22);
>  *        inb(0x23);
>  *    }) | 0x88), 0x23);
>  *  } while (0);
> 
> The new macros fix this problem, so use them instead. Tested on an
> actual Geode processor.

Thanks for cleaning that up, but now the old macros are unused, so please
remove them entirely including the comment.

Thanks,

	tglx