Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp4433623imb; Wed, 6 Mar 2019 13:19:05 -0800 (PST) X-Google-Smtp-Source: APXvYqy2+e7cwALg6zQJHMtNQdaQYBLBgZs5OSdsL0vEcW0YXu8bCVGbi3wPEPtbGUmJgDfvwTFm X-Received: by 2002:a63:6e8d:: with SMTP id j135mr8117917pgc.160.1551907145090; Wed, 06 Mar 2019 13:19:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551907145; cv=none; d=google.com; s=arc-20160816; b=DQ9JIEx3B6xRPrNMTo+KnubpP0rzSCjT3RGUcQ5bYb76MA5V1l1XHRszc01MyikVrj is+3rU2XMpxR3TcSEjKJ/MWliOwVLqaByi24GW6Ck/ESD/B3vI0tcMlaMlFSOT/rsaqa CS9SX+jbCjkLUo/tbs97UOnU9qmiPvJzEVlkqDikLMf1j5cgN4b8D/CcBXVNrntO+lVJ u/Y3NvrVSx9JzAkFqTBHrmktO1DpAt3yXnrfUJaISMwWInpwQTxYzB/Az64d+bLOHZxc FnEjpmNV4jU0UHH18J2nHLD+j67+X4DqWpYOhOegbi0NR+z4+FNu7aKdVEK6figfSt+m 5M9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=vkbFsO7UtONNBfXfGJYdtz5hJ8wK93PPF7z+no1SJu0=; b=OzoM8GkJolO9OESFsZBVqsIDnbTzdaavUWr/RW1a1hI4Cv7nyCF/br+rI+UawzEyS8 ooHWsD4MrzhqCKOpgh4el4MzfLAC/ngs/Kz5pN15d+Vqt3lZXqlijkWivoipGyMrkH13 +k/c5bHhNDdVcl5co/WGexX0FPAw1HkbMxi1bkOXdj0Rz1p8qYQE6LYMBmpWocKD8zDD BmQ3jhcR05twY4ht5cn1npGeBuuB6kwAHxUX+cM9aUkcWmz8+LlSLekoaltlTEXuMxGc oHfv8KJd8Mg9gMvR28uMmiQWAnoIa6yEksHHzZio6n6XqD2IrkcrEMgXySjj2uNhoPXZ jcBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=tfQXCzeU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l189si2214269pgd.246.2019.03.06.13.18.49; Wed, 06 Mar 2019 13:19:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=tfQXCzeU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726530AbfCFVSZ (ORCPT + 99 others); Wed, 6 Mar 2019 16:18:25 -0500 Received: from mail-pg1-f196.google.com ([209.85.215.196]:40910 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725601AbfCFVSY (ORCPT ); Wed, 6 Mar 2019 16:18:24 -0500 Received: by mail-pg1-f196.google.com with SMTP id u9so9406675pgo.7; Wed, 06 Mar 2019 13:18:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=vkbFsO7UtONNBfXfGJYdtz5hJ8wK93PPF7z+no1SJu0=; b=tfQXCzeUChjqpp+aWsWwI0JwPHvv/xhV/TVpYVW++NDiCgeFjYNiyTiPsE+lHgJ7k7 X9H+QhLLbQC7UVdxo6CNoOhLJPnsf6Gb8lwhuuv9eqrR99l4bu2V1AZNkPIpz+7Ze3xN 68eAWs1YxDpYHxObiW/R8EVYAJSOTlAXWiAb3oRKiVbAngTRFS9pjFQ+K2e24givNt2s oV4USXidvuuSY8pvVSJeVfAXGuYDS0lgeEbicO2inn7xI+qxvNZ6AtTwx6GNQxOCU544 by1NorgbEmvSa6yJ/Kz/plZqiAhO55GgN1Bt8fHkmCP95Ke1ZPkT/8645EEEgHWR6J8m ac2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=vkbFsO7UtONNBfXfGJYdtz5hJ8wK93PPF7z+no1SJu0=; b=GRvEKJ/FY+65xeLxw2PVxrasKjdiPTaGYOp2hkDuxBOW679gj7BqyTsCJgr0xAxlGK LJDdOliByyikVLye7NPt91zOeVnJVy5iumenZjxpAYEEwIuv18KUc4pC19NryI8EXDr9 CvH+JlHbFknNajRKWl2ZwPiTMN8/KPXAheHUoXBMj79unppGuhYfMiHdiWugf6VZH62a w6fP2ix/oINyTQdu3MXZz2O0nVqOprBNHzXGet2TH8rDaryYimGMPWkzfe9a3jBJk+g7 eVa+HnG8NDJcT9jH77GLq8IETXV3IXK1uG83uWvZO4rPIL7xqzQhdpcZwO2SmJm7GzKW MiJQ== X-Gm-Message-State: APjAAAXaCeIvp3PfmFS+yhbXxcUkN8PrZQGH9LyuWq3BvScnBdM3uMvk QcAJvUblWP9amuR8/YbFs0M1qBfACME= X-Received: by 2002:a63:b447:: with SMTP id n7mr8134613pgu.401.1551907103530; Wed, 06 Mar 2019 13:18:23 -0800 (PST) Received: from myunghoj-Precision-5530 ([118.220.181.225]) by smtp.gmail.com with ESMTPSA id u8sm3270221pgp.48.2019.03.06.13.18.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 06 Mar 2019 13:18:22 -0800 (PST) Date: Thu, 7 Mar 2019 06:15:38 +0900 From: Myungho Jung To: Steffen Klassert Cc: "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] xfrm: Reset secpath in xfrm failure Message-ID: <20190306211536.GA27609@myunghoj-Precision-5530> References: <20190306073304.GA22426@myunghoj-Precision-5530> <20190306113543.GD3758@gauss3.secunet.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190306113543.GD3758@gauss3.secunet.de> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 06, 2019 at 12:35:43PM +0100, Steffen Klassert wrote: > On Wed, Mar 06, 2019 at 04:33:08PM +0900, Myungho Jung wrote: > > In esp4_gro_receive() and esp6_gro_receive(), secpath can be allocated > > without adding xfrm state to xvec. Then, sp->xvec[sp->len - 1] would > > fail and result in dereferencing invalid pointer in esp4_gso_segment() > > and esp6_gso_segment(). Reset secpath if xfrm function returns error. > > > > Reported-by: syzbot+b69368fd933c6c592f4c@syzkaller.appspotmail.com > > Signed-off-by: Myungho Jung > > The patch itself looks ok, but please add a 'Fixes' tag to > the commit message. > > Thanks! Hi Steffen, Thanks for reviewing the change. I'll add fixes tag and resubmit it. Thanks, Myungho