Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20190304171450.GB10971@codeaurora.org>
References: <20190221121827.32427-1-rplsssn@codeaurora.org> <20190221121827.32427-3-rplsssn@codeaurora.org> <155122856693.260864.16771523196413005158@swboyd.mtv.corp.google.com> <20190227222913.GA10971@codeaurora.org> <155146312862.16805.13188707704058408931@swboyd.mtv.corp.google.com> <20190304171450.GB10971@codeaurora.org>
From:   Stephen Boyd <swboyd@chromium.org>
Subject: Re: [PATCH RESEND v3 2/3] drivers: qcom: rpmh-rsc: return if the controller is idle
Cc:     "Raju P.L.S.S.S.N" <rplsssn@codeaurora.org>, andy.gross@linaro.org,
        david.brown@linaro.org, linux-arm-msm@vger.kernel.org,
        linux-soc@vger.kernel.org, rnayak@codeaurora.org,
        bjorn.andersson@linaro.org, linux-kernel@vger.kernel.org,
        linux-pm@vger.kernel.org, evgreen@chromium.org,
        dianders@chromium.org, mka@chromium.org
To:     Lina Iyer <ilina@codeaurora.org>
Message-ID: <155191036168.20095.16985811185745151630@swboyd.mtv.corp.google.com>
User-Agent: alot/0.8
Date:   Wed, 06 Mar 2019 14:12:41 -0800
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Lina Iyer (2019-03-04 09:14:50)
> On Fri, Mar 01 2019 at 10:58 -0700, Stephen Boyd wrote:
> >Quoting Lina Iyer (2019-02-27 14:29:13)
> >> Hi Stephen,
> >>
> >> On Tue, Feb 26 2019 at 17:49 -0700, Stephen Boyd wrote:
> >
> >Ok, can you explain why it's even a problem for the TCSes to be active
> >during suspend? I would hope that for suspend/resume, if this is
> >actually a problem, the RPMh driver itself can block suspend with a
> >driver suspend callback that checks for idleness.
> The RSC can transmit TCS executed from Linux and when all the CPUs have
> powered down, could execute a firmware in the RSC to deliver the sleep
> state requests. The firmware cannot run when there are active requests
> being processed. To ensure that case, we bail out of sleep or suspend,
> when the last CPU is powering down, if there are active requests.

Ok, do we actually bail out or just pick a shallower idle state that
wouldn't trigger the firmware to run something that may conflict with
the active requests (i.e. some light CPU sleep mode)? The commit text
seems to imply we block certain idle states.

>=20
> >But I suspect that in
> >the system wide suspend/resume case, any callers that could make TCS
> >requests are child devices of the RPMh controller and therefore they
> >would already be suspended if they didn't have anything pending they're
> >waiting for a response on or they would be blocking suspend themselves
> >if they're waiting for the response. So why are we even checking the
> >TCSes in system suspend path at all? Assume that callers know what
> >they're doing and will block suspend if they care?
> >
> In suspend, they probably would do what you mention above. All CPUs
> might conincidentally be idle at the same idle, when a request is being
> processed.
>=20
> >Following that same logic, is this more of an API that is planned for
> >use by CPU idle? Where the case is much more of a runtime PM design.
> >Even then, I don't get it. A device that's runtime active and making
> >RPMh requests might need to block some forms of CPU idle states because
> >a request hasn't been processed yet that may change the decision for
> >certain deep idle states?
> >
> A process waiting on a RPMH request, may let the CPU go to sleep and
> therefore this is a possibility.
>=20

Ok thanks for the info. Can these details be included in the commit text
so we don't lose sight of the bigger picture? And can this patch series
be combined with a larger cpuidle/suspend patch series so we don't have
to review this in isolation? I don't understand the need to add more
APIs that aren't used yet.