Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v12 3/4] pstore/blk: support pmsg for pstore block
To:     Randy Dunlap <rdunlap@infradead.org>,
        Kees Cook <keescook@chromium.org>,
        Anton Vorontsov <anton@enomsg.org>,
        Colin Cross <ccross@android.com>,
        Tony Luck <tony.luck@intel.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        Arnd Bergmann <arnd@arndb.de>, Rob Herring <robh@kernel.org>
Cc:     linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1551337948-16451-1-git-send-email-liaoweixiong@allwinnertech.com>
 <1551337948-16451-4-git-send-email-liaoweixiong@allwinnertech.com>
 <a7ae72c0-2425-a43a-da53-22f30a173f7e@infradead.org>
From:   liaoweixiong <liaoweixiong@allwinnertech.com>
Message-ID: <e88aed98-a96b-6e78-9183-5ff50dfa64e7@allwinnertech.com>
Date:   Thu, 7 Mar 2019 09:05:32 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <a7ae72c0-2425-a43a-da53-22f30a173f7e@infradead.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On 2019-03-06 09:16, Randy Dunlap wrote:
> Hi,
> 
> On 2/27/19 11:12 PM, liaoweixiong wrote:
>> diff --git a/fs/pstore/Kconfig b/fs/pstore/Kconfig
>> index 7dfe00b..b417bf5 100644
>> --- a/fs/pstore/Kconfig
>> +++ b/fs/pstore/Kconfig
>> @@ -210,6 +210,27 @@ config PSTORE_BLKOOPS_DMESG_SIZE
>>  	     It is the first priority. Take care of that blkoops will take lower
>>  	     priority settings if higher priority one do not set.
>>  
>> +config PSTORE_BLKOOPS_PMSG_SIZE
>> +	int "pmsg size in kbytes for blkoops"
>> +	depends on PSTORE_BLKOOPS
>> +	default 64
>> +	help
>> +	  This just sets size of pmsg (pmsg_size) for pstore/blk. The value must
>> +	  be a multiple of 4096. Pmsg work only if "blkdev" is set.
> 
> 	                              works
> 

Fixed.

>> +
>> +	  NOTE that, there are three ways to set parameters of blkoops and
>> +	  prioritize according to configuration flexibility. That is
>> +	  Kconfig < device tree < module parameters. It means that the value can
>> +	  be overwritten by higher priority settings.
>> +	  1. Kconfig
>> +	     It	just sets a default value.
>> +	  2. device tree
>> +	     It is set on device tree, which will overwrites value from Kconfig,
> 
> 	                                          overwrite the value from Kconfig,
> 

Fixed.

>> +	     but can also be overwritten by module parameters.
>> +	  3. module parameters
>> +	     It is the first priority. Take care of that blkoops will take lower
>> +	     priority settings if higher priority one do not set.
>> +
>>  config PSTORE_BLKOOPS_TOTAL_SIZE
>>  	int "total size in kbytes for blkoops"
>>  	depends on PSTORE_BLKOOPS
> 
> cheers.
> 

Thank you. Cheers.

-- 
liaoweixiong