Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] mfd: hi655x-pmic: Fix missing return value check for
 devm_regmap_init_mmio_clk
To:     Axel Lin <axel.lin@ingics.com>, Lee Jones <lee.jones@linaro.org>
References: <20190306134949.31883-1-axel.lin@ingics.com>
CC:     <linux-kernel@vger.kernel.org>
From:   Chen Feng <puck.chen@hisilicon.com>
Message-ID: <5C80776F.4070806@hisilicon.com>
Date:   Thu, 7 Mar 2019 09:44:15 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <20190306134949.31883-1-axel.lin@ingics.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Thanks

On 2019/3/6 21:49, Axel Lin wrote:
> Since devm_regmap_init_mmio_clk can fail, add return value checking.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>  drivers/mfd/hi655x-pmic.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c
> index 96c07fa1802a..6693f74aa6ab 100644
> --- a/drivers/mfd/hi655x-pmic.c
> +++ b/drivers/mfd/hi655x-pmic.c
> @@ -112,6 +112,8 @@ static int hi655x_pmic_probe(struct platform_device *pdev)
>  
>  	pmic->regmap = devm_regmap_init_mmio_clk(dev, NULL, base,
>  						 &hi655x_regmap_config);
> +	if (IS_ERR(pmic->regmap))
> +		return PTR_ERR(pmic->regmap);
>  
>  	regmap_read(pmic->regmap, HI655X_BUS_ADDR(HI655X_VER_REG), &pmic->ver);
>  	if ((pmic->ver < PMU_VER_START) || (pmic->ver > PMU_VER_END)) {
> 

-- 
Cheers,
- Feng