Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp4856866imb; Thu, 7 Mar 2019 02:05:59 -0800 (PST) X-Google-Smtp-Source: APXvYqxa6zOFhxeYX4+gS3C61/JjJ1OfOC6C9DNgVyEagrNsycJxaxW4fj2o2dcs/I6lSI31+3aL X-Received: by 2002:a62:53c7:: with SMTP id h190mr12284013pfb.204.1551953159615; Thu, 07 Mar 2019 02:05:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551953159; cv=none; d=google.com; s=arc-20160816; b=cD49sB703QkfhPbfk+o+zAUvaU5V3ClXzUOh/64q/iPzR7I+3hSmXPJM32JiWTxvys qC5C4quwcgY46JfjTnuli/camJfe9RGB8nFHRcBWpoH2h0pDPDhZ48VC9LUcRrNobrfY cS3OF+cmap0J/VNSRMNrFw/d7mS8mEPWeLu9SUAwV5QNudQR9UZ5cQe31ATcCzhBBtrf WQ8SPpsH3XMS4uYXU5A+06M+OVzczMQjUy/J4mQrGTCH5o7Fz1hrVC3b2u9YHmLBcHzD lzrDwslVhZP11rifa+J1jeUrSegCtCLBe7eKGutDSl+zt3784qvbe/s1I9FItU0vC7qE ddtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=shOxVrYNsSRwkeCTyxlov6jj48uK4FbeN9KdUfLhYTc=; b=CbgoksNE/ydnZwzkL0l8rvuvXAe05pgqW0MLvQdFEGR2UgXIhAUQyyZdRvgPmhcXNI jtSi0Fff/Wskr7Ys68ySf+3/4E7GCRsx5BwKXlGR7IL4z802HOOQrXA8v06VnGhvKkbp sAkfSXwNo7d43zN7V9/3L3eDhOaCCx/yxzqtJCNUw9m8zCWSfc2Nac+e0Qw37xPF8ZJT wCMqzNfTYHoyo9/sZNmT0YOh7MM3e7VPNClyTOENqZjCLk0PU+DSqBgkmCj0bfpMyj3u EAMSDvjkrEAFJKUBhpDmH4qhRKZDWOricUOWHN3cut6d9qdRvc8DtPgPbULv6TLU5V2G fDlg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 70si4065856ple.294.2019.03.07.02.05.44; Thu, 07 Mar 2019 02:05:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726283AbfCGKFW (ORCPT + 99 others); Thu, 7 Mar 2019 05:05:22 -0500 Received: from www62.your-server.de ([213.133.104.62]:44310 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725795AbfCGKFW (ORCPT ); Thu, 7 Mar 2019 05:05:22 -0500 Received: from [78.46.172.3] (helo=sslproxy06.your-server.de) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1h1ptt-0000as-2O; Thu, 07 Mar 2019 11:05:17 +0100 Received: from [178.197.249.29] (helo=linux.home) by sslproxy06.your-server.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1h1pts-000XQl-PC; Thu, 07 Mar 2019 11:05:16 +0100 Subject: Re: [PATCH] bpf: fix sysctl.c warning To: Arnd Bergmann , Luis Chamberlain , Kees Cook , Alexei Starovoitov Cc: Martin KaFai Lau , Song Liu , Yonghong Song , Andrew Morton , Christian Brauner , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org References: <20190304203443.1992942-1-arnd@arndb.de> From: Daniel Borkmann Message-ID: <1d79d4ec-99c7-1764-af8f-ea436a657eb0@iogearbox.net> Date: Thu, 7 Mar 2019 11:05:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20190304203443.1992942-1-arnd@arndb.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.100.2/25380/Wed Mar 6 10:23:41 2019) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/04/2019 09:34 PM, Arnd Bergmann wrote: > When CONFIG_BPF_SYSCALL or CONFIG_SYSCTL is disabled, we get > a warning about an unused function: > > kernel/sysctl.c:3331:12: error: 'proc_dointvec_minmax_bpf_stats' defined but not used [-Werror=unused-function] > static int proc_dointvec_minmax_bpf_stats(struct ctl_table *table, int write, > > The CONFIG_BPF_SYSCALL check was already handled, but the SYSCTL check > is needed on top. > > Fixes: 492ecee892c2 ("bpf: enable program stats") > Signed-off-by: Arnd Bergmann Applied, thanks!