Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp4986318imb; Thu, 7 Mar 2019 05:22:02 -0800 (PST) X-Google-Smtp-Source: APXvYqyI0X7DRtfhMmBMDaEs0YvBpt/DdGER20o46e0OBiomIQuPcqBi4KeL3gb/GZbIwMShaHtA X-Received: by 2002:a63:fc62:: with SMTP id r34mr11445122pgk.154.1551964922061; Thu, 07 Mar 2019 05:22:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551964922; cv=none; d=google.com; s=arc-20160816; b=yceld+b0IQvg7IYJldlxHZgEGtbh8TqZnNGZnJ5ADS65USIhYfpqExcidlGdCd4qgo QbZ3QfW5KF75wUDuwW9nlPCytH98WpixWfkWPyJvLszyoMVA4mHuH+RGQhTc1FITdSn3 7kisfQQbHUd5clSBjOsc78ILCHW72xe0dpW9hpLqOuumSYE3ttWanC3lA4pE4/wTXfG4 rrBHi98AyOhWxphdRefvW+dBeZuaUvX/g35B4spNBNiwGVBZAhobwt9vdqxeEOLsJaKL mdSEajYVYlg3Bhq5FHeJ5IdJjmVAdjTLdDe126bTPWBA5jd9hh7YVQ6P3KBIAv49V0st mtBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=lVTZ4imBtKZC+hfTYze7WWtrbKrEBxNSoCcd375OhOc=; b=hw0vVFQNeB0Sn/xejhK4KwxrJerT8r1f2bjuArqXQIJ8Eu8AhkNQQRCfLywOtaPHau YO9RtPucoA/7indVN0QugkE+PewSdRwjWe8Ms4irdroOHgic5F5nh7vSOAezft6+Hb4s YocyCny0HTXqmpKbi69J3gw+9gWPtnWtXkMGJT1Zgw1oJoE2Z4v3TsIabH3VBxo9dfYR 7DJsYvChHdqfej4mtw5rgY+trHrlZpFfd7/RkWk2kXqsrWo8dxtq5C0GgF8PX+hSUQC6 6gZheXMbOh5gTUej9mTqvsU9/rx/t6UO+hi35g2uwAsvo7WmfNnF0byMBCKnOtr6LVVd edOw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c23si3896683pgk.54.2019.03.07.05.21.46; Thu, 07 Mar 2019 05:22:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726346AbfCGNUa (ORCPT + 99 others); Thu, 7 Mar 2019 08:20:30 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:36415 "EHLO relay9-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726298AbfCGNUa (ORCPT ); Thu, 7 Mar 2019 08:20:30 -0500 X-Originating-IP: 79.86.19.127 Received: from alex.numericable.fr (127.19.86.79.rev.sfr.net [79.86.19.127]) (Authenticated sender: alex@ghiti.fr) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 48D78FF807; Thu, 7 Mar 2019 13:20:17 +0000 (UTC) From: Alexandre Ghiti To: Andrew Morton , Vlastimil Babka , Catalin Marinas , Will Deacon , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Martin Schwidefsky , Heiko Carstens , Yoshinori Sato , Rich Felker , "David S . Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , x86@kernel.org, Dave Hansen , Andy Lutomirski , Peter Zijlstra , Mike Kravetz , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-mm@kvack.org Cc: Alexandre Ghiti Subject: [PATCH v6 0/4] Fix free/allocation of runtime gigantic pages Date: Thu, 7 Mar 2019 08:20:11 -0500 Message-Id: <20190307132015.26970-1-alex@ghiti.fr> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This series fixes sh and sparc that did not advertise their gigantic page support and then were not able to allocate and free those pages at runtime. It renames MEMORY_ISOLATION && COMPACTION || CMA condition into the more accurate CONTIG_ALLOC, since it allows the definition of alloc_contig_range function. Finally, it then fixes the wrong definition of ARCH_HAS_GIGANTIC_PAGE config that, without MEMORY_ISOLATION && COMPACTION || CMA defined, did not allow architectures to free boottime allocated gigantic pages although unrelated. Changes in v6: - Remove unnecessary goto since the fallthrough path does the same and is the 'normal' behaviour, as suggested by Dave Hensen - Be more explicit in comment in set_max_huge_page: we return an error if alloc_contig_range is not defined and the user tries to allocate a gigantic page (we keep the same behaviour as before this patch), but we now let her free boottime gigantic page, as suggested by Dave Hensen - Add Acked-by, thanks. Changes in v5: - Fix bug in previous version thanks to Mike Kravetz - Fix block comments that did not respect coding style thanks to Dave Hensen - Define ARCH_HAS_GIGANTIC_PAGE only for sparc64 as advised by David Miller - Factorize "def_bool" and "depends on" thanks to Vlastimil Babka Changes in v4 as suggested by Dave Hensen: - Split previous version into small patches - Do not compile alloc_gigantic** functions for architectures that do not support those pages - Define correct ARCH_HAS_GIGANTIC_PAGE in all arch that support them to avoid useless runtime check - Add comment in set_max_huge_pages to explain that freeing is possible even without CONTIG_ALLOC defined - Remove gigantic_page_supported function across all archs Changes in v3 as suggested by Vlastimil Babka and Dave Hansen: - config definition was wrong and is now in mm/Kconfig - COMPACTION_CORE was renamed in CONTIG_ALLOC Changes in v2 as suggested by Vlastimil Babka: - Get rid of ARCH_HAS_GIGANTIC_PAGE - Get rid of architecture specific gigantic_page_supported - Factorize CMA or (MEMORY_ISOLATION && COMPACTION) into COMPACTION_CORE Alexandre Ghiti (4): sh: Advertise gigantic page support sparc: Advertise gigantic page support mm: Simplify MEMORY_ISOLATION && COMPACTION || CMA into CONTIG_ALLOC hugetlb: allow to free gigantic pages regardless of the configuration arch/arm64/Kconfig | 2 +- arch/arm64/include/asm/hugetlb.h | 4 -- arch/powerpc/include/asm/book3s/64/hugetlb.h | 7 --- arch/powerpc/platforms/Kconfig.cputype | 2 +- arch/s390/Kconfig | 2 +- arch/s390/include/asm/hugetlb.h | 3 -- arch/sh/Kconfig | 1 + arch/sparc/Kconfig | 1 + arch/x86/Kconfig | 2 +- arch/x86/include/asm/hugetlb.h | 4 -- arch/x86/mm/hugetlbpage.c | 2 +- include/linux/gfp.h | 4 +- mm/Kconfig | 3 ++ mm/hugetlb.c | 57 ++++++++++++-------- mm/page_alloc.c | 7 ++- 15 files changed, 50 insertions(+), 51 deletions(-) -- 2.20.1