Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Leon Romanovsky <leonro@mellanox.com>
To:     Bart Van Assche <bvanassche@acm.org>
CC:     Jason Gunthorpe <jgg@mellanox.com>,
        Kees Cook <keescook@chromium.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: Re: [PATCH] Avoid that check_shl_overflow() triggers a compiler
 warning when building with W=1
Thread-Topic: [PATCH] Avoid that check_shl_overflow() triggers a compiler
 warning when building with W=1
Thread-Index: AQHU1IFjo1AIqyRPikaxzNyP0OOhK6X/X/kAgAAN6YCAAFa0AIAAfZIAgAAM+QA=
Date:   Thu, 7 Mar 2019 15:40:23 +0000
Message-ID: <20190307154020.GN1789@mtr-leonro.mtl.com>
References: <20190307010153.81157-1-bvanassche@acm.org>
 <20190307012417.GU1758@mellanox.com>
 <8a5bd9ae-ebfe-687c-2868-d0f2a610d1e0@acm.org>
 <20190307072428.GJ1789@mtr-leonro.mtl.com>
 <4d90c392-5b6a-fea0-e6cf-c49ac19fdf30@acm.org>
In-Reply-To: <4d90c392-5b6a-fea0-e6cf-c49ac19fdf30@acm.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [77.138.135.184]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 57386934-306a-4ac4-2387-08d6a313369c
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020);SRVR:DB6SPR00MB11;
x-ms-traffictypediagnostic: DB6SPR00MB11:
x-ms-exchange-purlcount: 1
x-microsoft-exchange-diagnostics: =?us-ascii?Q?1;DB6SPR00MB11;23:9AgRCNnVMTZOflil5L7XMZJi/mmbvyaKqW4Rkpnwxd?=
 =?us-ascii?Q?8UsRxE1Di6Ir+yvAJu+ebfBw3N40D7LDvkpVWO4+/Ng7h2UUOhsgOkm9c+JS?=
 =?us-ascii?Q?IXkoIlsRVAEYRfG88ZgQwTqjv02t5OmaI07DlCXtaFl+8jNaoxdafz0PvRZK?=
 =?us-ascii?Q?Wr8Vyc89gKoS3nByKF3SHpHebWZYgeElYr52jx7QtHChjc4cw6Vo2m9KDHVV?=
 =?us-ascii?Q?nrRZe/R6M3EXMTS4oz+TDT0ur0cTAslG01v6C40W2GYgzCBRMV7+8YSsioff?=
 =?us-ascii?Q?7vInOFUMTvqFK5KB+7MuI3Sx3WpirY1iBwBDIhXcYERtjA4t98wL5tu+dMdB?=
 =?us-ascii?Q?sAqjRrXUewZBH0HrEaex9itQKWyh3U9c3+41hmv83IObus24MBpHYslzIQ+A?=
 =?us-ascii?Q?+h7Rkro7eq8J6KCQV1KMtpAO54RTN68ZaN82aO84Vgy/I+/YO3fvFnJaLQoe?=
 =?us-ascii?Q?FziFibGM7vBM12HLc37IeQvTCn4QHDeITcXklBRPWNJflfS5uYyk91lBPoMi?=
 =?us-ascii?Q?Qhypz1ouEThXoNnrJlevlg8tZPrnke8QT/0wGRKcrGKUszoLEKV0iNPWVOza?=
 =?us-ascii?Q?4p9n7urcmNXjFw58Xy9cKy0arATCLJeaE5JqmBjeDHfzDXTWC+yZl6k28uTB?=
 =?us-ascii?Q?VsuLlzOdPXuLoVkbgazAXozZdB4aE8fGdqI8N1cusS1vjFjLdLw5Cy8D2Yg0?=
 =?us-ascii?Q?SX52F7EUlyz3DFqiTk0lReyq6st3DjsvMIEX1KcGUkvYqbBKn7EQK+z2w23q?=
 =?us-ascii?Q?vZhny4LtaWHk5lVE3gI2oV8pnqfiHYm7uwXqRNNW457qj5AhahdtDzgr6qjz?=
 =?us-ascii?Q?kBREm3xgAd41ob1lERw53E43FKjn3sOslwttOB++9Ue5mlOSPrjQzGbcoqdI?=
 =?us-ascii?Q?mC04LR048/AuJixITm43LL+BBs0b6V4U808HRk72mWQKzmxqXh7vOiAJxPnw?=
 =?us-ascii?Q?goRw84YXyCVD3MHMKE8gYbWxzewPoa7zmiA0kG/NXE//StzUlDX7qDqVw9lL?=
 =?us-ascii?Q?DGI9VvoC4rQbGbAaqV84uMC3tsRLOj85B1vSUzzYZoZ+BzkGuJPWt5U0tapt?=
 =?us-ascii?Q?QOufnvK3oD3w2RR6fCFgateWRTgUy3UFy6dDWjfQp1krbzz5rmm/kdSH5VLA?=
 =?us-ascii?Q?sel4spK3ukGnhSIltpTfAvLDE2XrMlINbDIMRVCQOPbKYd5Fcz27IPnnRtqi?=
 =?us-ascii?Q?++u6KgzKnT+YdzI/Ri/0DYzrTIOtX1MgkONQllPCaBnHx688KWs5rzrFXMt6?=
 =?us-ascii?Q?D0xZuSxx8kI3E4CmdwLeD/UBjPkIe2QSoAPsUsGlHuQu/pgwnERIn+LZ2WBE?=
 =?us-ascii?Q?oUaHm9YLgUpGWBy+KBx0c=3D?=
x-microsoft-antispam-prvs: <DB6SPR00MB11D2C11E418B85AA459490B04C0@DB6SPR00MB11.eurprd05.prod.outlook.com>
x-forefront-prvs: 096943F07A
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(136003)(366004)(396003)(39860400002)(376002)(346002)(189003)(199004)(86362001)(71200400001)(71190400001)(97736004)(256004)(66066001)(305945005)(7736002)(8936002)(8676002)(81166006)(81156014)(476003)(26005)(11346002)(93886005)(6306002)(446003)(54906003)(486006)(186003)(53936002)(5660300002)(229853002)(6512007)(9686003)(6436002)(6506007)(386003)(53546011)(102836004)(6486002)(76176011)(52116002)(6916009)(6246003)(4326008)(25786009)(316002)(2906002)(99286004)(478600001)(14454004)(966005)(33656002)(1076003)(105586002)(3846002)(4744005)(6116002)(106356001)(68736007);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6SPR00MB11;H:DB6PR0501MB2694.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: mellanox.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: R2p6nb4e82jL6RPA+vhIOuh4v5CSdI4iVHhhwGDn5wsxVO1sDdUBgQCaXKnp/25o+hbuW3faT+8QchVfn+xJfFayZhneKXncAZ2tuX3CJCXYztQwjxfxxFR7FAPHvdb8T5kmGPKCNzD8Hi5VxJ509tf0EfX0mXm2j9CY10tZIKbE9pRLSUply20LKQlo9X5JXrt6ARddlO0oQ/Ct7wWuoomEk2zjUayIReGcmUNj8fl4A1SbiYPj4TrSYspuWOT/IDKzCMUdg8u0W5Ywam1Jo1wtJY/7Fu5ah3V/Y4zBoraSbVcMNu4Ap/3s/gSF0c7PhnSewI+reKAbc9sgoEJ1EsLuNARQxGVBsi0W/IF5Yo8d/RSTAcbGxo/NjTG68wBmdw0G1+MAwUpLa5fSRh579lyqWzajhuiJuOG3EQX44Pw=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <85B98162D3863444929A31A9450182D7@eurprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Mellanox.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 57386934-306a-4ac4-2387-08d6a313369c
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Mar 2019 15:40:23.9165
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6SPR00MB11
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 07, 2019 at 06:53:54AM -0800, Bart Van Assche wrote:
> On 3/6/19 11:24 PM, Leon Romanovsky wrote:
> > My simple patch passes too :).
>
> Can you repost your patch?

https://patchwork.kernel.org/patch/10841079/

As Rasmus wrote, the thing is to avoid a < 0 check. In my patch,
I converted a <=3D 0 to !(a > 0 || a =3D=3D 0) expression.

Thanks

>
> Thanks,
>
> Bart.