Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp5147746imb; Thu, 7 Mar 2019 08:46:17 -0800 (PST) X-Google-Smtp-Source: APXvYqzfzQZ8ks+g924zPjrtKaFUWAVRm1Aunn88yEz86edxWdQ6CVfwfknYwL3RtszxtLPGCi3P X-Received: by 2002:a63:40c1:: with SMTP id n184mr11675027pga.225.1551977177845; Thu, 07 Mar 2019 08:46:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551977177; cv=none; d=google.com; s=arc-20160816; b=DhuAddeOhGfenqkqstWi4fKw0pGUjxmazSfFmtyxk7RzcJaNcKmLwBf+9wPRxBBknS /ThK3pn0IdjmzwfHiWIUFo2TkLd3qsz/I4vMAEG6nA0qyx6+MjkyfdJAhv3TCdPo2T85 vYX6EDvcsPYr0Gc6UvvcA2lXqEAXUPl701CDLfG0qcdagoUYeWPlBfR2Gdkvm3/ujZDg 5Efn6piYJkWfmu2mdChkvoQ7CTHHNjkatgC+b/jVGqBKFonWA9UDNdqWXO6NldySgsSJ sOkzBwUloYq3Ym9key+ieNGlR9h8ikgxQRP+xALVvfL7znXhqirAk5J6PJqGuDuZJ7ON z/Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:autocrypt:openpgp:from:references:cc:to :subject; bh=IRCcJN51Cc30o3eXipqWFsD7cCNgr0u1yNMHpkETadg=; b=doYnGMoKM4kaGBDp6OHB2zpmDl7Ob/jtDAzfMCnBMyb9FI7ruazZIE9RxudGbfTgHO 5M89hq68kFIFA3TB99R8xOVFD0uD/mI6k+NJEKKQCPPy+Kh1vffhX9Dd/KHgDt4mZbF+ /pRLj2UK6r6VCCKmX+ljlbCpX2FEGiWWuC6RYVxYBCtDitBDNvIWuSmte5wNPc4Er6Dk vnNsJ42LlvBu5rTcOdaNHqFloF5No3xmPGgINzAzoPJDpIwV2qLGE2iXRQY3OdGtCjYH QVusTS7jyemuuHKMSsVdU1W6MjxUlJnw1tCnFdDuoPUzqgWILfVtNyKOYPm74Ng4ywHA VF3g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x6si4189634pgr.372.2019.03.07.08.46.02; Thu, 07 Mar 2019 08:46:17 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726269AbfCGQo0 (ORCPT + 99 others); Thu, 7 Mar 2019 11:44:26 -0500 Received: from foss.arm.com ([217.140.101.70]:48472 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726127AbfCGQo0 (ORCPT ); Thu, 7 Mar 2019 11:44:26 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5306B80D; Thu, 7 Mar 2019 08:44:25 -0800 (PST) Received: from [10.1.196.92] (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CB1783F575; Thu, 7 Mar 2019 08:44:23 -0800 (PST) Subject: Re: [PATCH] irqchip: stm32: add a second level init to request hwspinlock To: Fabien Dessenne , Thomas Gleixner , Jason Cooper , Maxime Coquelin , Alexandre Torgue , linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Cc: Benjamin Gaignard References: <1551975829-16350-1-git-send-email-fabien.dessenne@st.com> From: Marc Zyngier Openpgp: preference=signencrypt Autocrypt: addr=marc.zyngier@arm.com; prefer-encrypt=mutual; keydata= mQINBE6Jf0UBEADLCxpix34Ch3kQKA9SNlVQroj9aHAEzzl0+V8jrvT9a9GkK+FjBOIQz4KE g+3p+lqgJH4NfwPm9H5I5e3wa+Scz9wAqWLTT772Rqb6hf6kx0kKd0P2jGv79qXSmwru28vJ t9NNsmIhEYwS5eTfCbsZZDCnR31J6qxozsDHpCGLHlYym/VbC199Uq/pN5gH+5JHZyhyZiNW ozUCjMqC4eNW42nYVKZQfbj/k4W9xFfudFaFEhAf/Vb1r6F05eBP1uopuzNkAN7vqS8XcgQH qXI357YC4ToCbmqLue4HK9+2mtf7MTdHZYGZ939OfTlOGuxFW+bhtPQzsHiW7eNe0ew0+LaL 3wdNzT5abPBscqXWVGsZWCAzBmrZato+Pd2bSCDPLInZV0j+rjt7MWiSxEAEowue3IcZA++7 ifTDIscQdpeKT8hcL+9eHLgoSDH62SlubO/y8bB1hV8JjLW/jQpLnae0oz25h39ij4ijcp8N t5slf5DNRi1NLz5+iaaLg4gaM3ywVK2VEKdBTg+JTg3dfrb3DH7ctTQquyKun9IVY8AsxMc6 lxl4HxrpLX7HgF10685GG5fFla7R1RUnW5svgQhz6YVU33yJjk5lIIrrxKI/wLlhn066mtu1 DoD9TEAjwOmpa6ofV6rHeBPehUwMZEsLqlKfLsl0PpsJwov8TQARAQABtCNNYXJjIFp5bmdp ZXIgPG1hcmMuenluZ2llckBhcm0uY29tPokCOwQTAQIAJQIbAwYLCQgHAwIGFQgCCQoLBBYC AwECHgECF4AFAk6NvYYCGQEACgkQI9DQutE9ekObww/+NcUATWXOcnoPflpYG43GZ0XjQLng LQFjBZL+CJV5+1XMDfz4ATH37cR+8gMO1UwmWPv5tOMKLHhw6uLxGG4upPAm0qxjRA/SE3LC 22kBjWiSMrkQgv5FDcwdhAcj8A+gKgcXBeyXsGBXLjo5UQOGvPTQXcqNXB9A3ZZN9vS6QUYN TXFjnUnzCJd+PVI/4jORz9EUVw1q/+kZgmA8/GhfPH3xNetTGLyJCJcQ86acom2liLZZX4+1 6Hda2x3hxpoQo7pTu+XA2YC4XyUstNDYIsE4F4NVHGi88a3N8yWE+Z7cBI2HjGvpfNxZnmKX 6bws6RQ4LHDPhy0yzWFowJXGTqM/e79c1UeqOVxKGFF3VhJJu1nMlh+5hnW4glXOoy/WmDEM UMbl9KbJUfo+GgIQGMp8mwgW0vK4HrSmevlDeMcrLdfbbFbcZLNeFFBn6KqxFZaTd+LpylIH bOPN6fy1Dxf7UZscogYw5Pt0JscgpciuO3DAZo3eXz6ffj2NrWchnbj+SpPBiH4srfFmHY+Y LBemIIOmSqIsjoSRjNEZeEObkshDVG5NncJzbAQY+V3Q3yo9og/8ZiaulVWDbcpKyUpzt7pv cdnY3baDE8ate/cymFP5jGJK++QCeA6u6JzBp7HnKbngqWa6g8qDSjPXBPCLmmRWbc5j0lvA 6ilrF8m5Ag0ETol/RQEQAM/2pdLYCWmf3rtIiP8Wj5NwyjSL6/UrChXtoX9wlY8a4h3EX6E3 64snIJVMLbyr4bwdmPKULlny7T/R8dx/mCOWu/DztrVNQiXWOTKJnd/2iQblBT+W5W8ep/nS w3qUIckKwKdplQtzSKeE+PJ+GMS+DoNDDkcrVjUnsoCEr0aK3cO6g5hLGu8IBbC1CJYSpple VVb/sADnWF3SfUvJ/l4K8Uk4B4+X90KpA7U9MhvDTCy5mJGaTsFqDLpnqp/yqaT2P7kyMG2E w+eqtVIqwwweZA0S+tuqput5xdNAcsj2PugVx9tlw/LJo39nh8NrMxAhv5aQ+JJ2I8UTiHLX QvoC0Yc/jZX/JRB5r4x4IhK34Mv5TiH/gFfZbwxd287Y1jOaD9lhnke1SX5MXF7eCT3cgyB+ hgSu42w+2xYl3+rzIhQqxXhaP232t/b3ilJO00ZZ19d4KICGcakeiL6ZBtD8TrtkRiewI3v0 o8rUBWtjcDRgg3tWx/PcJvZnw1twbmRdaNvsvnlapD2Y9Js3woRLIjSAGOijwzFXSJyC2HU1 AAuR9uo4/QkeIrQVHIxP7TJZdJ9sGEWdeGPzzPlKLHwIX2HzfbdtPejPSXm5LJ026qdtJHgz BAb3NygZG6BH6EC1NPDQ6O53EXorXS1tsSAgp5ZDSFEBklpRVT3E0NrDABEBAAGJAh8EGAEC AAkFAk6Jf0UCGwwACgkQI9DQutE9ekMLBQ//U+Mt9DtFpzMCIHFPE9nNlsCm75j22lNiw6mX mx3cUA3pl+uRGQr/zQC5inQNtjFUmwGkHqrAw+SmG5gsgnM4pSdYvraWaCWOZCQCx1lpaCOl MotrNcwMJTJLQGc4BjJyOeSH59HQDitKfKMu/yjRhzT8CXhys6R0kYMrEN0tbe1cFOJkxSbV 0GgRTDF4PKyLT+RncoKxQe8lGxuk5614aRpBQa0LPafkirwqkUtxsPnarkPUEfkBlnIhAR8L kmneYLu0AvbWjfJCUH7qfpyS/FRrQCoBq9QIEcf2v1f0AIpA27f9KCEv5MZSHXGCdNcbjKw1 39YxYZhmXaHFKDSZIC29YhQJeXWlfDEDq6nIhvurZy3mSh2OMQgaIoFexPCsBBOclH8QUtMk a3jW/qYyrV+qUq9Wf3SKPrXf7B3xB332jFCETbyZQXqmowV+2b3rJFRWn5hK5B+xwvuxKyGq qDOGjof2dKl2zBIxbFgOclV7wqCVkhxSJi/QaOj2zBqSNPXga5DWtX3ekRnJLa1+ijXxmdjz hApihi08gwvP5G9fNGKQyRETePEtEAWt0b7dOqMzYBYGRVr7uS4uT6WP7fzOwAJC4lU7ZYWZ yVshCa0IvTtp1085RtT3qhh9mobkcZ+7cQOY+Tx2RGXS9WeOh2jZjdoWUv6CevXNQyOUXMM= Organization: ARM Ltd Message-ID: <97040a1e-7a24-3d41-c3b7-43b551a70825@arm.com> Date: Thu, 7 Mar 2019 16:44:21 +0000 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <1551975829-16350-1-git-send-email-fabien.dessenne@st.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/03/2019 16:23, Fabien Dessenne wrote: > Requesting hwspinlock, at the first time it is used, is not correct: > indeed, at that moment we are under raw_spin_lock_irqsave() context and > hwspin_lock_request_specific() may sleep ("BUG: sleeping function called > from invalid context"). > Requesting hwspinlock during the init (stm32*_exti_of_init()) is also > not possible (the hwspinlock framework is not ready at that stage of the > kernel init). > As a consequence, add a second level init (probed with arch_initcall) > where we can safely request hwspinlock. No, this is fairly broken. You're playing with stuff you're not supposed to (OF_POPULATE? really?), and adding initcalls is completely unreliable (things depend on the link order and will randomly break). If you need dependencies, implement them correctly. Turn this driver into a real device driver (in the platform device sense), and return PROBE_DEFER when you can't find your dependency. Thanks, M. -- Jazz is not dead. It just smells funny...