Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp5170654imb; Thu, 7 Mar 2019 09:14:29 -0800 (PST) X-Google-Smtp-Source: APXvYqxW8XyaiG7bZIFtlLclMog6h1bKvBw74PWrUwTYSIWXPh4DCC5xfZBjBQG+xrES1AyjRhxG X-Received: by 2002:a62:ea08:: with SMTP id t8mr13696829pfh.60.1551978869026; Thu, 07 Mar 2019 09:14:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551978869; cv=none; d=google.com; s=arc-20160816; b=LdVv9Y1e/4GIapZtBQRiFnp3iwFIRDIQgfMdQZz25uGspHo3ZlShI4g19fHFWxpcrM j9V0rsEfGe7+19HkY66Q/cb8Jq1YKpYjrmRJsTFJ+/U6WMHU36CiRapAF6LGuKtOg5ta cIlnbBx6t9CCPQy/DzpTm632z4Nux7bcxIB76DPq7aUto6+5sujXvkf2CbJejr1Utd73 7NRS/9bX1iE+upfy/t0sWgPslkZQkIbp5S8J5ohFoA2D/d+9LYOyzjDVjKW5F3etX8NG KHvSsFy5aMk505IMs6xqs+hXPagf3XIluAtmzRdywkE617hE95QozktwA8e/G+6goPts gvzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:from:cc:to:subject :content-transfer-encoding:mime-version:references:in-reply-to :user-agent:date; bh=TPgviASl4JL97oq/Gc/ToU4wcaZ+gwtJblICz/ekDKw=; b=bs1VxJMEStSDoyO1uJ6cLCJ4leXASzsjTDMzVzzwMYzK2VtHdRU6skWkahRnXP1l01 xrhJhjM3RB+Y10Wcb7DeduSY2GIXQIjnS0mwJzxdHy/k3p98aShrgC61P8TRy9y8byPH ny2TjY1qZ6Y3cb2f9JrC+aLyhfzZpST2/8g8Yq90FPtrcyQ+H/m3YqfXGgVzADgGeJNK 9dED911YK1kC+ZNT/WL7urOfzn92A6/+pMWtIUdgAqHJedm+aJjSw27+Oc6PWNEB3GUe XbZOxGCottWewJz0IrzxsJYb2ojaRXxlvs9Tl373RooyTBo4fbyUWLD/LOhCIaqKCLKC uZPQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 72si4736769ple.250.2019.03.07.09.14.11; Thu, 07 Mar 2019 09:14:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726483AbfCGRMP convert rfc822-to-8bit (ORCPT + 99 others); Thu, 7 Mar 2019 12:12:15 -0500 Received: from terminus.zytor.com ([198.137.202.136]:56325 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726351AbfCGRMP (ORCPT ); Thu, 7 Mar 2019 12:12:15 -0500 Received: from [172.19.131.165] ([8.46.77.96]) (authenticated bits=0) by mail.zytor.com (8.15.2/8.15.2) with ESMTPSA id x27HBAXR2267629 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Thu, 7 Mar 2019 09:11:14 -0800 Date: Thu, 07 Mar 2019 09:10:38 -0800 User-Agent: K-9 Mail for Android In-Reply-To: References: <20190307114511.870090179@infradead.org> <20190307115200.697533978@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Subject: Re: [PATCH 18/20] objtool: Add UACCESS validation To: Linus Torvalds , Peter Zijlstra CC: Thomas Gleixner , Julien Thierry , Will Deacon , Andy Lutomirski , Ingo Molnar , Catalin Marinas , James Morse , valentin.schneider@arm.com, Brian Gerst , Josh Poimboeuf , Andrew Lutomirski , Borislav Petkov , Denys Vlasenko , Linux List Kernel Mailing , Dmitry Vyukov , Steven Rostedt From: hpa@zytor.com Message-ID: <5127C62D-E97D-40B0-85B3-16F30B7ED514@zytor.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On March 7, 2019 8:33:26 AM PST, Linus Torvalds wrote: >On Thu, Mar 7, 2019 at 3:52 AM Peter Zijlstra >wrote: >> >> XXX: are we sure we want __memset marked AC-safe? > >It's certainly one of the safer functions to call with AC set, but it >sounds wrong anyway. It's not like it's likely to leak kernel data >(most memset's are with 0, and even the non-zero ones I can't imagine >are sensitive - more like poison values etc). > >What's the call site that made you go "just add __memset() to the >list"? > > Linus Agreed... it seems fishy at least. -- Sent from my Android device with K-9 Mail. Please excuse my brevity.