Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 7 Mar 2019 20:09:39 +0100
From:   Peter Zijlstra <peterz@infradead.org>
To:     Arnaldo Carvalho de Melo <acme@redhat.com>
Cc:     Stephane Eranian <eranian@google.com>,
        linux-kernel@vger.kernel.org, ak@linux.intel.com,
        kan.liang@intel.com, mingo@elte.hu, jolsa@redhat.com,
        acme@kernel.org
Subject: Re: [PATCH] perf/core: restore mmap record type correctly
Message-ID: <20190307190939.GB2482@worktop.programming.kicks-ass.net>
References: <20190307185233.225521-1-eranian@google.com>
 <20190307190330.GA2443@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190307190330.GA2443@redhat.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Mar 07, 2019 at 04:03:30PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Mar 07, 2019 at 10:52:33AM -0800, Stephane Eranian escreveu:
> > On mmap(), perf_events generates a RECORD_MMAP record and then checks
> > which events are interested in this record. There are currently 2 versions
> > of mmap records: RECORD_MMAP and RECORD_MMAP2. MMAP2 is larger. The event
> > configuration controls which version the user level tool accepts. If the
> > event->attr.mmap2=1 field then MMAP2 record is returned. The
> > perf_event_mmap_output() takes care of this. It checks attr->mmap2 and corrects
> > the record fields before putting it in the sampling buffer of the event.
> > At the end the function restores the modified MMAP record fields.
> > 
> > The problem is that the function restores the size but not the
> > type. Thus, if a subsequent event only accepts MMAP type, then it would
> > instead receive an MMAP2 record with a size of MMAP record.
> > 
> > This patch fixes the problem by restoring the record type on exit.
> 
> Right, simple enough, bug fixed, Peter, I'm taking this one, ok?

Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>