Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp5258435imb; Thu, 7 Mar 2019 11:16:30 -0800 (PST) X-Google-Smtp-Source: APXvYqy0qKzx3agMZYl71pRR643/YCl6E5UVIT+h0tk+7xhIGag1LURpXREB2jZzovbFI+mnrz4+ X-Received: by 2002:a17:902:2e01:: with SMTP id q1mr14402738plb.240.1551986190055; Thu, 07 Mar 2019 11:16:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551986190; cv=none; d=google.com; s=arc-20160816; b=l2DENIOwv24QVmqHXSWnG8sdf0xx6dplRqk/C5uWwU5zdS5/jONuGjBZf/V+2/TKCU nOcmqH7tv8j6eN6ESQAdH7prbw9UFoQ0efnloW6zmqCeP73EuDN5Z41lJ5HizEFOFRxs n9nuXX3C8RX121F0hIlAq1nyrLr3k1qSn/5Eu3HxdbjpMYWoqK2CDpui7EmPjjJuJ09K XOd73FaNcLZ5aVmvBKlQAqI9i5Qg1L9jAlYmP+J1DBa4dhwqZ2+ZY/pfRtQnnbpxMPMc rWhX53IzKTgGQO3YZpZyRac3wuto+7xUkWTV7p9xB0ZUHH/CHm9QrPn8e+arJ8Q9RG5E 2l5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from; bh=juvLgMibN1bm89DGQQO3OuGlboLbeszYKU13hQsJBNE=; b=gLsSyJwp1u/MgZyF8ukggGkvNhrVzFHLlW0KwQGGYX6ryF/RFTtKDHLrfSyN35GQo+ TNNHGaCivzp4u+ow9D8GYy5lEXYCq3YveozZ86IK5DF1MwG2XWDulQzm7xCJEZTVXop6 KL19L1T0Tmx+KR7nGveVXPh9jkbYzXckUqgOhSEFWtrtd02LD4amgbiZD2/IOJiYMl3D Ra5eiypKrKnrPHGgwOwBcwTiIirQ+6d7vRQ7kmdvW/f0nzKSwfwNt4TEDQds/lmiFPw3 b2O1RmOLSc6NHDJRnn1N9T/nx6y2ZRTlGN6qt9/ttTtJ0IwhPnA90K4BFBjmstzPVhSB 2T6Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h98si5004312plb.93.2019.03.07.11.16.13; Thu, 07 Mar 2019 11:16:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726442AbfCGTPy (ORCPT + 99 others); Thu, 7 Mar 2019 14:15:54 -0500 Received: from smtp12.smtpout.orange.fr ([80.12.242.134]:24334 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726279AbfCGTPy (ORCPT ); Thu, 7 Mar 2019 14:15:54 -0500 Received: from belgarion ([90.76.35.80]) by mwinf5d23 with ME id l7Ff1z00R1jkVcS037FmZS; Thu, 07 Mar 2019 20:15:50 +0100 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Thu, 07 Mar 2019 20:15:50 +0100 X-ME-IP: 90.76.35.80 From: Robert Jarzmik To: Nathan Chancellor Cc: Arnd Bergmann , Ulf Hansson , Nick Desaulniers , Daniel Mack , Linus Walleij , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mmc: pxamci: fix enum type confusion References: <20190307100948.570006-1-arnd@arndb.de> <20190307152029.GD20201@archlinux-ryzen> X-URL: http://belgarath.falguerolles.org/ Date: Thu, 07 Mar 2019 20:15:39 +0100 In-Reply-To: <20190307152029.GD20201@archlinux-ryzen> (Nathan Chancellor's message of "Thu, 7 Mar 2019 08:20:29 -0700") Message-ID: <87mum65wdg.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/26 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Nathan Chancellor writes: > On Thu, Mar 07, 2019 at 11:09:19AM +0100, Arnd Bergmann wrote: >> clang points out several instances of mismatched types in this drivers, >> all coming from a single declaration: >> >> drivers/mmc/host/pxamci.c:193:15: error: implicit conversion from enumeration type 'enum dma_transfer_direction' to >> different enumeration type 'enum dma_data_direction' [-Werror,-Wenum-conversion] >> direction = DMA_DEV_TO_MEM; >> ~ ^~~~~~~~~~~~~~ >> drivers/mmc/host/pxamci.c:212:62: error: implicit conversion from enumeration type 'enum dma_data_direction' to >> different enumeration type 'enum dma_transfer_direction' [-Werror,-Wenum-conversion] >> tx = dmaengine_prep_slave_sg(chan, data->sg, host->dma_len, direction, >> >> The behavior is correct, so this must be a simply typo from >> dma_data_direction and dma_transfer_direction being similarly named >> types with a similar purpose. >> >> Fixes: 6464b7140951 ("mmc: pxamci: switch over to dmaengine use") >> Signed-off-by: Arnd Bergmann > > Reviewed-by: Nathan Chancellor Acked-by: Robert Jarzmik Cheers. -- Robert