Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp5302446imb; Thu, 7 Mar 2019 12:24:23 -0800 (PST) X-Google-Smtp-Source: APXvYqzf0tKKxxToDcbJyBD2qpTP3ePH5KRWDtygkxNSqGGaHgVE5rCNNPypsrUcA8IkOKJScyFi X-Received: by 2002:a63:3fc8:: with SMTP id m191mr13181417pga.240.1551990263583; Thu, 07 Mar 2019 12:24:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551990263; cv=none; d=google.com; s=arc-20160816; b=wn4nuED618aJhVDvpfZmRVVP1gRom6Y+tAJylHgTqEOClAcMvXhAv09/ul5pzcsoH+ NXHHWRRISnv2n5ZIVzFNJ2Yd0u6DbP775Us75NBqQTji+2TPkdQknuU8kfahn5k5Cigy jWAm51Vrqu0Yvj8hInSPL8ODDjfSdA+yWVZrK/H0TDYxWm4dKqaYHa8WMT7tX0ZjlpeT v1s3Ix2TgmZczIV+0dtF3dhGYsfIslmemGiFg1YaGuOPAGnCnDo4QxksAMzuKOw9bSBP D+WkG6DcbwGASFSjXYtGW4Si0tt0l2nBLSoMl6/09ueE3u7pFRdEo0G8pY30Q/d8GJOU QHLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=iaI6XeEEu4SJCagaIHkTGqUt1vBjx7JvMKxV3byT/T4=; b=uxIsKLhz5Vodymq0IrlbCVQwgJcak58XwsDJfixmPGDi4mkoPONNQD6SdeH0POGyhZ NPMEYDDKTPzt5/H5Zc7Xy+U4xbfcaDvOwYS6cZkKDiQvIis7BvpL8jqkesZzld4OHG7A f5OHXMueJ5PqyQwmFI6ZnV1m614e78AZE2EjWDuMNcVHxkduUW8YayDZlZQS6HLoHGcZ 4j5b4Ql6jq1DtnrTXTE8QJTg/BA2xiKi4mV5eqQLTI2ZTKyYRiCBlr6atGgzbgvy7bRE +l/EgNG3BH6u0zYokci68cOESCqj0DzvLIMgcphHnCHWA7CkREaWYh5UVi2QUTj6WvCz HSGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=Yhe9w0l6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 136si5330516pfc.170.2019.03.07.12.24.07; Thu, 07 Mar 2019 12:24:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=Yhe9w0l6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726286AbfCGUXg (ORCPT + 99 others); Thu, 7 Mar 2019 15:23:36 -0500 Received: from merlin.infradead.org ([205.233.59.134]:56030 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726185AbfCGUXg (ORCPT ); Thu, 7 Mar 2019 15:23:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=iaI6XeEEu4SJCagaIHkTGqUt1vBjx7JvMKxV3byT/T4=; b=Yhe9w0l65nicgS2wWJEh9Qstm rTngypMgC0ExKUhkWYqyA5OLUN3vBwI5006PPzR0yBHYJPdIg/ilmD1LpXucyz2zYhbs2esnPdz/U 752aiTvQ5s3vq7V8w+a7ugCQiwfIQV2DQxlLhhUpQVgpOXWpC8pfjjotQhMb6bwV4TQf9JaaXvpdj kDTM1zo03j1NFdnJwoz/5AXgXBFdBa8KYImbQU7I+Bx1oN1WpJGIjteGffDMZ2Hg1ZaPmrrtxyUuv KbBS1PlHrcg6fOXnICLynKbDvpzCSQUTj0ArzinJHzgpJOWl8xnhW6JE95V5PJyX/wCYahbX9PUg5 1aYZWkNWg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1zY1-000178-Uk; Thu, 07 Mar 2019 20:23:22 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 2F43920297BC0; Thu, 7 Mar 2019 21:23:19 +0100 (CET) Date: Thu, 7 Mar 2019 21:23:19 +0100 From: Peter Zijlstra To: Linus Torvalds Cc: Thomas Gleixner , Peter Anvin , Julien Thierry , Will Deacon , Andy Lutomirski , Ingo Molnar , Catalin Marinas , James Morse , valentin.schneider@arm.com, Brian Gerst , Josh Poimboeuf , Andrew Lutomirski , Borislav Petkov , Denys Vlasenko , Linux List Kernel Mailing , Dmitry Vyukov , Steven Rostedt Subject: Re: [PATCH 18/20] objtool: Add UACCESS validation Message-ID: <20190307202319.GD32534@hirez.programming.kicks-ass.net> References: <20190307114511.870090179@infradead.org> <20190307115200.697533978@infradead.org> <20190307174135.GJ32477@hirez.programming.kicks-ass.net> <20190307184813.GL32477@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190307184813.GL32477@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 07, 2019 at 07:48:13PM +0100, Peter Zijlstra wrote: > Another thing I need to look at is why objtool only found memset_orig > (from __memset) but not memset_erms, which if I read the code right, is > a possible alternative there. Turns out we only look for sibling calls in the original instruction stream, not in any alternatives; which in general seems like a fair enough assumption.