Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp5314139imb; Thu, 7 Mar 2019 12:42:08 -0800 (PST) X-Google-Smtp-Source: APXvYqykgpegZH1ZI7aE89DY20AQ3rSbjBvO3fXfQLLi/19jdRZmIAxaHs4CRxl6MfrFqix3wnqp X-Received: by 2002:a17:902:2865:: with SMTP id e92mr8856056plb.312.1551991328056; Thu, 07 Mar 2019 12:42:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551991328; cv=none; d=google.com; s=arc-20160816; b=aVHdZOwXzG+lpYokaxgB39a49iQiWrG2tU2mXslxi7qT5zV+x0xmIYO61QO0NcZdv1 FncdYBW7/4LdGMqTfPO2BveNONpPoha71c2wcEMJt1tyK1zm2kepT2xUsoc8NOj+bziY U3+4pZ1JPBHAeMdx5gcQhcpWTc/CTib6J40robnZI44tXDzbHwuKzs9u41XkJ5gSE+tl H7c0PN7BniGcWJ3Es6zDdm71u4mgUC60M9xNAxeR3C3CGunpISQheMSHa8il1Wt1XQQW 6QM+jK+4vJJy1Tz+Pzk1ycUWYKQdgEhdzf+eeBkHdLfloZlyleZwJ92AwIZGy1idrEJ/ T04g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=RLGSlF/tlCrksvMvOF1ni/HlSijSJRoMSXyBiUGR9Nk=; b=0d/fiQAlI1mCgPwn2QpHXaQo3CBDHlRsN/sJz4yatBVxqARcC0BMnhWerl6p8nxt6i bHfZljKEc4DDlja6LuxmJiWhMdFiykAAP7fG68raBQ7up4gnLqFiLVUYRAICTwu1VwU3 Op3C/u7V3dsRFa4F5gKkFFnGe/Osof6u29hSQS9houkIid19cZmumqt3AbFafsfS2ud/ zwhXTAtse2Abuecd33qdEi83GDAYV8a5IMp6rZBTqXlTdW1eeeHVgeadUo2YL2RUQFmt +TV6tvJvsMXzax7a49JgSr0c7uF6bY/fRVl/N78e07CWMkSZxzyVTkc4Use9E0aiF2+B QQEQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=RBA5L+Tn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d72si4956377pfm.284.2019.03.07.12.41.52; Thu, 07 Mar 2019 12:42:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=RBA5L+Tn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726342AbfCGUkd (ORCPT + 99 others); Thu, 7 Mar 2019 15:40:33 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:37916 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726285AbfCGUkd (ORCPT ); Thu, 7 Mar 2019 15:40:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=RLGSlF/tlCrksvMvOF1ni/HlSijSJRoMSXyBiUGR9Nk=; b=RBA5L+Tngrpqg8OqCfrLOLsUD jcHOUvHusPk+A4ytgp1P7dSEkBnXfu7HoEF48yVvTbejYEFqxi21o0b/uNjULF2atX5bahDJ82AvR 7J37MqYRgxe4eUzTjnvteDcFD0wltnenzKm77YwCTw1AhAdMbX3LJCrLE//kvU86E3jv7clmOn0MA HH1h3r5ezzvqUxpoub/SNfo//bQJJkzKRa6X8olB2REgk69zQuB+u7qyAzb8hDUfxzcWKVEy24R7S YKzNIQBy9GMf5hNtbmsA/EqgXOCcIiwVZkyffAA9hlcK+l78WJulxNi+dWAY8SPPGkoo6tw+sEVO7 Oofr3bmbA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1zoU-0002N2-Md; Thu, 07 Mar 2019 20:40:22 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 2AC442029B186; Thu, 7 Mar 2019 21:40:21 +0100 (CET) Date: Thu, 7 Mar 2019 21:40:21 +0100 From: Peter Zijlstra To: Linus Torvalds Cc: Thomas Gleixner , Peter Anvin , Julien Thierry , Will Deacon , Andy Lutomirski , Ingo Molnar , Catalin Marinas , James Morse , valentin.schneider@arm.com, Brian Gerst , Josh Poimboeuf , Andrew Lutomirski , Borislav Petkov , Denys Vlasenko , Linux List Kernel Mailing , Dmitry Vyukov , Steven Rostedt Subject: Re: [PATCH 18/20] objtool: Add UACCESS validation Message-ID: <20190307204021.GE32534@hirez.programming.kicks-ass.net> References: <20190307114511.870090179@infradead.org> <20190307115200.697533978@infradead.org> <20190307174135.GJ32477@hirez.programming.kicks-ass.net> <20190307184813.GL32477@hirez.programming.kicks-ass.net> <20190307202319.GD32534@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190307202319.GD32534@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 07, 2019 at 09:23:19PM +0100, Peter Zijlstra wrote: > On Thu, Mar 07, 2019 at 07:48:13PM +0100, Peter Zijlstra wrote: > > Another thing I need to look at is why objtool only found memset_orig > > (from __memset) but not memset_erms, which if I read the code right, is > > a possible alternative there. > > Turns out we only look for sibling calls in the original instruction > stream, not in any alternatives; which in general seems like a fair > enough assumption. And while I'm looking at memset_64.S, why are memset_erms and memset_orig global functions? At the very least they should be local, and ideally not even functions.