Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp5361333imb; Thu, 7 Mar 2019 13:53:08 -0800 (PST) X-Google-Smtp-Source: APXvYqyfYxoE6on5z4TOVfkwHUoj/kI6mrsmc0TvBryqpe0nO4YkzNfGL95y7qbdZctIutSpaK1c X-Received: by 2002:a62:11ca:: with SMTP id 71mr14884421pfr.18.1551995588552; Thu, 07 Mar 2019 13:53:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551995588; cv=none; d=google.com; s=arc-20160816; b=m8a0a76zlwx377I1GwdIZkWlIgGbr6LSt71vhsIV99Ngn9mPdQrfHdfG7Ga5f60ez4 syeX65lzhlPa/CmGLCQErYapyPHZbqnCTXgMJKcZMFKSJ7DPt76t904pIzxqxKnY9qwB M63SiknFF7iwAR1m8HuMa3XxyDAlxV3n1QgngrbMP2MKVV7wrAc+45abCZDDVqjHpUur EzppVpv0+3tUO2TULECtPadjJgH1nXKDVile7DfL0bLcXpydj7E62GTVlVRCBknQsN9y LTGOmewx6Hhn8f0PrT6tacCsOJLFj4G9XPR9RJv2oerN2YN4vbWUOltDHSwpZ/hYRVfM tM0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:subject:from:message-id:cc:to; bh=/OS2Kr2cvKjx1W0872hdlmDZUfPd74jrKONeUd2GD7s=; b=Dy7rl60Elex6ivHqkqOZtHn0Ewnc7Y7qQcbbZBUYJxGS9CIfQstgmIO9N4We4p93Lx 4/hQ9DKnYNMRebkmAw9M6GinYdc+XOQng1DRzDvitwwwPKb4Qaqt15/Xfm/RJyC9va3X P0azbV+IbVt25I07lUzZXtLYIz7smvHePv0SrpE7XlW2pBhvMjVw/u1tpjCRNNH/j+16 Z3EXZE3htolZQNJgwg+bOfPBJ/cBvlSg/W8+YV9M6Dme81eGceFcvfpCW4sy/tFCCN77 KEiJNSEdKfZ4rAXvLekTvtcafKTXzKtxi3QNrh9gPH6prp7gvlapIFnQ3v+z2vnEHv5k PT+w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ck9si5600996plb.196.2019.03.07.13.52.53; Thu, 07 Mar 2019 13:53:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726261AbfCGVwW (ORCPT + 99 others); Thu, 7 Mar 2019 16:52:22 -0500 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:48994 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726216AbfCGVwW (ORCPT ); Thu, 7 Mar 2019 16:52:22 -0500 Received: by kvm5.telegraphics.com.au (Postfix, from userid 502) id 60A8C22C02; Thu, 7 Mar 2019 16:52:19 -0500 (EST) To: "James E.J. Bottomley" , "Martin K. Petersen" Cc: "Gustavo A. R. Silva" , "Michael Schmitz" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Message-Id: <4e853f171366e040818346def7fb043347670662.1551995342.git.fthain@telegraphics.com.au> From: Finn Thain Subject: [PATCH] scsi/NCR5380: Avoid compiler warning when -Wimplicit-fallthrough is enabled Date: Fri, 08 Mar 2019 08:49:02 +1100 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Adjust comments accordingly. Cc: Gustavo A. R. Silva Cc: Michael Schmitz Signed-off-by: Finn Thain --- drivers/scsi/NCR5380.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c index 7fed9bb72784..fe0535affc14 100644 --- a/drivers/scsi/NCR5380.c +++ b/drivers/scsi/NCR5380.c @@ -1932,13 +1932,13 @@ static void NCR5380_information_transfer(struct Scsi_Host *instance) if (!hostdata->connected) return; - /* Fall through to reject message */ - + /* Reject message */ + /* Fall through */ + default: /* * If we get something weird that we aren't expecting, - * reject it. + * log it. */ - default: if (tmp == EXTENDED_MESSAGE) scmd_printk(KERN_INFO, cmd, "rejecting unknown extended message code %02x, length %d\n", -- 2.19.2