Message-ID: <405AA9D9.40109@namesys.com>
Date: Fri, 19 Mar 2004 11:05:45 +0300
From: Hans Reiser <reiser@namesys.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113
MIME-Version: 1.0
To: Chris Mason <mason@suse.com>
CC: Peter Zaitsev <peter@mysql.com>, Jens Axboe <axboe@suse.de>,
       Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: True  fsync() in Linux (on IDE)
References: <1079572101.2748.711.camel@abyss.local>	 <20040318064757.GA1072@suse.de> <1079639060.3102.282.camel@abyss.local>	 <20040318194745.GA2314@suse.de>  <1079640699.11062.1.camel@watt.suse.com>	 <1079641026.2447.327.camel@abyss.local>	 <1079642001.11057.7.camel@watt.suse.com>	 <1079642801.2447.369.camel@abyss.local>	 <1079643740.11057.16.camel@watt.suse.com>	 <1079644190.2450.405.camel@abyss.local> <1079644743.11055.26.camel@watt.suse.com>
In-Reply-To: <1079644743.11055.26.camel@watt.suse.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1602
Lines: 54

Chris Mason wrote:

>On Thu, 2004-03-18 at 16:09, Peter Zaitsev wrote:
>  
>
>>On Thu, 2004-03-18 at 13:02, Chris Mason wrote:
>>
>>    
>>
>>>>In the former case cache is surely not flushed. 
>>>>
>>>>        
>>>>
>>>Hmmm, is it reiser?  For both 2.4 reiserfs and ext3, the flush happens
>>>when you commit.  ext3 always commits on fsync and reiser only commits
>>>when you've changed metadata.
>>>      
>>>
>>Oh. Yes. This is Reiser, I did not think it is FS issue.
>>I'll know to stay away from ReiserFS now.
>>    
>>
>
>For reiserfs data=ordered should be enough to trigger the needed
>commits.  If not, data=journal.  Note that neither fs does barriers for
>O_SYNC, so we're just not perfect in 2.4.
>
>-chris
>
>
>-
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at  http://www.tux.org/lkml/
>
>
>  
>
You are not listening to Peter.  As I understand it from what Peter says 
and your words, your implementation is wrong, and makes fsync 
meaningless.  If so, then you need to fix it.  fsync should not be 
meaningless even for metadata only journaling.  This is a serious bug 
that needs immediate correction, if Peter and I understand it correctly 
from your words.

-- 
Hans

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/