Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp5374088imb; Thu, 7 Mar 2019 14:12:36 -0800 (PST) X-Google-Smtp-Source: APXvYqwVtPbOjTXzh8nLMPZsQT8iHAUbQrVp3UWutJh2dGqOZfan99vtpwILFdmXRZWAAtGMSRSt X-Received: by 2002:a17:902:5066:: with SMTP id f35mr15614323plh.184.1551996756546; Thu, 07 Mar 2019 14:12:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551996756; cv=none; d=google.com; s=arc-20160816; b=J8yVCFE+a+Ost3gcQ9swsWlupQAyiKOckVikr1pvmcuZg/EcB8stYOumBHNV0CFeki u4+HxTcxBtu3PzrA4nye2kDtjNNe91kUKrdAP16jvkTgcvfJUY5d/8DIJq+YiUVevTcD I/rBTDB8S+3Bjhv4EQFF4DwJjv0WDQSsghkQ48gkSgsKUphWoC8bAnEo5Y7EeoB+p415 qhELKkMd40UdiAR1TCC+dYffD+dZ9x2xJNKfbV015iwoTZ4dCGkKsX1FQbGWxLvyWDM4 eMr864ZFcXcm2RoHHIBzC+F41vZmsH1a+RP/33LteY6aR0O7W5neYfOqpDpKtrHSHBoj NHdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=FHC23kKOOD8L5WKDG46G396bmkMA7Azge/SSFHjSA8k=; b=I+WSu/oJJhPHCHvf18FmVp0/YtAm0V5/azSz9DSOfCltQ+kvIEQLw1jOwCJtk72z44 cPHL36xEbWJMeP2tuSOQAB9owEDZZ4XqBCIcZe6iugilNS4SU7hNtqdjrgw6Yd+oRAMK hS04Ucc+GC563i6d+rO0T0y1mMVdURYi34YRwaBIYjWqHbcOWDL65X3JS9fESzgTisZb iT6L2MS2vZ0EX6S/rXOM83NgEeN26NHrNLdbMgMF+FiUpbsKk49B9GhWkI5bme/Yp0U6 06nU4dahIlVCEFdzxjZ+FHGVsaHqBber8te21z8/8xuWf5LbncWWNEuiXWFA/RB6wdNa pqqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@toxicpanda-com.20150623.gappssmtp.com header.s=20150623 header.b=LCTOpdFA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y11si5073626pfm.119.2019.03.07.14.12.20; Thu, 07 Mar 2019 14:12:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@toxicpanda-com.20150623.gappssmtp.com header.s=20150623 header.b=LCTOpdFA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726435AbfCGWLa (ORCPT + 99 others); Thu, 7 Mar 2019 17:11:30 -0500 Received: from mail-yw1-f65.google.com ([209.85.161.65]:44061 "EHLO mail-yw1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726423AbfCGWL3 (ORCPT ); Thu, 7 Mar 2019 17:11:29 -0500 Received: by mail-yw1-f65.google.com with SMTP id x21so14687883ywx.11 for ; Thu, 07 Mar 2019 14:11:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=FHC23kKOOD8L5WKDG46G396bmkMA7Azge/SSFHjSA8k=; b=LCTOpdFAw92Re/ux6wXEumAMdp9TKQwpTrSs5Lh/Qfasc2H2gJ2JHORCOPqt1avoZp 1tmaIxawMjWKMK8d+zD5JXjklFfimS9r/BqlbkyxHnTZO3x7cQwNnqJ6es6GzRicctNr EaB7LXmyAAXYzveD3svhTn+/IauwuK4QoRDoCm2/Sa1cRGHc3hk/h2+0fA/HPC4JljMg eiBJ55Ma79JLsP+jPuXuNBQYRQXn0ouq7/HS6Awte0dQHoJnfCAUHQbnT3JVi8TC+/t2 IAmlCYL0po73tQ2RrijK8nFHuYWuO0Irn89uBprLX2gDt0zoB7NLVDWnzkdl4ndXwcmc 424Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=FHC23kKOOD8L5WKDG46G396bmkMA7Azge/SSFHjSA8k=; b=HwpXZ6KucRKeAYTNpcGig1CZ/LhJ+D2xp/qOOOAGwbHiOOX/5FvntARIU3ebjfCqfk 0rri6viCZRrK3G6K3//UIjrjRo4t6kt/OInJarBCSIO9lAIozJDteP0fy83njDpi9P46 TCKkxrDHVkKRah+Q08hhSSR1dWTIWKfBafFHQNTD6hWzZxfBknXIHLVpopCdMrQKl14U CDUAWxyVLxkdUCv+nC27k1eOfuLWLY6hp/AlP/oJMMJ0arnbEt5aMquTlM6+JOcR/ICf zUDTwPYWlQYgbLCxWQx8gQli5Sxmvz7a439qJqKt735D4plsa8nhWFFRDWjJ2jLxX/d3 4NKw== X-Gm-Message-State: APjAAAUNLmeg5UjVei2SrSFr/o3S1jM0/7SqqGlV/eszGRrd0N5xPkvp jlbuhSJGqfILltuG28Q4CHAnXA== X-Received: by 2002:a81:5f86:: with SMTP id t128mr12396998ywb.467.1551996688797; Thu, 07 Mar 2019 14:11:28 -0800 (PST) Received: from localhost ([2620:10d:c091:180::be7f]) by smtp.gmail.com with ESMTPSA id a194sm2078380ywh.103.2019.03.07.14.11.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Mar 2019 14:11:28 -0800 (PST) Date: Thu, 7 Mar 2019 17:11:27 -0500 From: Josef Bacik To: Andrea Righi Cc: Josef Bacik , Tejun Heo , Li Zefan , Paolo Valente , Johannes Weiner , Jens Axboe , Vivek Goyal , Dennis Zhou , cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] blkcg: introduce io.sync_isolation Message-ID: <20190307221125.hy2j76m6tv7vnjpr@macbook-pro-91.dhcp.thefacebook.com> References: <20190307180834.22008-1-andrea.righi@canonical.com> <20190307180834.22008-3-andrea.righi@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190307180834.22008-3-andrea.righi@canonical.com> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 07, 2019 at 07:08:33PM +0100, Andrea Righi wrote: > Add a flag to the blkcg cgroups to make sync()'ers in a cgroup only be > allowed to write out pages that have been dirtied by the cgroup itself. > > This flag is disabled by default (meaning that we are not changing the > previous behavior by default). > > When this flag is enabled any cgroup can write out only dirty pages that > belong to the cgroup itself (except for the root cgroup that would still > be able to write out all pages globally). > > Signed-off-by: Andrea Righi Reviewed-by: Josef Bacik Thanks, Josef