Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp5420829imb; Thu, 7 Mar 2019 15:34:45 -0800 (PST) X-Google-Smtp-Source: APXvYqyWnAzr/rd14KZ9hKhmMyOWC9R5W3kLY15sdGH2bejGUQ+ILrhxI4zpUQRhGsqCmDMyGUm5 X-Received: by 2002:a17:902:5acc:: with SMTP id g12mr15457977plm.91.1552001685101; Thu, 07 Mar 2019 15:34:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1552001685; cv=none; d=google.com; s=arc-20160816; b=MHjZJcjejiQcXEmZ0tRvxEy71U4JgyHd+Z34wvicpVVunxc9RxPjfMZSTTwPT1jvE1 5GTjf2Jr61jHdkVYZnwG5w5Xu+lOxfOqHad8Gb7tPUsU3UqyFmAwau3pj0vhI+2lpEZe 7cVr/XlTQ6A2RzBlOYoObr/0E/drucjFVG2Zp/uUJ8bqFTiuq6PGL5nhYY9vTIsYutbi 1q5nSYmuM3KzJ0TxUwXWOqHGqmbxiuYYbs3gwG6E9uMkaR9xj91shQ+1EX3MP5oGAfud wCdme3Hacu7X7Ns8OTVj13f+mI01P1lZyS3G4NsFfvpBka7WYXXezcMFy19v3cb44BnQ c+Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=Sbop/e2Y1jW2dASCMBf3SX8kr8ytrYOuWO0KO4p5Y/M=; b=fhbfpQ0pxkNOk3Q/1oycsYYBjxhBfi0sYvKpSYte0jOXT7c6NqcFzwOdPVddC9d//a 1cjx4RSo7b76wJ0XAjAOssahjncFJ/pDLC+ghzLj4mt/yeawT+HBRoPd7CSbTzmrlo8S 2OkTFPJ2t49d5MBESDSNMCJA/KxHUgAl2uk7UQC9t9Tcb9ZY3LIL68SgxcxcRRIB7C6T s/U6tuqOyGsjMCIgM7KmsOIVzCYsVFNwsRSgDy2V9AGAE1Fp+HosWqp41o6sVAV/ZOf/ tlLmpJsND6OYs3n2b0JQDheZ2i72EsCm2gkT8hiMWDnSxQdsE5JTb50rcJjHIjyYvJFN HTfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=q5F3dga4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s10si4903460pgp.564.2019.03.07.15.34.29; Thu, 07 Mar 2019 15:34:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=q5F3dga4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726267AbfCGXeL (ORCPT + 99 others); Thu, 7 Mar 2019 18:34:11 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:38462 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726172AbfCGXeK (ORCPT ); Thu, 7 Mar 2019 18:34:10 -0500 Received: by mail-pg1-f195.google.com with SMTP id m2so12514094pgl.5; Thu, 07 Mar 2019 15:34:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Sbop/e2Y1jW2dASCMBf3SX8kr8ytrYOuWO0KO4p5Y/M=; b=q5F3dga44lMvyyaZjlNhKfwCJGgku+TpGuBkqgL8gfpQRgqiO+Goq06MGRQ5ymzVgi OUzaWAbEFK1w1dc67AeQ6XSeNgLpKboACUplYePpEnZ9AQvYTbXwbQsHN+9WVKL568Ai e6Mi7XTRMXRCgvNW39KV6n76SG8wxx/8wfgg05QL88wagE9Gb5WHq8NJdtyyFMOF3lJx ilMt1BA3MHpixx+7L64tyOzksZtZsgQvBCCk8cYQ28GMA0k4O6RFLBd8J7rQ7JdR0Jy6 /q0/a3L7sc1GCff2H2ImMGp4FmGUQsPWTVNgoP1FqkJXJQ8PuRGf8oIy3IvPrWrMwEbm uH8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Sbop/e2Y1jW2dASCMBf3SX8kr8ytrYOuWO0KO4p5Y/M=; b=KPydGcZWFcQmttcIQZ/Sdqv7Hjzg98VIA3mCpd6Zmz9FSOFSDlgwURNOTJ+b1BSHbk Mm8KmK5+HE5nWrYT4RdN929ho1rjndw4fw1GzY/R84gQeh+HuqjXvPtMJJNSwT7bPNvn jULI2Z2Be72sBRfOzFHdBvk8BeAIdPZOBGXzASuE0SXvLbhrbclgX9jbJjwRhxlZdRKW WyRghWdosKu38gkfwU+bCs1g/SwWbNptRwwHWI7+9y19FA+EQML/6MVooG9e3E5s9FwL hhU+JzQripdaJrZwIo+ff8azpK+yYRs6TuZ6BL0z5yiNXfEp35ZBDHtN+ngiUeALyefG XP9g== X-Gm-Message-State: APjAAAX4MtNDZsBvVhEHC285/yXebdulXFM5ohgqZXK6EIqYOEs85CCc s6zPXBQGt9V2dlLzV39A9Avsf+gM X-Received: by 2002:a17:902:7b90:: with SMTP id w16mr15899508pll.228.1552001649430; Thu, 07 Mar 2019 15:34:09 -0800 (PST) Received: from localhost.localdomain ([2605:e000:d445:6a00:2097:f23b:3b8f:e255]) by smtp.gmail.com with ESMTPSA id m21sm8684866pfa.14.2019.03.07.15.34.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Mar 2019 15:34:08 -0800 (PST) From: Steve Longerbeam To: linux-media@vger.kernel.org Cc: Tim Harvey , Steve Longerbeam , stable@vger.kernel.org, Philipp Zabel , dri-devel@lists.freedesktop.org (open list:DRM DRIVERS FOR FREESCALE IMX), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v6 1/7] gpu: ipu-v3: ipu-ic: Fix saturation bit offset in TPMEM Date: Thu, 7 Mar 2019 15:33:50 -0800 Message-Id: <20190307233356.23748-2-slongerbeam@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190307233356.23748-1-slongerbeam@gmail.com> References: <20190307233356.23748-1-slongerbeam@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The saturation bit was being set at bit 9 in the second 32-bit word of the TPMEM CSC. This isn't correct, the saturation bit is bit 42, which is bit 10 of the second word. Fixes: 1aa8ea0d2bd5d ("gpu: ipu-v3: Add Image Converter unit") Signed-off-by: Steve Longerbeam Cc: stable@vger.kernel.org --- drivers/gpu/ipu-v3/ipu-ic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/ipu-v3/ipu-ic.c b/drivers/gpu/ipu-v3/ipu-ic.c index 594c3cbc8291..18816ccf600e 100644 --- a/drivers/gpu/ipu-v3/ipu-ic.c +++ b/drivers/gpu/ipu-v3/ipu-ic.c @@ -257,7 +257,7 @@ static int init_csc(struct ipu_ic *ic, writel(param, base++); param = ((a[0] & 0x1fe0) >> 5) | (params->scale << 8) | - (params->sat << 9); + (params->sat << 10); writel(param, base++); param = ((a[1] & 0x1f) << 27) | ((c[0][1] & 0x1ff) << 18) | -- 2.17.1