Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Song Liu <songliubraving@fb.com>
To:     Stanislav Fomichev <sdf@fomichev.me>
CC:     "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
        Networking <netdev@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        "Alexei Starovoitov" <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        "Kernel Team" <Kernel-team@fb.com>,
        Peter Zijlstra <peterz@infradead.org>,
        "Arnaldo Carvalho de Melo" <acme@redhat.com>,
        "jolsa@kernel.org" <jolsa@kernel.org>,
        "namhyung@kernel.org" <namhyung@kernel.org>
Subject: Re: [PATCH v7 perf,bpf 11/15] perf: add -lopcodes to feature-libbfd
Thread-Topic: [PATCH v7 perf,bpf 11/15] perf: add -lopcodes to feature-libbfd
Thread-Index: AQHU1Q95Afw72a5BokiECT48mwt8tKYA0EWAgAAFuoA=
Date:   Thu, 7 Mar 2019 23:47:02 +0000
Message-ID: <2D05DAB2-F16D-4310-9497-BC2C7CEF5B61@fb.com>
References: <20190307175810.249857-1-songliubraving@fb.com>
 <20190307175810.249857-12-songliubraving@fb.com>
 <20190307232631.GA5481@mini-arch.hsd1.ca.comcast.net>
In-Reply-To: <20190307232631.GA5481@mini-arch.hsd1.ca.comcast.net>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: fb.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-ID: <37D2E46342A8DC4BA0AA71AA6BB18281@namprd15.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 586af9cd-9c61-421a-c7b3-08d6a3573264
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Mar 2019 23:47:02.0510
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR15MB1376
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-03-07_14:,,
 signatures=0
X-Proofpoint-Spam-Reason: safe
X-FB-Internal: Safe
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Mar 7, 2019, at 3:26 PM, Stanislav Fomichev <sdf@fomichev.me> wrote:
>=20
> On 03/07, Song Liu wrote:
>> Both libbfd and libopcodes are distributed with binutil-dev/devel. When
>> libbfd presents, it is OK to assume libopcodes also presents. This has
>> been a safe assumption for bpftool.
>>=20
>> This patch adds -lopcodes to perf/Makefile.config. libopcodes will be
>> used in the next commit for bpf annotation.
>>=20
>> Signed-off-by: Song Liu <songliubraving@fb.com>
>> ---
>> tools/perf/Makefile.config | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>=20
>> diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
>> index b441c88cafa1..e0bafbc273af 100644
>> --- a/tools/perf/Makefile.config
>> +++ b/tools/perf/Makefile.config
>> @@ -701,7 +701,7 @@ else
>> endif
>>=20
>> ifeq ($(feature-libbfd), 1)
>> -  EXTLIBS +=3D -lbfd
>> +  EXTLIBS +=3D -lbfd -lopcodes
> I think you need to add -lopcodes to the other feature checks as
> well (to work on the systems which require -liberty and/or -lz for
> libfd):
>=20
> --
>=20
> diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
> index b441c88cafa1..3fa2f5d7d54f 100644
> --- a/tools/perf/Makefile.config
> +++ b/tools/perf/Makefile.config
> @@ -701,7 +701,7 @@ else
> endif
>=20
> ifeq ($(feature-libbfd), 1)
> -  EXTLIBS +=3D -lbfd
> +  EXTLIBS +=3D -lbfd -lopcodes
> else
>   # we are on a system that requires -liberty and (maybe) -lz
>   # to link against -lbfd; test each case individually here
> @@ -712,10 +712,10 @@ else
>   $(call feature_check,libbfd-liberty-z)
>=20
>   ifeq ($(feature-libbfd-liberty), 1)
> -    EXTLIBS +=3D -lbfd -liberty
> +    EXTLIBS +=3D -lbfd -lopcodes -liberty
>   else
>     ifeq ($(feature-libbfd-liberty-z), 1)
> -      EXTLIBS +=3D -lbfd -liberty -lz
> +      EXTLIBS +=3D -lbfd -lopcodes -liberty -lz
>     endif
>   endif
> endif

Good point! I will fix it in next version.=20

Thanks,
Song

>=20
>> else
>>   # we are on a system that requires -liberty and (maybe) -lz
>>   # to link against -lbfd; test each case individually here
>> --=20
>> 2.17.1