Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp5487136imb; Thu, 7 Mar 2019 17:23:06 -0800 (PST) X-Google-Smtp-Source: APXvYqy+zMe6FNC+iyX33hEVrmS5OKcrMZheJDI0UWbei9D7QZZWJVTodUzqMQ27QHQlWYyfWS1d X-Received: by 2002:a65:5844:: with SMTP id s4mr14020222pgr.77.1552008186559; Thu, 07 Mar 2019 17:23:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1552008186; cv=none; d=google.com; s=arc-20160816; b=kNNmD65AX29I1+LShMGsGxlqIcst7jooLP8q0rVbS2N/2HWN+UUiC+DzjQC+B2vy5N H2zCWpqjbWMXLtEdIQuD+oy2IOsTG9jPyqPfqVuNc8vesdO3mwAfLpIAyP2crkgMcWOl Jw1G1bwJLG+TtWAxd4i5XRqYjmK5JCfue9+bnr1Ftl/ikb5jvwVa9AOQiIP2oyxjDbgH WbRMtXSt32xUF4qqHOROhOHfuGIde5goSFYj9TmiOy7xykmIhxXKhU7A10dpAms4qR4u //JcOpjHu7Scsyo3bn9Mlkz5I5QvuESw9ZB7Cv8IfFLOQbrJ0XLthoFh2u9QPCikmGQ/ bNEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=FpXUktmzSA7xBlWHR58DhrbhIrg36FIEtlnvxkWxp10=; b=tl8Z0AY+BvJbBQPMa/CQH9CpM/YZ5Svt94uY0CLcED2CO8lM5FgIc7lyNib2UEvicQ wGzhYlFMM33QDHjrXiQ68E1AFhylPc5GiNtQakRak/gdCgeWHLL8vru5++VU0rahb7i0 DXDikN5fzfPmwbXJSdnaXJztvw4GI01RzRcTg0kWDFZ4bRyCiff9hBpjT5ubDQ2126z5 VmZeR1fBlOCTkyKES+AUioSBy1EYJRNPQL+LZYeJoEDVurVlK6TA8z1njNthoIZSbMvs 5jWKLprgz388a6jC+F8aZ+zQmp3NGAzPqhMsVD3/YNtseF9guHTxWhggpv8bh00xB/+I nNEA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@arista.com header.s=googlenew header.b=OvwgMWOx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=REJECT dis=NONE) header.from=arista.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a4si4967761pgq.471.2019.03.07.17.22.50; Thu, 07 Mar 2019 17:23:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@arista.com header.s=googlenew header.b=OvwgMWOx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=REJECT dis=NONE) header.from=arista.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726293AbfCHBVA (ORCPT + 99 others); Thu, 7 Mar 2019 20:21:00 -0500 Received: from mail-ed1-f67.google.com ([209.85.208.67]:39606 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726242AbfCHBVA (ORCPT ); Thu, 7 Mar 2019 20:21:00 -0500 Received: by mail-ed1-f67.google.com with SMTP id p27so15092110edc.6 for ; Thu, 07 Mar 2019 17:20:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=googlenew; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=FpXUktmzSA7xBlWHR58DhrbhIrg36FIEtlnvxkWxp10=; b=OvwgMWOx/FZ4Bhivgj1Sdm/i/GXWYrl6u5IvxSxE4mMX5IyNaVskLgTvvmzGLgpysJ 2ZO/dMgked0dqPYbIDLiJqhI/CVXrcX++XivL/pJRQl+qDwG0b+mvx9eW1jua2NzCHR+ rQ8U5eIgySFlHfmV4nmuv50Tb1q1vSu8VMkoC/3viSlWChwrQQzsco866vpUhMGl6zYy FBzBmyfMFnRIJPL4E65/IHxzq5KCFI8OX5kLVjDxlCVs/Nm0p/ZrPkSMToATcMG4d+nC k7FvF1WvsmSCyZC+tHN8CLN9MooPd78YT4lzpuUa/RQc7euULAGdLGcCyEpfJa1sYjvE 42Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FpXUktmzSA7xBlWHR58DhrbhIrg36FIEtlnvxkWxp10=; b=YWFTN+eclCzqgmVC+S8iu6qDPOlyIzmbbshhAEZJwoNQOj9GXKxRvl7CIjFsJoGVQp 57rGQT6J3VIA+4N/LUDT01KbM4Gr9iyPlSTTWHtYtnhhokkPeJEMFhYDYAZfjmic3rO1 yzreSkQmYREKbdZb7tEVzvUVwQUGs6Co4rEhAajCWv62VykZLbFjawLS4HLUE4kcYA1g TZDeRhH4po2r02qGmDi9q8e+FzzXCm+EFW+FFtyyrJt7VhbRxu32vDdlxQr23XTw+LuL abNFAcnxRnms7ftIfRZdED/kGU/FooTzQcLa2+cLgtm4vY55IcmbV9RiYsPDZJUExyG/ it5g== X-Gm-Message-State: APjAAAXzZono2Me1NMhTbhlKM0/xtdG8zb8ffbeLVQuk9z+KOkb7KcQR MRp+wChZvX4vSMPSp2clp6P2vKiSI/ESiQ== X-Received: by 2002:a17:906:678a:: with SMTP id q10mr9655708ejp.156.1552008058432; Thu, 07 Mar 2019 17:20:58 -0800 (PST) Received: from [10.83.36.153] ([217.173.96.166]) by smtp.gmail.com with ESMTPSA id x18sm1810269edd.4.2019.03.07.17.20.57 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Thu, 07 Mar 2019 17:20:57 -0800 (PST) Subject: Re: [PATCH 3/4] iommu/vt-d: Allow IOMMU_DOMAIN_DMA and IOMMU_DOMAIN_IDENTITY to be allocated To: James Sewart , iommu@lists.linux-foundation.org Cc: Tom Murphy , Jacob Pan , linux-kernel@vger.kernel.org, Lu Baolu References: <0F0C82BE-86E5-4BAC-938C-6F7629E18D27@arista.com> <2C75F46E-78FE-45E9-9E7D-280B3138EA13@arista.com> From: Dmitry Safonov Message-ID: <171d70d2-5988-9f25-7e2c-cddb217f63ad@arista.com> Date: Fri, 8 Mar 2019 01:20:56 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/4/19 3:46 PM, James Sewart wrote: > +static inline int domain_is_initialised(struct dmar_domain *domain) > +{ > + return domain->flags & DOMAIN_FLAG_INITIALISED; > +} Maybe check it in intel_iommu_domain_free(), eh? Thanks, Dmitry