Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 6/9] docs: Use correct list markup character
To:     "Tobin C. Harding" <tobin@kernel.org>,
        Jonathan Corbet <corbet@lwn.net>
Cc:     linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20190307211153.28400-1-tobin@kernel.org>
 <20190307211153.28400-7-tobin@kernel.org>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <f5d4469a-ab32-46cb-c1e9-16712043465b@infradead.org>
Date:   Thu, 7 Mar 2019 19:40:14 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.1
MIME-Version: 1.0
In-Reply-To: <20190307211153.28400-7-tobin@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 3/7/19 1:11 PM, Tobin C. Harding wrote:
> Sphinx uses a star not a hyphen for lists.
> 
> Use correct list markup character.
> 
> Signed-off-by: Tobin C. Harding <tobin@kernel.org>

Hi Tobin,

The blank line insertions are all that is needed.
And I have already sent a patch for that.

Also, a list can begin with any of:
"A text block which begins with a "*", "+", "-", "•", "‣", or "⁃", followed by whitespace, is a bullet list item (a.k.a. "unordered" list item)."

from http://docutils.sourceforge.net/docs/ref/rst/restructuredtext.html#bullet-lists


> ---
>  Documentation/driver-api/gpio/board.rst |  5 +++--
>  Documentation/laptops/lg-laptop.rst     | 12 ++++++------
>  2 files changed, 9 insertions(+), 8 deletions(-)
> 
> diff --git a/Documentation/driver-api/gpio/board.rst b/Documentation/driver-api/gpio/board.rst
> index a0f294e2e250..a5d5c22ab610 100644
> --- a/Documentation/driver-api/gpio/board.rst
> +++ b/Documentation/driver-api/gpio/board.rst
> @@ -204,8 +204,9 @@ between a caller and a respective .get/set_multiple() callback of a GPIO chip.
>  
>  In order to qualify for fast bitmap processing, the array must meet the
>  following requirements:
> -- pin hardware number of array member 0 must also be 0,
> -- pin hardware numbers of consecutive array members which belong to the same
> +
> +* pin hardware number of array member 0 must also be 0.
> +* pin hardware numbers of consecutive array members which belong to the same
>    chip as member 0 does must also match their array indexes.
>  
>  Otherwise fast bitmap processing path is not used in order to avoid consecutive
> diff --git a/Documentation/laptops/lg-laptop.rst b/Documentation/laptops/lg-laptop.rst
> index e486fe7ddc35..d9e560dfd045 100644
> --- a/Documentation/laptops/lg-laptop.rst
> +++ b/Documentation/laptops/lg-laptop.rst
> @@ -9,12 +9,12 @@ Hotkeys
>  -------
>  
>  The following FN keys are ignored by the kernel without this driver:
> -- FN-F1 (LG control panel)   - Generates F15
> -- FN-F5 (Touchpad toggle)    - Generates F13
> -- FN-F6 (Airplane mode)      - Generates RFKILL
> -- FN-F8 (Keyboard backlight) - Generates F16.
> -  This key also changes keyboard backlight mode.
> -- FN-F9 (Reader mode)        - Generates F14
> +
> +* FN-F1 (LG control panel)   - Generates F15
> +* FN-F5 (Touchpad toggle)    - Generates F13
> +* FN-F6 (Airplane mode)      - Generates RFKILL
> +* FN-F8 (Keyboard backlight) - Generates F16 (This key also changes keyboard backlight mode)
> +* FN-F9 (Reader mode)        - Generates F14
>  
>  The rest of the FN key work without a need for a special driver.
>  
> 


-- 
~Randy