Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <6f6bf5b4cfe309914c6f533518ecf5e497f1bd73.camel@linux.intel.com>
Subject: Re: [PATCH v4 16/17] kvm: x86: Add support IA32_CORE_CAPABILITY MSR
From:   Xiaoyao Li <xiaoyao.li@linux.intel.com>
To:     Paolo Bonzini <pbonzini@redhat.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        Dave Hansen <dave.hansen@intel.com>,
        Ashok Raj <ashok.raj@intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ravi V Shankar <ravi.v.shankar@intel.com>
Cc:     linux-kernel <linux-kernel@vger.kernel.org>, x86 <x86@kernel.org>,
        kvm@vger.kernel.org
Date:   Fri, 08 Mar 2019 16:03:24 +0800
In-Reply-To: <9edabe63-b77f-d9d8-d573-7e46d944b972@redhat.com>
References: <1551494711-213533-1-git-send-email-fenghua.yu@intel.com>
         <1551494711-213533-17-git-send-email-fenghua.yu@intel.com>
         <74630db9-2a83-cd72-73f6-8b9ef9b07313@redhat.com>
         <3ced155309e5c3a01815ec39bb69016ca06316b6.camel@linux.intel.com>
         <9edabe63-b77f-d9d8-d573-7e46d944b972@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 2019-03-08 at 08:54 +0100, Paolo Bonzini wrote:
> On 08/03/19 07:10, Xiaoyao Li wrote:
> > > so that non-virtualizable features are hidden and
> > > 
> > > 	if (boot_cpu_has(X86_FEATURE_SPLIT_LOCK_DETECT))
> > > 		data |= CORE_CAP_SPLIT_LOCK_DETECT;
> > > 
> > > so that userspace gets "for free" the FMS list that will be added
> > > later to the kernel.
> > 
> > I think it's redundant. Because there is no case that
> > rdmsrl_safe(MSR_IA32_CORE_CAPABILITY, &data) shows no split lock detection
> > while
> > boot_cpu_has(X86_FEATURE_SPLIT_LOCK_DETECT).
> 
> There will be when the kernel will add a list of FMS values that have
> split lock detection but lack the core capabilities MSR.  Or at least
> that is what Fenghua said in the cover letter.
> 
> Paolo

Got it.
Thanks for your explanation.