Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp5809449imb; Fri, 8 Mar 2019 02:51:22 -0800 (PST) X-Google-Smtp-Source: APXvYqxumvePKRCV9klr8oGz4FL3/otUpJ1lGMXyPTo77wZI1sflpMIOYlivUhz9BOvQoogMPUdC X-Received: by 2002:a63:f343:: with SMTP id t3mr15804360pgj.108.1552042282889; Fri, 08 Mar 2019 02:51:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1552042282; cv=none; d=google.com; s=arc-20160816; b=oVyreClnPbyGlrpHw6kuGs9IpcSON1wWET1l05XqOoa+uQwrTrjQ+b14bourhirvGi BPQIQaxnia9sb/lYSvkhLwozMChEOAAvJu88mDlWxJSnuDN+cXl88jWU6DbecINKH7Nz Skf7xMgPuQdyyvPaHxjnJkUcjcub3J4mxhKHirv/QASZJN6YKDnkCd1C/nthNPdhf8yh 1AB+SdFLIA3bVrWTJ/pzsJ27BKm+M3XmoK2sOiOWslx6AmOXIBWqW05wLhf6e+dfFxsQ MY/pTNe7z0mMjRPBUgK5scaXUX10mk8+MFGFbqZf/OpZTl/L9ywLn0C0hxO6fLZRrKQd Cxpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=D9sfN8Ps844Ftvnk9D00QkzrCYeHCGbP93df6w0yxfU=; b=Z3lUtKu5TORi4mPj7U0TxpQCmjkzcscuUTypuzc3viL5/tueKPof2oKG+IJSUyqN3R F8e2Z16aXk+vVAnbCN0UurtthXMbYiJS4LO2GzM2Mpl50nNvvGmQYMGoxmsD2a9x270U Gg6QPO7tFVsrlmkyk6M174MM4Fo0nS30YeBiM7l9CDpAm3dZWcUVsIDqqzMxyljXG/Aa E9U23SKy2hx9tKuoYroJeXwLqGnmGVdG9zvxDFXygumFK//i2Skt6Lr0r1HUesfjSOHV esrapCrqs9bHlLqTk4Ahi7cJ9g6j/jfkfvvVzcyb3hbvCIPQSAkDdBYSOIgCNHCn6lC/ 12bQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o24si6243456pgh.114.2019.03.08.02.51.07; Fri, 08 Mar 2019 02:51:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726444AbfCHKum (ORCPT + 99 others); Fri, 8 Mar 2019 05:50:42 -0500 Received: from Chamillionaire.breakpoint.cc ([146.0.238.67]:34088 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726249AbfCHKum (ORCPT ); Fri, 8 Mar 2019 05:50:42 -0500 Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.89) (envelope-from ) id 1h2D5L-0004k5-Dd; Fri, 08 Mar 2019 11:50:39 +0100 Date: Fri, 8 Mar 2019 11:50:39 +0100 From: Florian Westphal To: Dmitrii Tcvetkov Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: NULL pointer dereference in nft_set_elem_destroy() Message-ID: <20190308105039.xmf3ho3nixhfnnmh@breakpoint.cc> References: <20190308131746.5899877a@fire.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190308131746.5899877a@fire.localdomain> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dmitrii Tcvetkov wrote: > After upgrade to 5.0 on XPS 13 9360 I get NULL pointer dereference in > dmesg (attached). Distro is Arch Linux, kernel is built with custom > config (attached), but distro kernel[1] reproduces the issue on the > laptop as well. > > Bisect led me to commit f6ac858589768 (netfilter: nf_tables: unbind set > in rule from commit path), bisect log attached. The commit doesn't > revert cleanly on top of v5.0, and conflicts aren't trivial for me to > resolve. Please see https://patchwork.ozlabs.org/patch/1053232/ this probably resolves this crash as well.