Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp5890846imb; Fri, 8 Mar 2019 04:52:44 -0800 (PST) X-Google-Smtp-Source: APXvYqyjLGvgB3mZkB27yWy/SOzGt2PAXvat/36oNTynUO0eX6zkJtEpXz8z6tBLQ+FwOCjgFnRc X-Received: by 2002:a17:902:7b90:: with SMTP id w16mr19018130pll.228.1552049564579; Fri, 08 Mar 2019 04:52:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1552049564; cv=none; d=google.com; s=arc-20160816; b=Slw5ZmM0b0hQADTocvNH4dCB6s3FYjCIrrbtUqQ7a8egcZuDLsgeLqrla1xqyIG/ge oIBcVlYXgsOt87C/m29fKMi7k5ldI06R+uAwjgQ88Zdy4UK3I4cHhNXtCJxdOzryQTfd grFjFBP34f9k86YiXaT/lv4Zss7mLeUdaErBbdNs06OylNg5HpaiDzokuvS5RVFrsAsm FRWtcqqJKvIvH8XpfC3ET3YgMsDabSjiVKvcvKYJht38u8Qy8wXa6rrYr9NmAEEjiABo 3Gz0yam96bJKKExc6SD8lLrR8KqWz3pDw5iZSHNwwSQRRA9GTaTA3qt3QNQrNugiqgUa zphg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=+yWpPktJpzCVVIRKDUQVjchBYV9hcgsFzs3eMcEnZLw=; b=ZYqhPY06OdyTIEdYaUQhP8A3zNRfxOT5wAewUfVRhG64HVt4Ov5zsMKfe/i2JdC8kL HDmXq9lmWjYjetC/+pACnGJ7dgTs8Erh+Jb7J2aOMh/tpeJudPAXUSA2JY1tjfALrpX7 EH7hBRYXtPxMb/LqBQyeAqpxZW4VC4cw/0Obl4H9Z0OzE2G8KE7nbGQiJyaJx+B9iH7b cDrGW4ziWXwFGJMVTC+Gz5KqG0D79ZVhjfMr+lzF9VneuRZlbg9RxlxqiRC+Nyx5fQw1 M6u6RnlMrlmyX9NqAp78+mpGwp6KKp3KLYEQohBXnQZzQC+Mep990JaCuZaNMUHZrKpd Gt6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=lBq3JwC8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r201si6144732pgr.445.2019.03.08.04.52.29; Fri, 08 Mar 2019 04:52:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=lBq3JwC8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726792AbfCHMvn (ORCPT + 99 others); Fri, 8 Mar 2019 07:51:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:54934 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726610AbfCHMvl (ORCPT ); Fri, 8 Mar 2019 07:51:41 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A49F720684; Fri, 8 Mar 2019 12:51:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552049500; bh=fVkrHAjwHzWflKEjrmMLZbrRPF5MAAHMs6qY41OOG2I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lBq3JwC8jlleOXxCyGoJ+V62NZZW8cfGkCw/NErwEhkv9McpFXzD0joVV2dA4XGhT QofypIb7kTF1sZXvLxvUtg0Ey23rVZqsznYFl2kqMyaAaml6slWHKf8eio3RXxd7Ep PGKWZZtTnmET5BF/KOOSxkIWoLzoxbUw+jAJNM0k= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kavya Sree Kotagiri , Steen Hegelund , "David S. Miller" Subject: [PATCH 5.0 21/46] net: mscc: Enable all ports in QSGMII Date: Fri, 8 Mar 2019 13:49:54 +0100 Message-Id: <20190308124903.630465180@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190308124902.257040783@linuxfoundation.org> References: <20190308124902.257040783@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 5.0-stable review patch. If anyone has any objections, please let me know. ------------------ From: Kavya Sree Kotagiri [ Upstream commit 084e5bb16bd7dc2b551bbd9fb358bf73e03ee8d8 ] When Ocelot phy-mode is QSGMII, all 4 ports involved in QSGMII shall be kept out of reset and Tx lanes shall be enabled to pass the data. Fixes: a556c76adc05 ("net: mscc: Add initial Ocelot switch support") Signed-off-by: Kavya Sree Kotagiri Signed-off-by: Steen Hegelund Co-developed-by: Steen Hegelund Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/mscc/ocelot_board.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) --- a/drivers/net/ethernet/mscc/ocelot_board.c +++ b/drivers/net/ethernet/mscc/ocelot_board.c @@ -267,6 +267,7 @@ static int mscc_ocelot_probe(struct plat struct phy *serdes; void __iomem *regs; char res_name[8]; + int phy_mode; u32 port; if (of_property_read_u32(portnp, "reg", &port)) @@ -292,11 +293,11 @@ static int mscc_ocelot_probe(struct plat if (err) return err; - err = of_get_phy_mode(portnp); - if (err < 0) + phy_mode = of_get_phy_mode(portnp); + if (phy_mode < 0) ocelot->ports[port]->phy_mode = PHY_INTERFACE_MODE_NA; else - ocelot->ports[port]->phy_mode = err; + ocelot->ports[port]->phy_mode = phy_mode; switch (ocelot->ports[port]->phy_mode) { case PHY_INTERFACE_MODE_NA: @@ -304,6 +305,13 @@ static int mscc_ocelot_probe(struct plat case PHY_INTERFACE_MODE_SGMII: break; case PHY_INTERFACE_MODE_QSGMII: + /* Ensure clock signals and speed is set on all + * QSGMII links + */ + ocelot_port_writel(ocelot->ports[port], + DEV_CLOCK_CFG_LINK_SPEED + (OCELOT_SPEED_1000), + DEV_CLOCK_CFG); break; default: dev_err(ocelot->dev,