Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp5893420imb; Fri, 8 Mar 2019 04:56:49 -0800 (PST) X-Google-Smtp-Source: APXvYqwDRojsKAUK3IWMh6EPZAi1fy7lHNPbyTjpKcrkfurw9Clh1L+8FU1OxyBclKUCEzKkKDLf X-Received: by 2002:a62:4743:: with SMTP id u64mr17962196pfa.95.1552049809070; Fri, 08 Mar 2019 04:56:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1552049809; cv=none; d=google.com; s=arc-20160816; b=CL4WbhUz+Oil4lcpC2MRi9l5C+vWX61IaVGtO5OjsS4WoW6WLtfC+6R4K95YfYkMBC xMws66Sq5qj7OHOkCQ7n+i/an1lDcgLp9i5QLlqnXurUjQDOAb+lGrJbaz0sklSSMZVa 4D4M0aCX5eYToL01yeBlmaZTGhP6ZGGRTP13lP2HSmL9CGXEa77pVXesc03+QwieAblN WQpP3tUKctav1IVTPHEe9vHc5hXcgNw/86xA4AbvlGGlJgUNuH3e6wHcPehdRLOE4aMq hL7c7w9r6PWncrveoA7rP9EhS7ikGraVYKcrwg5RHMAqbQwWi5S4Alr3NrFuSX7Gy5Ww BGCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=BUwBWn7v3S95ocNHTrLxsEGBMwYzL7OhL7IxLLwaZ0s=; b=VOJvX9aq8OfhdakNnlX0+ud5LgzochnueDPdS3m4LXle2UUOf/vzvmnSSYU1F4NWgd rphhqqCWy5+IEf9Pu42EkADU+gX7OBNTcHKoq0yFhRlJKAT1NPseXCzYK38a50DoLbyM dPsR+JLKs78tZ7XQWmgqx8JmyCretTYRcivLeHVJTyTm+FWwvguP0dIy5gkVckf3Grbp cgrbpkcR/+91gZI9+dwBeG0f5JQfJYErXOrPnig3TIZzWgqm0XJZBpdLZAWsLotaBnwb D6IYRmE4dS+J5ChpsaxZh0NQASljUEpsaqU9RwXWPgrnFlVJEuAiRhibC2N5JW968hBE CHRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=tWOUWAYr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d18si6717520pll.436.2019.03.08.04.56.33; Fri, 08 Mar 2019 04:56:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=tWOUWAYr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727317AbfCHMyS (ORCPT + 99 others); Fri, 8 Mar 2019 07:54:18 -0500 Received: from mail.kernel.org ([198.145.29.99]:58044 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726908AbfCHMyQ (ORCPT ); Fri, 8 Mar 2019 07:54:16 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E76BA20449; Fri, 8 Mar 2019 12:54:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552049655; bh=sBjtU5TT1V1Gzcn9lLKsjz8nlrnXqRcMXeXUwu45toQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tWOUWAYrf9t6wgLZDNxJmk9lRYlpfmiGamfal5VV4bimeh/V3iwl3PRxr3hdYxOf/ 7G00VUN8Qv+pmCUDNXlgtdZJmivms14WJ/1+85i9J69L8yj9r0Rc6apSRdrE9PmCre VqHKK5qZ+lWL3I9essmyGzT7P9xMPHWTYoWtiXM0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kavya Sree Kotagiri , Steen Hegelund , "David S. Miller" Subject: [PATCH 4.20 22/76] net: mscc: Enable all ports in QSGMII Date: Fri, 8 Mar 2019 13:49:34 +0100 Message-Id: <20190308124915.561260801@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190308124914.789210760@linuxfoundation.org> References: <20190308124914.789210760@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.20-stable review patch. If anyone has any objections, please let me know. ------------------ From: Kavya Sree Kotagiri [ Upstream commit 084e5bb16bd7dc2b551bbd9fb358bf73e03ee8d8 ] When Ocelot phy-mode is QSGMII, all 4 ports involved in QSGMII shall be kept out of reset and Tx lanes shall be enabled to pass the data. Fixes: a556c76adc05 ("net: mscc: Add initial Ocelot switch support") Signed-off-by: Kavya Sree Kotagiri Signed-off-by: Steen Hegelund Co-developed-by: Steen Hegelund Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/mscc/ocelot_board.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) --- a/drivers/net/ethernet/mscc/ocelot_board.c +++ b/drivers/net/ethernet/mscc/ocelot_board.c @@ -266,6 +266,7 @@ static int mscc_ocelot_probe(struct plat struct phy *serdes; void __iomem *regs; char res_name[8]; + int phy_mode; u32 port; if (of_property_read_u32(portnp, "reg", &port)) @@ -291,11 +292,11 @@ static int mscc_ocelot_probe(struct plat if (err) return err; - err = of_get_phy_mode(portnp); - if (err < 0) + phy_mode = of_get_phy_mode(portnp); + if (phy_mode < 0) ocelot->ports[port]->phy_mode = PHY_INTERFACE_MODE_NA; else - ocelot->ports[port]->phy_mode = err; + ocelot->ports[port]->phy_mode = phy_mode; switch (ocelot->ports[port]->phy_mode) { case PHY_INTERFACE_MODE_NA: @@ -303,6 +304,13 @@ static int mscc_ocelot_probe(struct plat case PHY_INTERFACE_MODE_SGMII: break; case PHY_INTERFACE_MODE_QSGMII: + /* Ensure clock signals and speed is set on all + * QSGMII links + */ + ocelot_port_writel(ocelot->ports[port], + DEV_CLOCK_CFG_LINK_SPEED + (OCELOT_SPEED_1000), + DEV_CLOCK_CFG); break; default: dev_err(ocelot->dev,