Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp5907108imb; Fri, 8 Mar 2019 05:13:29 -0800 (PST) X-Google-Smtp-Source: APXvYqwOPXIvs8unYQkihoHIyVhPTkJHqm64NlhTDjYwLZ/ZxkvpEV34isqV7iXbHbuZn8K5H5Uh X-Received: by 2002:aa7:924e:: with SMTP id 14mr18663086pfp.30.1552050809572; Fri, 08 Mar 2019 05:13:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1552050809; cv=none; d=google.com; s=arc-20160816; b=DzMEUQrSf0xM1APuFFcfAh+TwIzEEoIKqfbKeub0vYk1OMpvbac+nKU7GWddSwTRue QOUBMbH7Dm4EZC4WrN139znVihKd7ljFWsFAOKip8bfEvL7PY9qWqq9vtd5N7Vv5kA08 ZFTMzxBXPH5SogrCkApphNOkt8yPB7ONIi4OwHGBjSdoXYK3TgvyR/lW9yECejj+TLs3 bexVj8Vo9JPEkN80VU5SVEbwpridYoTwmydsokWHvlGdE73Z1dcej+/W5jdREmrlghs5 LzCWxkF/yVExQDqFfn92wMWm2PceWjfSc6IyTIJqhONehgMtKKaOGmdA9+oenC2NQSC/ jk8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=VwHZ2RcHyB3L2CFP0cLk9mi0QfUja8ROWNfLTYhZwh0=; b=f135pMUW4Xrkq0D5oHAHAy6xZGyR9G1l9K7g6uS20T8NUBo0FU2oAnpSbfbUFMvTzN 1C9zNy5kZAHSCh/hpbTriM/M1ugAC0czRPi0bK4GdrSeY5NqEijQe3yQQDudKIxmFZEn WjaN/3fjKO+ectGEry9lMQVGPw9OOJ6s4lfsH5I9OTHpGULycXm1QrSbqH59bmlvS638 KZ8ZrUhmFlgvo9TLN4XISZSfyMyLTqe7qN8SY8jvj+4paa/H+OYF2E7ufCxJuznRhW4Y JfiB7Y+WcMJtblY5Cc5aGscwFAXOGQOTCDGKoMgALuIAUvJ0MQPQlBsIscusG6hBDu5t xxJw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h12si2141165pgs.207.2019.03.08.05.13.14; Fri, 08 Mar 2019 05:13:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726637AbfCHNMv (ORCPT + 99 others); Fri, 8 Mar 2019 08:12:51 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:55836 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726419AbfCHNMr (ORCPT ); Fri, 8 Mar 2019 08:12:47 -0500 Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx08-00178001.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x28DBGPF030724; Fri, 8 Mar 2019 14:12:37 +0100 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx08-00178001.pphosted.com with ESMTP id 2qyhknnvgc-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 08 Mar 2019 14:12:37 +0100 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 301B831; Fri, 8 Mar 2019 13:12:37 +0000 (GMT) Received: from Webmail-eu.st.com (Safex1hubcas22.st.com [10.75.90.92]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 138EB5571; Fri, 8 Mar 2019 13:12:37 +0000 (GMT) Received: from SAFEX1HUBCAS23.st.com (10.75.90.47) by Safex1hubcas22.st.com (10.75.90.92) with Microsoft SMTP Server (TLS) id 14.3.361.1; Fri, 8 Mar 2019 14:12:36 +0100 Received: from lmecxl0923.lme.st.com (10.48.0.237) by webmail-ga.st.com (10.75.90.48) with Microsoft SMTP Server (TLS) id 14.3.361.1; Fri, 8 Mar 2019 14:12:36 +0100 From: Ludovic Barre To: Mark Brown , Marek Vasut , Boris Brezillon , Rob Herring CC: Maxime Coquelin , Alexandre Torgue , , , , , , , Ludovic Barre Subject: [PATCH 1/2] spi: spi-mem: stm32-qspi: avoid memory corruption at low frequency Date: Fri, 8 Mar 2019 14:12:20 +0100 Message-ID: <1552050741-27739-2-git-send-email-ludovic.Barre@st.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1552050741-27739-1-git-send-email-ludovic.Barre@st.com> References: <1552050741-27739-1-git-send-email-ludovic.Barre@st.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.48.0.237] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-03-08_11:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ludovic Barre This patch solves a memory corruption seen at 8 MHz. To avoid such issue, timeout counter is disabled. Signed-off-by: Ludovic Barre --- drivers/spi/spi-stm32-qspi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/spi/spi-stm32-qspi.c b/drivers/spi/spi-stm32-qspi.c index 3b2a9a6..7354f9d 100644 --- a/drivers/spi/spi-stm32-qspi.c +++ b/drivers/spi/spi-stm32-qspi.c @@ -76,7 +76,6 @@ #define QSPI_PSMAR 0x28 #define QSPI_PIR 0x2c #define QSPI_LPTR 0x30 -#define LPTR_DFT_TIMEOUT 0x10 #define STM32_QSPI_MAX_MMAP_SZ SZ_256M #define STM32_QSPI_MAX_NORCHIP 2 @@ -372,8 +371,7 @@ static int stm32_qspi_setup(struct spi_device *spi) flash->presc = presc; mutex_lock(&qspi->lock); - writel_relaxed(LPTR_DFT_TIMEOUT, qspi->io_base + QSPI_LPTR); - cr = FIELD_PREP(CR_FTHRES_MASK, 3) | CR_TCEN | CR_SSHIFT | CR_EN; + cr = FIELD_PREP(CR_FTHRES_MASK, 3) | CR_SSHIFT | CR_EN; writel_relaxed(cr, qspi->io_base + QSPI_CR); /* set dcr fsize to max address */ -- 2.7.4