Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp5985021imb; Fri, 8 Mar 2019 06:55:26 -0800 (PST) X-Google-Smtp-Source: APXvYqzL7DT15tUzjXonIiaLgPkAigTcLnCGV2p1EvgAMc4NrGlQwDSL/JqLkRfdDLm5fZq5t+Yq X-Received: by 2002:a17:902:31a4:: with SMTP id x33mr18816614plb.198.1552056926637; Fri, 08 Mar 2019 06:55:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1552056926; cv=none; d=google.com; s=arc-20160816; b=qOcKqpm4B6c4YXcoyCFfPI9bQhvCrkNi8nT+0HApakmFO4PwI0PJxRaJyxFqBPQqQY dNKqzZ3oBhY9vXjOjHNp2GV2V4DxrGMNF4IP2/ElLJg+/+Fwtz51THbggo3iyiesv+CA FN7iUxOXcR4wql94evoON7qw+cbKmyr4JMtWQZeXQpzNFg73AyRx1TxT8ba8JdTP+Q+I 524Fylsozl2k7WgBRr78ZDyF9zjvrUZai1nTepSXdxIypxQoL/e54soJu5xMleWitvoW n5e5s2G9JSsJXlIrM4Kr7h79UD5W+vhyEAU+F1uhQ3i23+VhRxyfNkRlaNWBcWL20p6d yIng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=RcLErWlpVnzjbk16Fif2980UHUZCiY+V5qDVG0oGw3I=; b=LLHsBBHoCxMrDBDvG5dWuMNXLo6exrNPJy7bg+bXK7X1y9mApp/vYXwX+b2SFMEKCX Dygn9Z8QCeQLfaq+Bk1MSOfK6kUJHqVlA/grBu9FhwNEPL9cc3QWtmEaSLJJmtSk7drl 4UTcyt1cn+hLOueuoUzNO2vvb4E+MN/mbigQ3YhcBZUyZ5CaazkhkuHjSpesV72ky7AS Hpy3h14l2sz1QmvCFiDyhrKiaOL+xH1Gc4xqvH45eL3pUlQaYu3qa5YH1MuXvYJsyZ/h 1v/QEreZzMrbUcAw6khClHuGAeyYHKdK+jcpCVnkOvNnEqf/Wvu1khpCaY1YgOmwcYz4 p1IA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JrtZS4hJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l17si6086438pgk.348.2019.03.08.06.55.10; Fri, 08 Mar 2019 06:55:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JrtZS4hJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726839AbfCHOyg (ORCPT + 99 others); Fri, 8 Mar 2019 09:54:36 -0500 Received: from mail.kernel.org ([198.145.29.99]:43638 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726631AbfCHOyg (ORCPT ); Fri, 8 Mar 2019 09:54:36 -0500 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CAD212146E for ; Fri, 8 Mar 2019 14:54:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552056875; bh=4aboBRavMPzk24ub+4zG7EAt7vahfO4a4nnF/qW4njE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=JrtZS4hJE9qP/CD1btG871lfsSxoOqdTnJLVwTcj3iYSb34kivRoz1tcAijpUDBNB kAuUfYBggounFFCQciRAb9MK+5llIEWMIobrFK7z0DC9VpRutF2YPwO7HvIlSvOU4C equays8Z3r2zyhvLxvBOV6mIKt9dweyGPBowMrcs= Received: by mail-qt1-f179.google.com with SMTP id d18so21437270qtg.12 for ; Fri, 08 Mar 2019 06:54:34 -0800 (PST) X-Gm-Message-State: APjAAAV0hrOAfs21n67AnXk/GiSgMlbWz4bMR0+iVacu4MBW0iHh7jg1 z8IJFkdsFK5O75xAafvxuce7KMAxS/5G4vKszQ== X-Received: by 2002:ac8:3015:: with SMTP id f21mr2248856qte.144.1552056874013; Fri, 08 Mar 2019 06:54:34 -0800 (PST) MIME-Version: 1.0 References: <1549022873-40549-1-git-send-email-narmstrong@baylibre.com> <1549022873-40549-2-git-send-email-narmstrong@baylibre.com> <36800d4e-0bb7-378c-e512-5ae02406865b@baylibre.com> In-Reply-To: <36800d4e-0bb7-378c-e512-5ae02406865b@baylibre.com> From: Rob Herring Date: Fri, 8 Mar 2019 08:54:22 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/8] drm/bridge: dw-hdmi: Add SCDC and TMDS Scrambling support To: Neil Armstrong Cc: Andrzej Hajda , Laurent Pinchart , Philipp Zabel , Sandy Huang , "heiko@sntech.de" , Maxime Ripard , "linux-kernel@vger.kernel.org" , dri-devel , Nickey Yang , linux-amlogic@lists.infradead.org, Huicong Xu Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 8, 2019 at 2:05 AM Neil Armstrong wrote: > > Hi Rob, > > On 08/03/2019 00:13, Rob Herring wrote: > > On Fri, Feb 1, 2019 at 6:08 AM Neil Armstrong wrote: > >> > >> Add support for SCDC Setup for TMDS Clock > 3.4GHz and enable TMDS > >> Scrambling when supported or mandatory. > >> > >> This patch also adds an helper to setup the control bit to support > >> the high TMDS Bit Period/TMDS Clock-Period Ratio as required with > >> TMDS Clock > 3.4GHz for HDMI2.0 3840x2160@60/50 modes. > >> > >> These changes were based on work done by Huicong Xu > >> and Nickey Yang to support HDMI2.0 modes > >> on the Rockchip 4.4 BSP kernel at [1] > >> > >> [1] https://github.com/rockchip-linux/kernel/tree/release-4.4 > >> > >> Cc: Nickey Yang > >> Cc: Huicong Xu > >> Signed-off-by: Neil Armstrong > >> Tested-by: Heiko Stuebner > >> Reviewed-by: Andrzej Hajda > >> --- > >> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 85 ++++++++++++++++++++++++++++++- > >> drivers/gpu/drm/bridge/synopsys/dw-hdmi.h | 1 + > >> include/drm/bridge/dw_hdmi.h | 1 + > >> 3 files changed, 85 insertions(+), 2 deletions(-) > > > > This commit in drm-misc-next is breaking booting on the Rock960. I > > have FB and fbcon enabled. The boot hangs after this message: > > > > [ 3.012334] [drm:rockchip_drm_fbdev_create] FB [1920x1080]-24 > > kvaddr=(____ptrval____) offset=0 size=8294400 > > Could you give more details on the tree used ? did you bisect to find this commit ? As I said above, drm-misc-next (from drm-misc tree) is the branch. I bisected between it and v5.0. Reverting it fixes booting. Rob