Received: by 2002:ac0:aed5:0:0:0:0:0 with SMTP id t21csp6032462imb; Fri, 8 Mar 2019 07:52:19 -0800 (PST) X-Google-Smtp-Source: APXvYqzz/KBh7rvWyL4A6VwlQ5p0IxgHbwAKRHD8lS8Kieh4bPtDhXkkaimYMZ/R3YULHVtsea3J X-Received: by 2002:a17:902:ea06:: with SMTP id cu6mr4285471plb.187.1552060339433; Fri, 08 Mar 2019 07:52:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1552060339; cv=none; d=google.com; s=arc-20160816; b=0QcjVRDi5N5LSU8C8EiDFkeLEOB2usdz+TfMqiyeXMWI2gveZzBANvYDs+rFlpSXPK 7zbUL7nfxIkDuMjoroS7jUv2iqy3eaqJK+ezZbwCEGJywnyqwyuuxvQ1steT3erXpnrf iJduQClqPBseBPtInHdQZOzHcvrK/WuAPvJK53M5fG5YsWCnobA536GXcldl5hUb3tGb evMjp9GP/LgUYsN1v6a+jnvUjJOzZ9qm5Y1i9bEZT+v8uq+NcVyDOFvqAU2hTU0pNTPv HZZhMpZKciWYz9JGTvhHnE3QHtUlNQANgDz3tsMiG22jhut4cglZBFc+vvjUnIGpYHwJ UV0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=c8E4DRPcHDKQkkV+P4XxVrzS/zsdFTWq8wyh48hUGBs=; b=WkElH04gALj5wCIuNWKM3vQBSj2mTIR9/qDjfjqgW+7LZRBSPJShj/a5NnvQqsxU4X un4cJ2XQ6jdahb0KTUDOMpzO0/7gcOKmT6HNyMHBoziKInkl/zGR8DovZXp+kkPLRqFH GpT/AlMdJ/5oOubJ4bZcm0tsGV8DMydL7ey4Rzp5L3ImmsA3E0z92hg3V2zLMzvVbSeu ZlaXxR8nLsg/5AabJ9FqxUG0O84U9LT2IdpucBRokSFh7EDN0UUPAqh+ze+OkUmxvIog 6diaI0Li+kTeObi6fw2ZZQL57NG0JMt1wZITogdU8GySH+70827n2QoZEyvkwD8Mfvoc 82HA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p10si7030483pls.296.2019.03.08.07.52.03; Fri, 08 Mar 2019 07:52:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726545AbfCHPvD (ORCPT + 99 others); Fri, 8 Mar 2019 10:51:03 -0500 Received: from verein.lst.de ([213.95.11.211]:54709 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726446AbfCHPvC (ORCPT ); Fri, 8 Mar 2019 10:51:02 -0500 Received: by newverein.lst.de (Postfix, from userid 2407) id B0FB368C4E; Fri, 8 Mar 2019 16:50:56 +0100 (CET) Date: Fri, 8 Mar 2019 16:50:56 +0100 From: Christoph Hellwig To: Al Viro Cc: Linus Torvalds , Eric Dumazet , David Miller , Jason Baron , kgraul@linux.ibm.com, ktkhai@virtuozzo.com, kyeongdon kim , Linux List Kernel Mailing , Netdev , pabeni@redhat.com, syzkaller-bugs@googlegroups.com, Cong Wang , Christoph Hellwig , zhengbin , bcrl@kvack.org, linux-fsdevel , linux-aio@kvack.org, houtao1@huawei.com, yi.zhang@huawei.com, avi@scylladb.com Subject: Re: [PATCH 1/8] aio: make sure file is pinned Message-ID: <20190308155056.GA20563@lst.de> References: <20190307000316.31133-1-viro@ZenIV.linux.org.uk> <20190307004159.GY2217@ZenIV.linux.org.uk> <20190307004828.GZ2217@ZenIV.linux.org.uk> <20190307012036.GA2217@ZenIV.linux.org.uk> <20190308033650.GD2217@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190308033650.GD2217@ZenIV.linux.org.uk> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 08, 2019 at 03:36:50AM +0000, Al Viro wrote: > See vfs.git#work.aio; the crucial bits are in these commits: > keep io_event in aio_kiocb > get rid of aio_complete() res/res2 arguments > move aio_complete() to final iocb_put(), try to fix aio_poll() logics > The first two are preparations, the last is where the fixes (hopefully) > happen. Looks sensible. I'll try to run the tests over it, and I've added Avi so that maybe he can make sure that scylladb is also happy with it, that was usually the best way to find aio poll bugs..