Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Eric Anholt <eric@anholt.net>
To:     Dave Emett <david.emett@broadcom.com>
Cc:     dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Thomas Spurden <thomas.spurden@broadcom.com>
Subject: Re: [PATCH v3 1/3] drm/v3d: Add support for V3D v4.2.
In-Reply-To: <CAApk1dVubN7ME6GNuedGmF4V1qnH_JYnSEvFffAzwsMFaZNmgg@mail.gmail.com>
References: <20190220233658.986-1-eric@anholt.net> <CAApk1dVubN7ME6GNuedGmF4V1qnH_JYnSEvFffAzwsMFaZNmgg@mail.gmail.com>
User-Agent: Notmuch/0.22.2+1~gb0bcfaa (http://notmuchmail.org) Emacs/25.2.2 (x86_64-pc-linux-gnu)
Date:   Fri, 08 Mar 2019 08:51:29 -0800
Message-ID: <87o96l71im.fsf@anholt.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha512; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=-=-=
Content-Type: text/plain

Dave Emett <david.emett@broadcom.com> writes:

> Sorry, a few things I thought of after sending the Reviewed-by email...
>
>> +       v3d->reset = devm_reset_control_get_exclusive(dev, NULL);
>> +       if (IS_ERR(v3d->reset)) {
>> +               ret = PTR_ERR(v3d->reset);
>> +
>> +               if (ret == -EPROBE_DEFER)
>> +                       goto dev_free;
> Might be preferable to make this explicitly check against the
> not-found error code (whatever that is)? As in if (not found)
> <fallback to bridge> else <return error code>. Similarly...

You won't have both a bridge and an external reset controller in the DT,
so I'm not clear on what functional change you're looking for.  You're
just concerned about what the return code from this function is?
-EPROBE_DEFER is the only one that matters from a probe, really.

>> +       if (platform_get_irq(v3d->pdev, 1) < 0) {
> This should probably explicitly check for not-found rather than any
> error. As-is, we might silently go down the single-interrupt-line path
> on a platform with 2 interrupt lines if platform_get_irq(v3d->pdev, 1)
> hits some other error.

If I do the -EPROBE_DEFER check here, will that be good enough for you?

>> +               ret = devm_request_irq(v3d->dev, platform_get_irq(v3d->pdev, 0),
>> +                                      v3d_hub_irq, IRQF_SHARED,
>> +                                      "v3d_hub", v3d);
>> +               ret = devm_request_irq(v3d->dev, platform_get_irq(v3d->pdev, 1),
>> +                                      v3d_irq, IRQF_SHARED,
>> +                                      "v3d_core0", v3d);
> Not introduced by this change, but return value from first
> devm_request_irq ignored here?

True, but let's handle separate bugs separately.

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlyCnZEACgkQtdYpNtH8
nugEvxAAltLPLd8xS5BNY9rfZ4+cc8BytbXEs7GG4DDEg0Q7jwwhfDwt2gu5JBtb
H1wBWMQe3xAZGf8KRn1YM9/0mC0jL4TRQMA3s84rBdIIbLKIFMI2kHtGFg+b7hKb
hjFf1+57u4fq1rrey7Srtrvuo3bN/d37AWsXq9iWEaXCayQyHp3jBmmwptGyKJAK
fIPISt6CVQgkxqaNvWWasH1KNNCoJfsku403K+2whIOqzZmpHieCcHuLnEgEYHjW
Brz5ziJlpo61MRFOJqD1DDou3lnyIKQ9wzu1ZERhfwK3aFUCRj3qDGD0r18B5E4f
cG515f4kV1/qtt+etFKFPbfgDweIS6+CFOBoiBWMaYPmdlbQJP1hR2m2ZL0fxUEV
r+LhR5EP/onbXbE7zOIwRxZjC7E+Gjud06KrVP1vJez9oJ/cK+2QU6w2Au+0ObJ8
OYIpezZ+/s6IaVHc3KXnAioN/xovSmqK2leoEvFXyMKOXmbv7dleEWbGse8cqKRW
Xnt2HDK/ecOp55f3llKFDuFKPx24qf2Z4/ItgbNPCWeeAKuWxJTsZKsCe0IIFFIW
yR7isGUJlZjh2RTft/KDcM8TjIp6huOAoy4QFQ5EV47DKUZjB8eQlek8BtCxAjdh
x74BTOa9ejsdqrLPHJIEqp1d/fWiWdxZ1a7Vr/iPoAFf7mB2QwY=
=rDFe
-----END PGP SIGNATURE-----
--=-=-=--